From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: designware_i2c: Optionally check enable status register
Date: Thu, 28 Apr 2016 08:22:36 +0200 [thread overview]
Message-ID: <5721AC2C.7030100@denx.de> (raw)
In-Reply-To: <5721A94A.4090206@denx.de>
Hello Stefan,
Am 28.04.2016 um 08:10 schrieb Stefan Roese:
> Hi Heiko,
>
> On 28.04.2016 08:06, Heiko Schocher wrote:
>> Am 27.04.2016 um 09:02 schrieb Stefan Roese:
>>> Some platforms don't implement the enable status register at offset 0x9c.
>>> The SPEAr600 platform is one of them. The recently added check to this
>>> status register can't be performend on these platforms.
>>>
>>> This patch introduces a new config option that can be enabled on such
>>> platforms not supporting this register.
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Cc: Heiko Schocher <hs@denx.de>
>>> ---
>>> drivers/i2c/designware_i2c.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>
>> No objections, but I miss an entry in drivers/i2c/Kconfig or at least an
>> entry in README. Please add this, thanks!
>
> Yes, I am aware that this is not available via Kconfig. I hesitate
> to add it to the README, as this is a bit outdated. And we should
> move to Kconfig anyways.
Yes!
> I'll work on a patch to move this driver and this config option to
> Kconfig instead.
Ok, thanks for the info, so I am fine with this patch:
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2016-04-28 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 7:02 [U-Boot] [PATCH] i2c: designware_i2c: Optionally check enable status register Stefan Roese
2016-04-28 6:06 ` Heiko Schocher
2016-04-28 6:10 ` Stefan Roese
2016-04-28 6:22 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721AC2C.7030100@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.