Re: [PATCH] clk: renesas: r8a7795: Move MODEMR to DT

[Dirk Behme <dirk.behme@de.bosch.com>]

Hi Geert,

On 28.04.2016 08:52, Geert Uytterhoeven wrote:
> Hi Dirk,
>
> On Thu, Apr 28, 2016 at 8:08 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
>> From: Oleksij Rempel <linux@rempel-privat.de>
>>
>> Map the Mode Monitor Register via the device tree instead of
>> hard coding it in the code. This makes the mapping known to the
>> device tree.
>>
>> Signed-off-by: Pooya Keshavarzi <Pooya.Keshavarzi@de.bosch.com>
>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
>> Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com>
>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>> ---
>>   .../devicetree/bindings/clock/renesas,cpg-mssr.txt |  9 ++++++---
>>   arch/arm64/boot/dts/renesas/r8a7795.dtsi           |  4 +++-
>>   drivers/clk/renesas/r8a7795-cpg-mssr.c             | 22 +++-------------------
>>   drivers/clk/renesas/renesas-cpg-mssr.c             | 19 ++++++++++++++-----
>>   drivers/clk/renesas/renesas-cpg-mssr.h             |  2 +-
>>   5 files changed, 27 insertions(+), 29 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
>> index fefb802..7984485 100644
>> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
>> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
>> @@ -15,8 +15,10 @@ Required Properties:
>>     - compatible: Must be one of:
>>         - "renesas,r8a7795-cpg-mssr" for the r8a7795 SoC
>>
>> -  - reg: Base address and length of the memory resource used by the CPG/MSSR
>> -    block
>> +  - reg:
>> +    - 0: Base address and length of the memory resource used by the CPG/MSSR
>> +         block.
>> +    - 1: Mode Monitor Register.
>>
>>     - clocks: References to external parent clocks, one entry for each entry in
>>       clock-names
>> @@ -46,7 +48,8 @@ Examples
>>
>>          cpg: clock-controller@e6150000 {
>>                  compatible = "renesas,r8a7795-cpg-mssr";
>> -               reg = <0 0xe6150000 0 0x1000>;
>> +               reg = <0 0xe6150000 0 0x1000>,
>> +                     <0 0xe6160060 0 0x4>;
>
> The MODEMR register is not part of the CPG block, but of the RST block.
> So IMHO it doesn't belong in the clock-controller node.


Ok, fine.

So we agree hat this ugly hard coded register address stuff has to be 
removed and replaced by a device tree based solution. Correct?


> BTW, I still prefer something like
> "[PATCH 0/6] arm64: renesas: Obtain MD pin values using syscon/regmap"
> (http://www.spinics.net/lists/linux-sh/msg44757.html).


What's the status of this? I see there a date "1 Sep 2015" ;)

Is this available in any testing tree we could try?


Best regards

Dirk