From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Sebastian Reichel <sre@kernel.org>, Pavel Machel <pavel@ucw.cz>,
Timo Kokkonen <timo.t.kokkonen@iki.fi>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] [media] ir-rx51: Fix build after multiarch changes broke it
Date: Thu, 28 Apr 2016 23:43:07 +0300 [thread overview]
Message-ID: <572275DB.8090300@gmail.com> (raw)
In-Reply-To: <20160428202248.GG5995@atomide.com>
Хи,
On 28.04.2016 23:22, Tony Lindgren wrote:
> * Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160428 12:39]:
>> On 27.04.2016 02:51, Tony Lindgren wrote:
>>
>> omap_dm_timer_request_specific always fails with message "Please use
>> omap_dm_timer_request_by_cap/node()" with DT boot.
>>
>> I hacked the code to use omap_dm_timer_request_by_cap(OMAP_TIMER_HAS_PWM)
>> and it seems to use the correct timer (IR LED blinks, checked with the
>> camera of Samsung S4 mini), but it doesn't actually control either of the TV
>> sets here. The same SW(pierogi) controls them when device is booted to stock
>> kernel. However, this seems another problem not related to the patch.
>
> OK thanks for testing, I'll apply the pdata patch then.
>
> I assume you'll post a separate fix for the request_by_cap
> driver change?
>
Well, it was a hack, it just happens that the first matched timer is
GPT9, I think we should aim for a proper solution (request_by_node()).
Shall I prepare a patch that gets the timer from the DT?
Ivo
WARNING: multiple messages have this Message-ID (diff)
From: ivo.g.dimitrov.75@gmail.com (Ivaylo Dimitrov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] [media] ir-rx51: Fix build after multiarch changes broke it
Date: Thu, 28 Apr 2016 23:43:07 +0300 [thread overview]
Message-ID: <572275DB.8090300@gmail.com> (raw)
In-Reply-To: <20160428202248.GG5995@atomide.com>
??,
On 28.04.2016 23:22, Tony Lindgren wrote:
> * Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160428 12:39]:
>> On 27.04.2016 02:51, Tony Lindgren wrote:
>>
>> omap_dm_timer_request_specific always fails with message "Please use
>> omap_dm_timer_request_by_cap/node()" with DT boot.
>>
>> I hacked the code to use omap_dm_timer_request_by_cap(OMAP_TIMER_HAS_PWM)
>> and it seems to use the correct timer (IR LED blinks, checked with the
>> camera of Samsung S4 mini), but it doesn't actually control either of the TV
>> sets here. The same SW(pierogi) controls them when device is booted to stock
>> kernel. However, this seems another problem not related to the patch.
>
> OK thanks for testing, I'll apply the pdata patch then.
>
> I assume you'll post a separate fix for the request_by_cap
> driver change?
>
Well, it was a hack, it just happens that the first matched timer is
GPT9, I think we should aim for a proper solution (request_by_node()).
Shall I prepare a patch that gets the timer from the DT?
Ivo
next prev parent reply other threads:[~2016-04-28 20:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 23:51 [PATCH 0/2] Fix ir-rx51 by using PWM pdata Tony Lindgren
2016-04-26 23:51 ` Tony Lindgren
2016-04-26 23:51 ` [PATCH 1/2] ARM: OMAP2+: Add more functions to pwm pdata for ir-rx51 Tony Lindgren
2016-04-26 23:51 ` Tony Lindgren
2016-04-26 23:51 ` [PATCH 2/2] [media] ir-rx51: Fix build after multiarch changes broke it Tony Lindgren
2016-04-26 23:51 ` Tony Lindgren
2016-04-27 11:18 ` Pavel Machek
2016-04-27 11:18 ` Pavel Machek
2016-04-28 19:38 ` Ivaylo Dimitrov
2016-04-28 19:38 ` Ivaylo Dimitrov
2016-04-28 20:22 ` Tony Lindgren
2016-04-28 20:22 ` Tony Lindgren
2016-04-28 20:43 ` Ivaylo Dimitrov [this message]
2016-04-28 20:43 ` Ivaylo Dimitrov
2016-04-28 20:55 ` Tony Lindgren
2016-04-28 20:55 ` Tony Lindgren
2016-04-28 21:19 ` [PATCH 0/2] Fix ir-rx51 by using PWM pdata Ivaylo Dimitrov
2016-04-28 21:19 ` Ivaylo Dimitrov
2016-04-28 21:27 ` Tony Lindgren
2016-04-28 21:27 ` Tony Lindgren
2016-04-30 17:52 ` Ivaylo Dimitrov
2016-04-30 17:52 ` Ivaylo Dimitrov
2016-05-05 17:11 ` Tony Lindgren
2016-05-05 17:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572275DB.8090300@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=narmstrong@baylibre.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=timo.t.kokkonen@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.