[PATCH kernel] powerpc/powernv: Fix debug macro

[PATCH kernel] powerpc/powernv: Fix debug macro

[Alexey Kardashevskiy]

When cfg_dbg() is enabled (i.e. mapped to printk()), gcc produces
errors as the __func__ parameter is missing (pnv_pci_cfg_read() has one);
this adds the missing parameter.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 arch/powerpc/platforms/powernv/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c
index 73c8dc2..cec1530 100644
--- a/arch/powerpc/platforms/powernv/pci.c
+++ b/arch/powerpc/platforms/powernv/pci.c
@@ -463,7 +463,7 @@ int pnv_pci_cfg_write(struct pci_dn *pdn,
 	u32 bdfn = (pdn->busno << 8) | pdn->devfn;
 
 	cfg_dbg("%s: bus: %x devfn: %x +%x/%x -> %08x\n",
-		pdn->busno, pdn->devfn, where, size, val);
+		__func__, pdn->busno, pdn->devfn, where, size, val);
 	switch (size) {
 	case 1:
 		opal_pci_config_write_byte(phb->opal_id, bdfn, where, val);
-- 
2.5.0.rc3

Re: [PATCH kernel] powerpc/powernv: Fix debug macro

[Andrew Donnellan]

On 29/04/16 14:56, Alexey Kardashevskiy wrote:
> When cfg_dbg() is enabled (i.e. mapped to printk()), gcc produces
> errors as the __func__ parameter is missing (pnv_pci_cfg_read() has one);
> this adds the missing parameter.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Re: [PATCH kernel] powerpc/powernv: Fix debug macro

[Michael Ellerman]

On Fri, 2016-04-29 at 14:56 +1000, Alexey Kardashevskiy wrote:

> When cfg_dbg() is enabled (i.e. mapped to printk()), gcc produces
> errors as the __func__ parameter is missing (pnv_pci_cfg_read() has one);
> this adds the missing parameter.

Thanks.

But the whole file should just be converted to use pr_devel(), which is an
existing well known macro and will catch this for you.

cheers