From: Olivier Matz <olivier.matz@6wind.com>
To: "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin" <helin.zhang@intel.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
John Daley <johndale@cisco.com>
Subject: removing mbuf error flags
Date: Fri, 29 Apr 2016 14:25:07 +0200 [thread overview]
Message-ID: <572352A3.6030400@6wind.com> (raw)
Hi,
In rte_mbuf.h, some rx flags are set to 0 since a long time since
nearly 2 years. It means nobody use them. They were introduced by
the following commit:
http://dpdk.org/browse/dpdk/commit/?id=c22265f6
As far as I understand, these flags were introduced to let the
application know that a received packet is invalid.
The 2 drivers using them are i40e and enic. But as this flags are 0
today, it means that invalid packets are silently given to the
application.
My opinion is that invalid packets should not be given to the
application and only a statistic counter should be incremented.
No application check these flags today (in examples, or testpmd).
I would like to remove these flags.
Thoughs?
Olivier
next reply other threads:[~2016-04-29 12:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 12:25 Olivier Matz [this message]
2016-04-29 17:47 ` removing mbuf error flags John Daley (johndale)
2016-04-29 18:16 ` Don Provan
2016-04-29 18:24 ` Jay Rolette
2016-04-29 20:00 ` Arnon Warshavsky
2016-04-29 20:57 ` Olivier MATZ
2016-04-30 1:41 ` Don Provan
2016-05-10 8:40 ` [RFC] mbuf: remove unused rx " Olivier Matz
2016-05-12 1:32 ` John Daley (johndale)
2016-05-12 9:25 ` Olivier MATZ
2016-05-23 7:56 ` [PATCH] mbuf: remove unused Rx " Olivier Matz
2016-06-13 11:39 ` Olivier Matz
2016-06-13 12:39 ` Ananyev, Konstantin
2016-06-13 14:00 ` Bruce Richardson
2016-06-13 12:42 ` Ananyev, Konstantin
2016-06-13 12:49 ` Olivier Matz
2016-06-13 13:25 ` Bruce Richardson
2016-06-13 13:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572352A3.6030400@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=johndale@cisco.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.