All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Scott Mayhew <smayhew@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH] exportfs: add the debug option
Date: Fri, 29 Apr 2016 11:09:30 -0400	[thread overview]
Message-ID: <5723792A.8020408@RedHat.com> (raw)
In-Reply-To: <1461936356-26727-1-git-send-email-smayhew@redhat.com>



On 04/29/2016 09:25 AM, Scott Mayhew wrote:
> Since calling xlog(D_GENERAL) will cause exportfs to exit with a status
> of 1, there really should be a way to see those messages for debugging
> purposes.
> 
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
>  utils/exportfs/exportfs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index a9151ff..a5eb156 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -108,11 +108,14 @@ main(int argc, char **argv)
>  	xlog_stderr(1);
>  	xlog_syslog(0);
>  
> -	while ((c = getopt(argc, argv, "afhio:ruvs")) != EOF) {
> +	while ((c = getopt(argc, argv, "ad:fhio:ruvs")) != EOF) {
>  		switch(c) {
>  		case 'a':
>  			f_all = 1;
>  			break;
> +		case 'd':
> +			xlog_sconfig(optarg, 1);
> +			break;
I'm all for doing this but there needs to be an
usage() update and man page update. For the man
page update, just rip the verbiage out of the
mountd man page since they are the same.

steved.
 
>  		case 'f':
>  			force_flush = 1;
>  			break;
> 

      reply	other threads:[~2016-04-29 15:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 13:25 [nfs-utils PATCH] exportfs: add the debug option Scott Mayhew
2016-04-29 15:09 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5723792A.8020408@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=smayhew@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.