All of lore.kernel.org
 help / color / mirror / Atom feed
* [nfs-utils PATCH] exportfs: add the debug option
@ 2016-04-29 13:25 Scott Mayhew
  2016-04-29 15:09 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Scott Mayhew @ 2016-04-29 13:25 UTC (permalink / raw)
  To: steved; +Cc: linux-nfs

Since calling xlog(D_GENERAL) will cause exportfs to exit with a status
of 1, there really should be a way to see those messages for debugging
purposes.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 utils/exportfs/exportfs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index a9151ff..a5eb156 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -108,11 +108,14 @@ main(int argc, char **argv)
 	xlog_stderr(1);
 	xlog_syslog(0);
 
-	while ((c = getopt(argc, argv, "afhio:ruvs")) != EOF) {
+	while ((c = getopt(argc, argv, "ad:fhio:ruvs")) != EOF) {
 		switch(c) {
 		case 'a':
 			f_all = 1;
 			break;
+		case 'd':
+			xlog_sconfig(optarg, 1);
+			break;
 		case 'f':
 			force_flush = 1;
 			break;
-- 
2.4.11


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [nfs-utils PATCH] exportfs: add the debug option
  2016-04-29 13:25 [nfs-utils PATCH] exportfs: add the debug option Scott Mayhew
@ 2016-04-29 15:09 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2016-04-29 15:09 UTC (permalink / raw)
  To: Scott Mayhew; +Cc: linux-nfs



On 04/29/2016 09:25 AM, Scott Mayhew wrote:
> Since calling xlog(D_GENERAL) will cause exportfs to exit with a status
> of 1, there really should be a way to see those messages for debugging
> purposes.
> 
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
>  utils/exportfs/exportfs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index a9151ff..a5eb156 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -108,11 +108,14 @@ main(int argc, char **argv)
>  	xlog_stderr(1);
>  	xlog_syslog(0);
>  
> -	while ((c = getopt(argc, argv, "afhio:ruvs")) != EOF) {
> +	while ((c = getopt(argc, argv, "ad:fhio:ruvs")) != EOF) {
>  		switch(c) {
>  		case 'a':
>  			f_all = 1;
>  			break;
> +		case 'd':
> +			xlog_sconfig(optarg, 1);
> +			break;
I'm all for doing this but there needs to be an
usage() update and man page update. For the man
page update, just rip the verbiage out of the
mountd man page since they are the same.

steved.
 
>  		case 'f':
>  			force_flush = 1;
>  			break;
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-29 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-29 13:25 [nfs-utils PATCH] exportfs: add the debug option Scott Mayhew
2016-04-29 15:09 ` Steve Dickson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.