From: Peter Hurley <peter@hurleysoftware.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback
Date: Fri, 29 Apr 2016 08:38:09 -0700 [thread overview]
Message-ID: <57237FE1.8030200@hurleysoftware.com> (raw)
In-Reply-To: <1461934714-18681-4-git-send-email-geert+renesas@glider.be>
On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote:
> Documentation/serial/driver clearly states:
>
> If the port does not support CTS, DCD or DSR, the driver should
> indicate that the signal is permanently active.
>
> Hence always set TIOCM_CTS, as we currently don't look at the CTS
> hardware line state at all.
>
> FWIW, this fixes the transmit path when hardware-assisted flow control
> is enabled, and userspace enables CRTSCTS.
> The receive path is still broken, as RTS is never asserted.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback
Date: Fri, 29 Apr 2016 15:38:09 +0000 [thread overview]
Message-ID: <57237FE1.8030200@hurleysoftware.com> (raw)
In-Reply-To: <1461934714-18681-4-git-send-email-geert+renesas@glider.be>
On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote:
> Documentation/serial/driver clearly states:
>
> If the port does not support CTS, DCD or DSR, the driver should
> indicate that the signal is permanently active.
>
> Hence always set TIOCM_CTS, as we currently don't look at the CTS
> hardware line state at all.
>
> FWIW, this fixes the transmit path when hardware-assisted flow control
> is enabled, and userspace enables CRTSCTS.
> The receive path is still broken, as RTS is never asserted.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
next prev parent reply other threads:[~2016-04-29 15:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 12:58 [PATCH v2 00/11] serial: sh-sci: Hardware Flow Control Updates Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 12:58 ` [PATCH v2 01/11] serial: sh-sci: Update DT binding documentation for GPIO modem lines Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 12:58 ` [PATCH v2 02/11] serial: sh-sci: Update DT binding documentation for dedicated RTS/CTS Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-05-03 18:01 ` Rob Herring
2016-05-03 18:01 ` Rob Herring
2016-04-29 12:58 ` [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 15:38 ` Peter Hurley [this message]
2016-04-29 15:38 ` Peter Hurley
2016-04-29 12:58 ` [PATCH v2 04/11] serial: sh-sci: Add support for GPIO-controlled modem lines Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 15:39 ` Peter Hurley
2016-04-29 15:39 ` Peter Hurley
2016-04-29 12:58 ` [PATCH v2 05/11] serial: sh-sci: Do not open-code sci_getreg() Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 15:39 ` Peter Hurley
2016-04-29 15:39 ` Peter Hurley
2016-04-29 12:58 ` [PATCH v2 06/11] serial: sh-sci: Add more Serial Port Register documentation Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 15:41 ` Peter Hurley
2016-04-29 15:41 ` Peter Hurley
2016-04-29 12:58 ` [PATCH v2 07/11] serial: sh-sci: Add more Serial Port Control/Data " Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 15:42 ` Peter Hurley
2016-04-29 15:42 ` Peter Hurley
2016-04-29 12:58 ` [PATCH v2 08/11] serial: sh-sci: Correct pin initialization on (H)SCIF Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 15:59 ` Peter Hurley
2016-04-29 15:59 ` Peter Hurley
2016-04-29 20:00 ` Geert Uytterhoeven
2016-04-29 20:00 ` Geert Uytterhoeven
2016-04-29 12:58 ` [PATCH v2 09/11] serial: sh-sci: Add pin initialization for SCIFA/SCIFB Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 12:58 ` [PATCH v2 10/11] serial: sh-sci: Fix support for hardware-assisted RTS/CTS Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
2016-04-29 12:58 ` [PATCH v2 11/11] serial: sh-sci: Add DT support for dedicated RTS/CTS Geert Uytterhoeven
2016-04-29 12:58 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57237FE1.8030200@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.