All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Hackmann <ghackmann@google.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"Gustavo Padovan" <gustavo@padovan.org>,
	"Daniel Stone" <daniels@collabora.com>,
	"Riley Andrews" <riandrews@android.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Arve Hjønnevåg" <arve@android.com>,
	"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support
Date: Fri, 29 Apr 2016 14:14:31 -0700	[thread overview]
Message-ID: <5723CEB7.8090609@google.com> (raw)
In-Reply-To: <20160427063904.GH2558@phenom.ffwll.local>

On 04/26/2016 11:39 PM, Daniel Vetter wrote:
>> A (per-CRTC?) array of fences would be more flexible.  And even in the cases
>> where you could make a 1-to-1 mapping between planes and fences, it's not
>> that much more work for userspace to assemble those fences into an array
>> anyway.
>
> I'm ok with an array too if that's what you folks prefer (it's meant to be
> used by you after all). I just don't want just 1 fence for the entire op,
> forcing userspace to first merge them all together. That seems silly.
>
> One side-effect of that is that we'd also have to rework all the internal
> bits and move fences around in atomic. Which means change a pile of
> drivers. Not sure that's worth it, but I'd be ok either way really.
> -Daniel
>

It's not a strong preference on my end.  The 1:1 plane-to-layer mapping 
breaks down somewhat on hardware where you need to split large 
hwcomposer layers across multiple DRM planes.

That said, you can force that case to fit by just dup()ing the fence a 
bunch of times or arbitrarily picking one of the planes to assign the 
fence to.  Either is kludgey, but I can't argue it's kludgey enough to 
justify refactoring a bunch of existing driver code.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Greg Hackmann <ghackmann@google.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"Gustavo Padovan" <gustavo@padovan.org>,
	"Daniel Stone" <daniels@collabora.com>,
	"Riley Andrews" <riandrews@android.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Arve Hjønnevåg" <arve@android.com>,
	"John Harrison" <John.C.Harrison@Intel.com>
Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support
Date: Fri, 29 Apr 2016 14:14:31 -0700	[thread overview]
Message-ID: <5723CEB7.8090609@google.com> (raw)
In-Reply-To: <20160427063904.GH2558@phenom.ffwll.local>

On 04/26/2016 11:39 PM, Daniel Vetter wrote:
>> A (per-CRTC?) array of fences would be more flexible.  And even in the cases
>> where you could make a 1-to-1 mapping between planes and fences, it's not
>> that much more work for userspace to assemble those fences into an array
>> anyway.
>
> I'm ok with an array too if that's what you folks prefer (it's meant to be
> used by you after all). I just don't want just 1 fence for the entire op,
> forcing userspace to first merge them all together. That seems silly.
>
> One side-effect of that is that we'd also have to rework all the internal
> bits and move fences around in atomic. Which means change a pile of
> drivers. Not sure that's worth it, but I'd be ok either way really.
> -Daniel
>

It's not a strong preference on my end.  The 1:1 plane-to-layer mapping 
breaks down somewhat on hardware where you need to split large 
hwcomposer layers across multiple DRM planes.

That said, you can force that case to fit by just dup()ing the fence a 
bunch of times or arbitrarily picking one of the planes to assign the 
fence to.  Either is kludgey, but I can't argue it's kludgey enough to 
justify refactoring a bunch of existing driver code.

  parent reply	other threads:[~2016-04-29 21:14 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 22:33 [RFC v2 0/8] drm: explicit fencing support Gustavo Padovan
2016-04-25 22:33 ` Gustavo Padovan
2016-04-25 22:33 ` [RFC v2 1/8] dma-buf/fence: add fence_collection fences Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-26 14:41   ` Daniel Vetter
2016-04-26 14:41     ` Daniel Vetter
2016-04-26 15:02     ` Gustavo Padovan
2016-04-27  6:36       ` Daniel Vetter
2016-04-27  6:36         ` Daniel Vetter
2016-04-26 15:09   ` Chris Wilson
2016-04-26 15:09     ` Chris Wilson
2016-04-28 14:47     ` Gustavo Padovan
2016-04-28 14:47       ` Gustavo Padovan
2016-04-25 22:33 ` [RFC v2 2/8] Documentation: add fence-collection to kernel DocBook Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-25 22:33 ` [RFC v2 3/8] dma-buf/sync_file: add sync_file_fences_get() Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-25 22:33 ` [RFC v2 4/8] drm/fence: allow fence waiting to be interrupted by userspace Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-25 22:33 ` [RFC v2 5/8] drm/fence: add in-fences support Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-26 10:10   ` Ville Syrjälä
2016-04-26 10:10     ` Ville Syrjälä
2016-04-26 14:14     ` Gustavo Padovan
2016-04-26 14:36       ` Daniel Vetter
2016-04-26 14:36         ` Daniel Vetter
2016-04-26 16:26         ` Ville Syrjälä
2016-04-26 16:26           ` Ville Syrjälä
2016-04-26 17:20           ` Daniel Vetter
2016-04-26 17:20             ` Daniel Vetter
2016-04-26 17:40             ` Ville Syrjälä
2016-04-26 18:23               ` Daniel Vetter
2016-04-26 18:23                 ` Daniel Vetter
2016-04-26 18:55                 ` Ville Syrjälä
2016-04-26 18:55                   ` Ville Syrjälä
2016-04-26 20:05                   ` Daniel Vetter
2016-04-26 20:48                     ` Greg Hackmann
2016-04-26 20:48                       ` Greg Hackmann
2016-04-27  6:39                       ` Daniel Vetter
2016-04-27  6:39                         ` Daniel Vetter
2016-04-28 21:28                         ` Rob Clark
2016-04-28 21:28                           ` Rob Clark
2016-04-29  7:48                           ` Daniel Stone
2016-04-29  7:48                             ` Daniel Stone
2016-04-29 22:23                             ` Rob Clark
2016-04-29 22:23                               ` Rob Clark
2016-07-12 21:14                               ` Dominik Behr
2016-07-12 21:21                                 ` Gustavo Padovan
2016-04-29 21:14                         ` Greg Hackmann [this message]
2016-04-29 21:14                           ` Greg Hackmann
2016-04-27  6:57                       ` Daniel Stone
2016-04-27  6:57                         ` Daniel Stone
2016-04-28 14:36                         ` Gustavo Padovan
2016-04-28 14:36                           ` Gustavo Padovan
2016-04-28 14:38                           ` Daniel Vetter
2016-04-28 14:38                             ` Daniel Vetter
2016-04-28 16:56                           ` Ville Syrjälä
2016-04-28 16:56                             ` Ville Syrjälä
2016-04-28 17:43                             ` Daniel Vetter
2016-04-28 17:43                               ` Daniel Vetter
2016-04-28 17:51                               ` Ville Syrjälä
2016-04-28 17:51                                 ` Ville Syrjälä
2016-04-28 17:55                                 ` Gustavo Padovan
2016-04-28 18:02                                   ` Daniel Vetter
2016-04-28 18:02                                     ` Daniel Vetter
2016-04-28 18:17                             ` Ville Syrjälä
2016-04-28 18:17                               ` Ville Syrjälä
2016-04-28 20:40                               ` Daniel Vetter
2016-04-28 20:40                                 ` Daniel Vetter
2016-04-26 16:25       ` Ville Syrjälä
2016-04-25 22:33 ` [RFC v2 6/8] drm/fence: add fence to drm_pending_event Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-25 22:33 ` [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-26 10:12   ` Ville Syrjälä
2016-04-26 10:12     ` Ville Syrjälä
2016-04-26 14:23     ` Gustavo Padovan
2016-04-26 16:34       ` Ville Syrjälä
2016-04-26 16:34         ` Ville Syrjälä
2016-04-27  8:23   ` Daniel Stone
2016-04-27  8:23     ` Daniel Stone
2016-04-25 22:33 ` [RFC v2 8/8] drm/fence: add out-fences support Gustavo Padovan
2016-04-25 22:33   ` Gustavo Padovan
2016-04-26 14:53   ` Daniel Vetter
2016-04-26 14:53     ` Daniel Vetter
2016-04-28 15:23     ` Gustavo Padovan
2016-04-28 15:23       ` Gustavo Padovan
2016-04-25 23:21 ` [RFC v2 0/8] drm: explicit fencing support Mike Lothian
2016-04-26  6:30   ` Daniel Vetter
2016-04-26  6:30     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5723CEB7.8090609@google.com \
    --to=ghackmann@google.com \
    --cc=John.C.Harrison@Intel.com \
    --cc=arve@android.com \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=gustavo@padovan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.