From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
Date: Sat, 30 Apr 2016 10:52:29 +0700 [thread overview]
Message-ID: <57242BFD.4060605@openwrt.org> (raw)
In-Reply-To: <1461935194-19632-1-git-send-email-helmut.schaa@googlemail.com>
On 2016-04-29 20:06, Helmut Schaa wrote:
> Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
> "ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
> condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
> never evaluate to true.
>
> Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
> marcros instead.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
> ---
> Just stumbled over that piece of code while looking into TX99, so
> this is only compile-tested.
>
> Felix, can you please confirm if this is correct or if removing
> the whole block would be better?
This patch looks good to me.
Acked-by: Felix Fietkau <nbd@openwrt.org>
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless@vger.kernel.org
Cc: ath9k-devel@lists.ath9k.org, kvalo@qca.qualcomm.com,
ath9k-devel@qca.qualcomm.com
Subject: Re: [PATCH] ath9k: Fix symbol overlap window for half/quarter channels
Date: Sat, 30 Apr 2016 10:52:29 +0700 [thread overview]
Message-ID: <57242BFD.4060605@openwrt.org> (raw)
In-Reply-To: <1461935194-19632-1-git-send-email-helmut.schaa@googlemail.com>
On 2016-04-29 20:06, Helmut Schaa wrote:
> Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
> "ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
> condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
> never evaluate to true.
>
> Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
> marcros instead.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
> ---
> Just stumbled over that piece of code while looking into TX99, so
> this is only compile-tested.
>
> Felix, can you please confirm if this is correct or if removing
> the whole block would be better?
This patch looks good to me.
Acked-by: Felix Fietkau <nbd@openwrt.org>
next prev parent reply other threads:[~2016-04-30 3:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 13:06 [ath9k-devel] [PATCH] ath9k: Fix symbol overlap window for half/quarter channels Helmut Schaa
2016-04-29 13:06 ` Helmut Schaa
2016-04-30 3:52 ` Felix Fietkau [this message]
2016-04-30 3:52 ` Felix Fietkau
2016-05-09 18:13 ` [ath9k-devel] " Kalle Valo
2016-05-09 18:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57242BFD.4060605@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.