Re: Re: [PATCH v11 2/2] PCI: eic7700: Add Eswin PCIe host controller driver

["Min Lin" <linmin@eswincomputing.com>]

Hi Mani,

Thanks for your kind suggestion and help.


> -----Original Messages-----
> From: "Manivannan Sadhasivam" <mani@kernel.org>
> Send time:Thursday, 05/03/2026 14:07:31
> To: zhangsenchuan@eswincomputing.com
> Cc: bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, robh@kernel.org, p.zabel@pengutronix.de, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, christian.bruel@foss.st.com, shradha.t@samsung.com, krishna.chundru@oss.qualcomm.com, thippeswamy.havalige@amd.com, inochiama@gmail.com, Frank.li@nxp.com, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com, ouyanghui@eswincomputing.com
> Subject: Re: [PATCH v11 2/2] PCI: eic7700: Add Eswin PCIe host controller driver
> 
> On Fri, Feb 27, 2026 at 07:18:08PM +0800, zhangsenchuan@eswincomputing.com wrote:
> > From: Senchuan Zhang <zhangsenchuan@eswincomputing.com>
> > 
> > Add driver for the Eswin EIC7700 PCIe host controller, which is based on
> > the DesignWare PCIe core, IP revision 5.96a. The PCIe Gen.3 controller
> > supports a data rate of 8 GT/s and 4 channels, support INTx and MSI
> > interrupts.
> > 
> 
> Is the driver going to work only for the PCIe RC IP in EIC7700 SoC or for the
> upcoming Eswin SoCs as well? Just curious because, we don't name drivers based
> on one SoC name, but by the vendor so that the driver (if compatible) can be
> used across other SoCs from the vendor.
> 
> If it can work across other SoCs, then I can change 'eic7700' to 'eswin', where
> applicable while applying.
> 

This PCIe RC IP in EIC7700 will only be used for EIC7700 SoC. One thing for sure
is our next SoC will use a higher IP revision of the DesignWare PCIe core.
In the future, there is no doubt that the use of IP from other manufacturers may
be considered.

Based on this, may I ask which name do you think is better, eic7700' or 'eswin'?

I found there is a commit on drivers/pci/controller/dwc/pcie-tegra194.c
It added Tegra234 PCIe support in pcie-tegra194.c
Is this naming approach no longer recommended?

> - Mani
> 
> > Signed-off-by: Yu Ning <ningyu@eswincomputing.com>
> > Signed-off-by: Yanghui Ou <ouyanghui@eswincomputing.com>
> > Signed-off-by: Senchuan Zhang <zhangsenchuan@eswincomputing.com>
> > ---
> >  drivers/pci/controller/dwc/Kconfig        |  11 +
> >  drivers/pci/controller/dwc/Makefile       |   1 +
> >  drivers/pci/controller/dwc/pcie-eic7700.c | 409 ++++++++++++++++++++++
> >  3 files changed, 421 insertions(+)
> >  create mode 100644 drivers/pci/controller/dwc/pcie-eic7700.c
> > 
[snip]

Regards,
Lin Min