All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jan Vesely <jano.vesely@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header
Date: Mon, 2 May 2016 15:18:02 +0300	[thread overview]
Message-ID: <5727457A.30509@msgid.tls.msk.ru> (raw)
In-Reply-To: <1461935279-30418-1-git-send-email-jano.vesely@gmail.com>

29.04.2016 16:07, Jan Vesely пишет:
> Fixes build failure with --enable-xfsctl and
> new linux headers (>=4.5) and older xfsprogs(<4.5):
> In file included from /usr/include/xfs/xfs.h:38:0,
>                  from /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:97:
> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
>  struct fsxattr {
>         ^
> In file included from /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:60:0:
> /usr/include/linux/fs.h:155:8: note: originally defined here
>  struct fsxattr {

This is a bug in xfsprogs, which has been fixed by a later
release.

I think it is wrong to fix it in qemu.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Jan Vesely <jano.vesely@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header
Date: Mon, 2 May 2016 15:18:02 +0300	[thread overview]
Message-ID: <5727457A.30509@msgid.tls.msk.ru> (raw)
In-Reply-To: <1461935279-30418-1-git-send-email-jano.vesely@gmail.com>

29.04.2016 16:07, Jan Vesely пишет:
> Fixes build failure with --enable-xfsctl and
> new linux headers (>=4.5) and older xfsprogs(<4.5):
> In file included from /usr/include/xfs/xfs.h:38:0,
>                  from /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:97:
> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
>  struct fsxattr {
>         ^
> In file included from /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:60:0:
> /usr/include/linux/fs.h:155:8: note: originally defined here
>  struct fsxattr {

This is a bug in xfsprogs, which has been fixed by a later
release.

I think it is wrong to fix it in qemu.

Thanks,

/mjt

  parent reply	other threads:[~2016-05-02 12:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 13:07 [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header Jan Vesely
2016-04-29 13:07 ` [Qemu-devel] " Jan Vesely
2016-04-29 13:54 ` [Qemu-trivial] " Stefan Weil
2016-04-29 13:54   ` [Qemu-devel] " Stefan Weil
2016-04-29 13:54 ` [Qemu-trivial] " Peter Maydell
2016-04-29 13:54   ` [Qemu-devel] " Peter Maydell
2016-04-29 13:56   ` [Qemu-trivial] " Stefan Weil
2016-04-29 13:56     ` [Qemu-devel] " Stefan Weil
2016-04-29 14:00     ` [Qemu-trivial] " Peter Maydell
2016-04-29 14:00       ` [Qemu-devel] " Peter Maydell
2016-04-29 14:31       ` [Qemu-trivial] " Stefan Weil
2016-04-29 14:31         ` [Qemu-devel] " Stefan Weil
2016-04-29 14:49         ` [Qemu-trivial] " Peter Maydell
2016-04-29 14:49           ` [Qemu-devel] " Peter Maydell
2016-04-29 17:14           ` [Qemu-trivial] " Jan Vesely
2016-04-29 17:14             ` [Qemu-devel] " Jan Vesely
2016-04-29 17:15           ` [Qemu-trivial] [PATCH v2] " Jan Vesely
2016-04-29 17:15             ` [Qemu-devel] " Jan Vesely
2016-05-02 12:07             ` [Qemu-trivial] " Peter Maydell
2016-05-02 12:07               ` [Qemu-devel] " Peter Maydell
2016-05-02 12:18 ` Michael Tokarev [this message]
2016-05-02 12:18   ` [Qemu-devel] [Qemu-trivial] [PATCH] " Michael Tokarev
2016-05-02 12:30   ` Peter Maydell
2016-05-02 12:30     ` [Qemu-devel] " Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2016-03-20  1:18 Jan Vesely
2016-04-12 21:09 ` Jan Vesely
2016-04-29  0:54   ` Jan Vesely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5727457A.30509@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=armbru@redhat.com \
    --cc=jano.vesely@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.