* [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
@ 2016-04-27 12:39 ` Stanislav Meduna
0 siblings, 0 replies; 10+ messages in thread
From: Stanislav Meduna @ 2016-04-27 12:39 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes the issue where the mxs_ocotp_read is reading
the ocotp in reg_size steps but decrements the remaining size
by 1. The number of iterations is thus four times higher,
overwriting the area behind the output buffer.
Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Stanislav Meduna <stano@meduna.org>
---
drivers/nvmem/mxs-ocotp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/mxs-ocotp.c b/drivers/nvmem/mxs-ocotp.c
index 8ba19bb..2bb3c57 100644
--- a/drivers/nvmem/mxs-ocotp.c
+++ b/drivers/nvmem/mxs-ocotp.c
@@ -94,7 +94,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
if (ret)
goto close_banks;
- while (val_size) {
+ while (val_size >= reg_size) {
if ((offset < OCOTP_DATA_OFFSET) || (offset % 16)) {
/* fill up non-data register */
*buf = 0;
@@ -103,7 +103,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
}
buf++;
- val_size--;
+ val_size -= reg_size;
offset += reg_size;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
@ 2016-04-27 12:39 ` Stanislav Meduna
0 siblings, 0 replies; 10+ messages in thread
From: Stanislav Meduna @ 2016-04-27 12:39 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel@lists.infradead.org
Cc: Srinivas Kandagatla, Maxime Ripard, Stefan Wahren
This patch fixes the issue where the mxs_ocotp_read is reading
the ocotp in reg_size steps but decrements the remaining size
by 1. The number of iterations is thus four times higher,
overwriting the area behind the output buffer.
Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Stanislav Meduna <stano@meduna.org>
---
drivers/nvmem/mxs-ocotp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/mxs-ocotp.c b/drivers/nvmem/mxs-ocotp.c
index 8ba19bb..2bb3c57 100644
--- a/drivers/nvmem/mxs-ocotp.c
+++ b/drivers/nvmem/mxs-ocotp.c
@@ -94,7 +94,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
if (ret)
goto close_banks;
- while (val_size) {
+ while (val_size >= reg_size) {
if ((offset < OCOTP_DATA_OFFSET) || (offset % 16)) {
/* fill up non-data register */
*buf = 0;
@@ -103,7 +103,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
}
buf++;
- val_size--;
+ val_size -= reg_size;
offset += reg_size;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
2016-04-27 12:39 ` Stanislav Meduna
@ 2016-05-02 13:55 ` Stefan Wahren
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Wahren @ 2016-05-02 13:55 UTC (permalink / raw)
To: linux-arm-kernel
Hi Srinivas,
hi Greg,
Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
> This patch fixes the issue where the mxs_ocotp_read is reading
> the ocotp in reg_size steps but decrements the remaining size
> by 1. The number of iterations is thus four times higher,
> overwriting the area behind the output buffer.
>
> Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Stanislav Meduna <stano@meduna.org>
any change to get this critical fix into 4.6?
Regards
Stefan
> ---
> drivers/nvmem/mxs-ocotp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/mxs-ocotp.c b/drivers/nvmem/mxs-ocotp.c
> index 8ba19bb..2bb3c57 100644
> --- a/drivers/nvmem/mxs-ocotp.c
> +++ b/drivers/nvmem/mxs-ocotp.c
> @@ -94,7 +94,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
> if (ret)
> goto close_banks;
>
> - while (val_size) {
> + while (val_size >= reg_size) {
> if ((offset < OCOTP_DATA_OFFSET) || (offset % 16)) {
> /* fill up non-data register */
> *buf = 0;
> @@ -103,7 +103,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
> }
>
> buf++;
> - val_size--;
> + val_size -= reg_size;
> offset += reg_size;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
@ 2016-05-02 13:55 ` Stefan Wahren
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Wahren @ 2016-05-02 13:55 UTC (permalink / raw)
To: Srinivas Kandagatla, Greg Kroah-Hartman
Cc: Stanislav Meduna, linux-kernel,
linux-arm-kernel@lists.infradead.org, Maxime Ripard
Hi Srinivas,
hi Greg,
Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
> This patch fixes the issue where the mxs_ocotp_read is reading
> the ocotp in reg_size steps but decrements the remaining size
> by 1. The number of iterations is thus four times higher,
> overwriting the area behind the output buffer.
>
> Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
> Signed-off-by: Stanislav Meduna <stano@meduna.org>
any change to get this critical fix into 4.6?
Regards
Stefan
> ---
> drivers/nvmem/mxs-ocotp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/mxs-ocotp.c b/drivers/nvmem/mxs-ocotp.c
> index 8ba19bb..2bb3c57 100644
> --- a/drivers/nvmem/mxs-ocotp.c
> +++ b/drivers/nvmem/mxs-ocotp.c
> @@ -94,7 +94,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
> if (ret)
> goto close_banks;
>
> - while (val_size) {
> + while (val_size >= reg_size) {
> if ((offset < OCOTP_DATA_OFFSET) || (offset % 16)) {
> /* fill up non-data register */
> *buf = 0;
> @@ -103,7 +103,7 @@ static int mxs_ocotp_read(void *context, const void *reg, size_t reg_size,
> }
>
> buf++;
> - val_size--;
> + val_size -= reg_size;
> offset += reg_size;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
2016-05-02 13:55 ` Stefan Wahren
@ 2016-05-02 14:44 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2016-05-02 14:44 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 02, 2016 at 03:55:53PM +0200, Stefan Wahren wrote:
> Hi Srinivas,
> hi Greg,
>
> Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
> > This patch fixes the issue where the mxs_ocotp_read is reading
> > the ocotp in reg_size steps but decrements the remaining size
> > by 1. The number of iterations is thus four times higher,
> > overwriting the area behind the output buffer.
> >
> > Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
> > Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
> > Signed-off-by: Stanislav Meduna <stano@meduna.org>
>
> any change to get this critical fix into 4.6?
This is the first I've seen this patch :(
Can you resend it in a format I can apply it in?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
@ 2016-05-02 14:44 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2016-05-02 14:44 UTC (permalink / raw)
To: Stefan Wahren
Cc: Srinivas Kandagatla, Stanislav Meduna, linux-kernel,
linux-arm-kernel@lists.infradead.org, Maxime Ripard
On Mon, May 02, 2016 at 03:55:53PM +0200, Stefan Wahren wrote:
> Hi Srinivas,
> hi Greg,
>
> Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
> > This patch fixes the issue where the mxs_ocotp_read is reading
> > the ocotp in reg_size steps but decrements the remaining size
> > by 1. The number of iterations is thus four times higher,
> > overwriting the area behind the output buffer.
> >
> > Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
> > Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
> > Signed-off-by: Stanislav Meduna <stano@meduna.org>
>
> any change to get this critical fix into 4.6?
This is the first I've seen this patch :(
Can you resend it in a format I can apply it in?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
2016-05-02 14:44 ` Greg Kroah-Hartman
@ 2016-05-02 14:50 ` Stefan Wahren
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Wahren @ 2016-05-02 14:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stano,
Am 02.05.2016 um 16:44 schrieb Greg Kroah-Hartman:
> On Mon, May 02, 2016 at 03:55:53PM +0200, Stefan Wahren wrote:
>> Hi Srinivas,
>> hi Greg,
>>
>> Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
>>> This patch fixes the issue where the mxs_ocotp_read is reading
>>> the ocotp in reg_size steps but decrements the remaining size
>>> by 1. The number of iterations is thus four times higher,
>>> overwriting the area behind the output buffer.
>>>
>>> Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
>>> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> Signed-off-by: Stanislav Meduna <stano@meduna.org>
>> any change to get this critical fix into 4.6?
> This is the first I've seen this patch :(
sorry for this.
>
> Can you resend it in a format I can apply it in?
Could you please resend V2 to Greg?
Thanks
Stefan
>
> thanks,
>
> greg k-h
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
@ 2016-05-02 14:50 ` Stefan Wahren
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Wahren @ 2016-05-02 14:50 UTC (permalink / raw)
To: Greg Kroah-Hartman, Stanislav Meduna
Cc: Maxime Ripard, Srinivas Kandagatla,
linux-arm-kernel@lists.infradead.org, linux-kernel
Hi Stano,
Am 02.05.2016 um 16:44 schrieb Greg Kroah-Hartman:
> On Mon, May 02, 2016 at 03:55:53PM +0200, Stefan Wahren wrote:
>> Hi Srinivas,
>> hi Greg,
>>
>> Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
>>> This patch fixes the issue where the mxs_ocotp_read is reading
>>> the ocotp in reg_size steps but decrements the remaining size
>>> by 1. The number of iterations is thus four times higher,
>>> overwriting the area behind the output buffer.
>>>
>>> Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
>>> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> Signed-off-by: Stanislav Meduna <stano@meduna.org>
>> any change to get this critical fix into 4.6?
> This is the first I've seen this patch :(
sorry for this.
>
> Can you resend it in a format I can apply it in?
Could you please resend V2 to Greg?
Thanks
Stefan
>
> thanks,
>
> greg k-h
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
2016-05-02 14:50 ` Stefan Wahren
@ 2016-05-02 14:58 ` Srinivas Kandagatla
-1 siblings, 0 replies; 10+ messages in thread
From: Srinivas Kandagatla @ 2016-05-02 14:58 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stefan,
On 02/05/16 15:50, Stefan Wahren wrote:
> Hi Stano,
>
> Am 02.05.2016 um 16:44 schrieb Greg Kroah-Hartman:
>> On Mon, May 02, 2016 at 03:55:53PM +0200, Stefan Wahren wrote:
>>> Hi Srinivas,
>>> hi Greg,
>>>
>>> Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
>>>> This patch fixes the issue where the mxs_ocotp_read is reading
>>>> the ocotp in reg_size steps but decrements the remaining size
>>>> by 1. The number of iterations is thus four times higher,
>>>> overwriting the area behind the output buffer.
>>>>
>>>> Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
>>>> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
>>>> Signed-off-by: Stanislav Meduna <stano@meduna.org>
>>> any change to get this critical fix into 4.6?
>> This is the first I've seen this patch :(
>
> sorry for this.
>
>>
>> Can you resend it in a format I can apply it in?
>
> Could you please resend V2 to Greg?
I will re-send this patch to Greg in next few mins..
thanks,
srini
>
> Thanks
> Stefan
>
>>
>> thanks,
>>
>> greg k-h
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read
@ 2016-05-02 14:58 ` Srinivas Kandagatla
0 siblings, 0 replies; 10+ messages in thread
From: Srinivas Kandagatla @ 2016-05-02 14:58 UTC (permalink / raw)
To: Stefan Wahren, Greg Kroah-Hartman, Stanislav Meduna
Cc: Maxime Ripard, linux-arm-kernel@lists.infradead.org, linux-kernel
Hi Stefan,
On 02/05/16 15:50, Stefan Wahren wrote:
> Hi Stano,
>
> Am 02.05.2016 um 16:44 schrieb Greg Kroah-Hartman:
>> On Mon, May 02, 2016 at 03:55:53PM +0200, Stefan Wahren wrote:
>>> Hi Srinivas,
>>> hi Greg,
>>>
>>> Am 27.04.2016 um 14:39 schrieb Stanislav Meduna:
>>>> This patch fixes the issue where the mxs_ocotp_read is reading
>>>> the ocotp in reg_size steps but decrements the remaining size
>>>> by 1. The number of iterations is thus four times higher,
>>>> overwriting the area behind the output buffer.
>>>>
>>>> Fixes: c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
>>>> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
>>>> Signed-off-by: Stanislav Meduna <stano@meduna.org>
>>> any change to get this critical fix into 4.6?
>> This is the first I've seen this patch :(
>
> sorry for this.
>
>>
>> Can you resend it in a format I can apply it in?
>
> Could you please resend V2 to Greg?
I will re-send this patch to Greg in next few mins..
thanks,
srini
>
> Thanks
> Stefan
>
>>
>> thanks,
>>
>> greg k-h
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-05-02 14:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-27 12:39 [PATCH v2] nvmem/mxs-ocotp: fix buffer overflow in read Stanislav Meduna
2016-04-27 12:39 ` Stanislav Meduna
2016-05-02 13:55 ` Stefan Wahren
2016-05-02 13:55 ` Stefan Wahren
2016-05-02 14:44 ` Greg Kroah-Hartman
2016-05-02 14:44 ` Greg Kroah-Hartman
2016-05-02 14:50 ` Stefan Wahren
2016-05-02 14:50 ` Stefan Wahren
2016-05-02 14:58 ` Srinivas Kandagatla
2016-05-02 14:58 ` Srinivas Kandagatla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.