[PATCH] NVMe: Fix check_flush_dependency warning

[PATCH] NVMe: Fix check_flush_dependency warning

[Keith Busch]

If the controller fails and is degraded after a reset, we need to kill
off all requests queues before removing the inaccessble namespaces. This
will prevent del_gendisk from syncing dirty data, which we can't due
from a WQ_MEM_RECLAIM work queue.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index dda19cc..6d49e47 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1909,6 +1909,7 @@ static void nvme_reset_work(struct work_struct *work)
 	 */
 	if (dev->online_queues < 2) {
 		dev_warn(dev->ctrl.device, "IO queues not created\n");
+		nvme_kill_queues(&dev->ctrl);
 		nvme_remove_namespaces(&dev->ctrl);
 	} else {
 		nvme_start_queues(&dev->ctrl);
-- 
2.7.2

[PATCH] NVMe: Fix check_flush_dependency warning

[Sagi Grimberg]

Looks good,

Reviewed-by: Sagi Grimberg <sagi at grimberg.me>

[PATCH] NVMe: Fix check_flush_dependency warning

[Christoph Hellwig]

On Wed, Apr 27, 2016@03:51:18PM -0600, Keith Busch wrote:
> If the controller fails and is degraded after a reset, we need to kill
> off all requests queues before removing the inaccessble namespaces. This
> will prevent del_gendisk from syncing dirty data, which we can't due
> from a WQ_MEM_RECLAIM work queue.
> 
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>

Jens, any chance to get this and my state machine series in ASAP?

I have another one depending on the state machine series which will
need some changes due to this one, and having both of them in
a tree somewhere would help greatly with getting it out before the
end of the 4.7 merge window.

[PATCH] NVMe: Fix check_flush_dependency warning

[Jens Axboe]

On 04/27/2016 03:51 PM, Keith Busch wrote:
> If the controller fails and is degraded after a reset, we need to kill
> off all requests queues before removing the inaccessble namespaces. This
> will prevent del_gendisk from syncing dirty data, which we can't due
> from a WQ_MEM_RECLAIM work queue.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Applied for 4.7.

-- 
Jens Axboe