* [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h
@ 2016-04-27 12:10 Wang Sheng-Hui
2016-04-28 11:19 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wang Sheng-Hui @ 2016-04-27 12:10 UTC (permalink / raw)
Section 3.1 gives the comment for the offset of controller registers
in the specification 1.2a.
Some are mis-copied in the header file nvme.h. Correct them.
Signed-off-by: Wang Sheng-Hui <shhuiw at foxmail.com>
---
include/linux/nvme.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index a55986f..7d51b29 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -21,13 +21,13 @@ enum {
NVME_REG_CAP = 0x0000, /* Controller Capabilities */
NVME_REG_VS = 0x0008, /* Version */
NVME_REG_INTMS = 0x000c, /* Interrupt Mask Set */
- NVME_REG_INTMC = 0x0010, /* Interrupt Mask Set */
+ NVME_REG_INTMC = 0x0010, /* Interrupt Mask Clear */
NVME_REG_CC = 0x0014, /* Controller Configuration */
NVME_REG_CSTS = 0x001c, /* Controller Status */
NVME_REG_NSSR = 0x0020, /* NVM Subsystem Reset */
NVME_REG_AQA = 0x0024, /* Admin Queue Attributes */
NVME_REG_ASQ = 0x0028, /* Admin SQ Base Address */
- NVME_REG_ACQ = 0x0030, /* Admin SQ Base Address */
+ NVME_REG_ACQ = 0x0030, /* Admin CQ Base Address */
NVME_REG_CMBLOC = 0x0038, /* Controller Memory Buffer Location */
NVME_REG_CMBSZ = 0x003c, /* Controller Memory Buffer Size */
};
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h
2016-04-27 12:10 [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h Wang Sheng-Hui
@ 2016-04-28 11:19 ` Sagi Grimberg
2016-05-01 18:09 ` Christoph Hellwig
2016-05-02 15:13 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2016-04-28 11:19 UTC (permalink / raw)
> Section 3.1 gives the comment for the offset of controller registers
> in the specification 1.2a.
>
> Some are mis-copied in the header file nvme.h. Correct them.
Yep,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h
2016-04-27 12:10 [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h Wang Sheng-Hui
2016-04-28 11:19 ` Sagi Grimberg
@ 2016-05-01 18:09 ` Christoph Hellwig
2016-05-02 15:13 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2016-05-01 18:09 UTC (permalink / raw)
Looks fine,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h
2016-04-27 12:10 [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h Wang Sheng-Hui
2016-04-28 11:19 ` Sagi Grimberg
2016-05-01 18:09 ` Christoph Hellwig
@ 2016-05-02 15:13 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2016-05-02 15:13 UTC (permalink / raw)
On 04/27/2016 06:10 AM, Wang Sheng-Hui wrote:
> Section 3.1 gives the comment for the offset of controller registers
> in the specification 1.2a.
>
> Some are mis-copied in the header file nvme.h. Correct them.
Added to 4.7.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-02 15:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-27 12:10 [PATCH] NVMe: correct comment for offset enum of controller registers in nvme.h Wang Sheng-Hui
2016-04-28 11:19 ` Sagi Grimberg
2016-05-01 18:09 ` Christoph Hellwig
2016-05-02 15:13 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.