From: Laxman Dewangan <ldewangan@nvidia.com>
To: Rhyland Klein <rklein@nvidia.com>,
linus.walleij@linaro.org, swarren@wwwdotorg.org,
thierry.reding@gmail.com
Cc: gnurou@gmail.com, linux-gpio@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] pinctrl: tegra: avoid parked_reg and parked_bank
Date: Mon, 2 May 2016 23:29:57 +0530 [thread overview]
Message-ID: <5727959D.2020005@nvidia.com> (raw)
In-Reply-To: <57276D4E.2020204@nvidia.com>
On Monday 02 May 2016 08:37 PM, Rhyland Klein wrote:
> On 5/2/2016 10:28 AM, Laxman Dewangan wrote:
>> NVIDIA's Tegra210 support the park bit to make pinmux configuration
>> enable/disable. If parked bit is 1 then configuration does not apply
>> and if it is 0 then pinmux configuration applies. This is to support
>> to avoid any glitch in pinmux configurations.
>>
>> The parked bit is part of mux register and mux bank and hence it is
>> not required to have member for the parked_reg and parked bank very
>> similar to other bit field of the same register.
>>
>> Remove the need of the parked register and parked bank and get whether
>> parked function supported or not by parked_bit.
>>
>> This is to make the parked bit handling same as other fields of mux
>> registers.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>> drivers/pinctrl/tegra/pinctrl-tegra.c | 8 ++++----
>> drivers/pinctrl/tegra/pinctrl-tegra.h | 6 +-----
>> drivers/pinctrl/tegra/pinctrl-tegra114.c | 4 ++--
>> drivers/pinctrl/tegra/pinctrl-tegra124.c | 4 ++--
>> drivers/pinctrl/tegra/pinctrl-tegra20.c | 4 ++--
>> drivers/pinctrl/tegra/pinctrl-tegra210.c | 4 +---
>> drivers/pinctrl/tegra/pinctrl-tegra30.c | 4 ++--
>> 7 files changed, 14 insertions(+), 20 deletions(-)
>>
> These drivers are generated (with the exception of Tegra20) by the
> tegra-pinmux-scripts hosted at :
> https://github.com/NVIDIA/tegra-pinmux-scripts.git. Did you generate a
> patch there so that the changes to pinctrl-tegra[114|124|210|30].c are
> consistent there? If not you probably should.
No, this is manual editing. Let me create patch on script to generate
pinctrl-tegra[114|124|210|30].c as what this patch created manually.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Rhyland Klein <rklein@nvidia.com>, <linus.walleij@linaro.org>,
<swarren@wwwdotorg.org>, <thierry.reding@gmail.com>
Cc: <gnurou@gmail.com>, <linux-gpio@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] pinctrl: tegra: avoid parked_reg and parked_bank
Date: Mon, 2 May 2016 23:29:57 +0530 [thread overview]
Message-ID: <5727959D.2020005@nvidia.com> (raw)
In-Reply-To: <57276D4E.2020204@nvidia.com>
On Monday 02 May 2016 08:37 PM, Rhyland Klein wrote:
> On 5/2/2016 10:28 AM, Laxman Dewangan wrote:
>> NVIDIA's Tegra210 support the park bit to make pinmux configuration
>> enable/disable. If parked bit is 1 then configuration does not apply
>> and if it is 0 then pinmux configuration applies. This is to support
>> to avoid any glitch in pinmux configurations.
>>
>> The parked bit is part of mux register and mux bank and hence it is
>> not required to have member for the parked_reg and parked bank very
>> similar to other bit field of the same register.
>>
>> Remove the need of the parked register and parked bank and get whether
>> parked function supported or not by parked_bit.
>>
>> This is to make the parked bit handling same as other fields of mux
>> registers.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>> drivers/pinctrl/tegra/pinctrl-tegra.c | 8 ++++----
>> drivers/pinctrl/tegra/pinctrl-tegra.h | 6 +-----
>> drivers/pinctrl/tegra/pinctrl-tegra114.c | 4 ++--
>> drivers/pinctrl/tegra/pinctrl-tegra124.c | 4 ++--
>> drivers/pinctrl/tegra/pinctrl-tegra20.c | 4 ++--
>> drivers/pinctrl/tegra/pinctrl-tegra210.c | 4 +---
>> drivers/pinctrl/tegra/pinctrl-tegra30.c | 4 ++--
>> 7 files changed, 14 insertions(+), 20 deletions(-)
>>
> These drivers are generated (with the exception of Tegra20) by the
> tegra-pinmux-scripts hosted at :
> https://github.com/NVIDIA/tegra-pinmux-scripts.git. Did you generate a
> patch there so that the changes to pinctrl-tegra[114|124|210|30].c are
> consistent there? If not you probably should.
No, this is manual editing. Let me create patch on script to generate
pinctrl-tegra[114|124|210|30].c as what this patch created manually.
next prev parent reply other threads:[~2016-05-02 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 14:28 [PATCH 1/1] pinctrl: tegra: avoid parked_reg and parked_bank Laxman Dewangan
2016-05-02 14:28 ` Laxman Dewangan
[not found] ` <1462199330-1536-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-02 14:28 ` [PATCH] pinctrl: tegra: Correctly check the supported configuration Laxman Dewangan
2016-05-02 14:28 ` Laxman Dewangan
[not found] ` <1462199330-1536-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-02 16:46 ` Stephen Warren
2016-05-02 16:46 ` Stephen Warren
2016-05-02 15:07 ` [PATCH 1/1] pinctrl: tegra: avoid parked_reg and parked_bank Rhyland Klein
2016-05-02 15:07 ` Rhyland Klein
2016-05-02 17:59 ` Laxman Dewangan [this message]
2016-05-02 17:59 ` Laxman Dewangan
2016-05-11 11:25 ` Linus Walleij
2016-05-11 11:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5727959D.2020005@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.