From: Thomas Huth <thuth@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH kernel] KVM: PPC: Fix debug macros
Date: Mon, 02 May 2016 18:14:50 +0000 [thread overview]
Message-ID: <5727991A.6000309@redhat.com> (raw)
In-Reply-To: <1461905843-22673-1-git-send-email-aik@ozlabs.ru>
On 29.04.2016 06:57, Alexey Kardashevskiy wrote:
> When XICS_DBG is enabled, gcc produces format errors. This fixes
> formats to match passed values types.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> arch/powerpc/kvm/book3s_xics.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c
> index 46871d5..95896d7 100644
> --- a/arch/powerpc/kvm/book3s_xics.c
> +++ b/arch/powerpc/kvm/book3s_xics.c
> @@ -280,7 +280,7 @@ static inline bool icp_try_update(struct kvmppc_icp *icp,
> if (!success)
> goto bail;
>
> - XICS_DBG("UPD [%04x] - C:%02x M:%02x PP: %02x PI:%06x R:%d O:%d\n",
> + XICS_DBG("UPD [%04lx] - C:%02x M:%02x PP: %02x PI:%06x R:%d O:%d\n",
> icp->server_num,
> old.cppr, old.mfrr, old.pending_pri, old.xisr,
> old.need_resend, old.out_ee);
> @@ -336,7 +336,7 @@ static bool icp_try_to_deliver(struct kvmppc_icp *icp, u32 irq, u8 priority,
> union kvmppc_icp_state old_state, new_state;
> bool success;
>
> - XICS_DBG("try deliver %#x(P:%#x) to server %#x\n", irq, priority,
> + XICS_DBG("try deliver %#x(P:%#x) to server %#lx\n", irq, priority,
> icp->server_num);
>
> do {
Reviewed-by: Thomas Huth <thuth@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH kernel] KVM: PPC: Fix debug macros
Date: Mon, 2 May 2016 20:14:50 +0200 [thread overview]
Message-ID: <5727991A.6000309@redhat.com> (raw)
In-Reply-To: <1461905843-22673-1-git-send-email-aik@ozlabs.ru>
On 29.04.2016 06:57, Alexey Kardashevskiy wrote:
> When XICS_DBG is enabled, gcc produces format errors. This fixes
> formats to match passed values types.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> arch/powerpc/kvm/book3s_xics.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c
> index 46871d5..95896d7 100644
> --- a/arch/powerpc/kvm/book3s_xics.c
> +++ b/arch/powerpc/kvm/book3s_xics.c
> @@ -280,7 +280,7 @@ static inline bool icp_try_update(struct kvmppc_icp *icp,
> if (!success)
> goto bail;
>
> - XICS_DBG("UPD [%04x] - C:%02x M:%02x PP: %02x PI:%06x R:%d O:%d\n",
> + XICS_DBG("UPD [%04lx] - C:%02x M:%02x PP: %02x PI:%06x R:%d O:%d\n",
> icp->server_num,
> old.cppr, old.mfrr, old.pending_pri, old.xisr,
> old.need_resend, old.out_ee);
> @@ -336,7 +336,7 @@ static bool icp_try_to_deliver(struct kvmppc_icp *icp, u32 irq, u8 priority,
> union kvmppc_icp_state old_state, new_state;
> bool success;
>
> - XICS_DBG("try deliver %#x(P:%#x) to server %#x\n", irq, priority,
> + XICS_DBG("try deliver %#x(P:%#x) to server %#lx\n", irq, priority,
> icp->server_num);
>
> do {
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-05-02 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 4:57 [PATCH kernel] KVM: PPC: Fix debug macros Alexey Kardashevskiy
2016-04-29 4:57 ` Alexey Kardashevskiy
2016-04-29 4:57 ` Alexey Kardashevskiy
2016-05-02 18:14 ` Thomas Huth [this message]
2016-05-02 18:14 ` Thomas Huth
2016-05-11 11:36 ` Paul Mackerras
2016-05-11 11:36 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5727991A.6000309@redhat.com \
--to=thuth@redhat.com \
--cc=aik@ozlabs.ru \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.