From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF
Date: Tue, 3 May 2016 16:28:35 +0530 [thread overview]
Message-ID: <5728845B.8070405@ti.com> (raw)
In-Reply-To: <1879262.vnFSl1oxpJ@diego>
On Sunday 01 May 2016 01:37 AM, Heiko Stübner wrote:
> Hi Kishon,
>
> Am Dienstag, 19. April 2016, 08:13:47 schrieb Heiko Stübner:
>> Hi Kishon.
>>
>> Am Donnerstag, 31. März 2016, 15:43:30 schrieb Heiko Stuebner:
>>> The usb-phy is fully enclosed in the general register files (GRF).
>>> Therefore as seen from the device-tree it shouldn't be a separate
>>> platform-
>>> device but instead a sub-device of the GRF - using the simply-mfd
>>> mechanism.
>>>
>>> As the usb-phy is part of the kernel for some releases now, we keep
>>> the old (and now deprecated) binding for compatibility purposes.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
>>
>> could you look into picking this patch up for 4.7?
>>
>> Same principle as for the other phy drivers, but it's already in the kernel
>> for a while, so it gets a fallback for the old binding and can go through
>> the normal way.
>>
>> The other two (devicetree-)patches I would then simply queue for 4.8 myself
>> after you're fine with the driver-side.
>
> just saw that you already have a tag for 4.7-related phy changes since this
> afternoon, but no phy pull to Greg on lkml yet.
>
> So maybe there is still a way for this phy conversion (to be under the
> Rockchip GRF node) to make it in for 4.7 :-) ?
Looks like I've missed this before sending the pull request. Sorry about that.
Is it okay if the PHY changes also go in 4.8?
-Kishon
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: <linux-kernel@vger.kernel.org>, <linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF
Date: Tue, 3 May 2016 16:28:35 +0530 [thread overview]
Message-ID: <5728845B.8070405@ti.com> (raw)
In-Reply-To: <1879262.vnFSl1oxpJ@diego>
On Sunday 01 May 2016 01:37 AM, Heiko Stübner wrote:
> Hi Kishon,
>
> Am Dienstag, 19. April 2016, 08:13:47 schrieb Heiko Stübner:
>> Hi Kishon.
>>
>> Am Donnerstag, 31. März 2016, 15:43:30 schrieb Heiko Stuebner:
>>> The usb-phy is fully enclosed in the general register files (GRF).
>>> Therefore as seen from the device-tree it shouldn't be a separate
>>> platform-
>>> device but instead a sub-device of the GRF - using the simply-mfd
>>> mechanism.
>>>
>>> As the usb-phy is part of the kernel for some releases now, we keep
>>> the old (and now deprecated) binding for compatibility purposes.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>>
>> could you look into picking this patch up for 4.7?
>>
>> Same principle as for the other phy drivers, but it's already in the kernel
>> for a while, so it gets a fallback for the old binding and can go through
>> the normal way.
>>
>> The other two (devicetree-)patches I would then simply queue for 4.8 myself
>> after you're fine with the driver-side.
>
> just saw that you already have a tag for 4.7-related phy changes since this
> afternoon, but no phy pull to Greg on lkml yet.
>
> So maybe there is still a way for this phy conversion (to be under the
> Rockchip GRF node) to make it in for 4.7 :-) ?
Looks like I've missed this before sending the pull request. Sorry about that.
Is it okay if the PHY changes also go in 4.8?
-Kishon
next prev parent reply other threads:[~2016-05-03 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:43 [PATCH 0/3] move Rockchip usbphy under the GRF mfd Heiko Stuebner
2016-03-31 13:43 ` [PATCH 1/3] phy: rockchip-usb: should be a child device of the GRF Heiko Stuebner
2016-04-19 6:13 ` Heiko Stübner
2016-04-30 20:07 ` Heiko Stübner
2016-05-03 10:58 ` Kishon Vijay Abraham I [this message]
2016-05-03 10:58 ` Kishon Vijay Abraham I
2016-05-03 11:02 ` Heiko Stübner
2016-06-17 12:35 ` Kishon Vijay Abraham I
2016-06-17 12:35 ` Kishon Vijay Abraham I
2016-03-31 13:43 ` [PATCH 2/3] ARM: dts: rockchip: make rk3288-grf a simple-mfd Heiko Stuebner
2016-03-31 13:43 ` [PATCH 3/3] ARM: dts: rockchip: move rk3288 usbphy under the GRF node Heiko Stuebner
[not found] ` <1459431812-6286-4-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2016-08-03 9:40 ` Heiko Stübner
2016-08-03 9:40 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728845B.8070405@ti.com \
--to=kishon-l0cymroini0@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.