From: Dave Hansen <dave.hansen@linux.intel.com>
To: Baoquan He <bhe@redhat.com>
Cc: Thomas Garnier <thgarnie@google.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
Andy Lutomirski <luto@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Kees Cook <keescook@chromium.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
Matt Fleming <matt@codeblueprint.co.uk>,
Toshi Kani <toshi.kani@hpe.com>,
Alexander Kuleshov <kuleshovmail@gmail.com>,
Alexander Popov <alpopov@ptsecurity.com>,
Joerg Roedel <jroedel@suse.de>, Dave Young <dyoung@redhat.com>,
Mark Salter <msalter@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, gthelen@google.com,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH v2 2/4] x86, boot: PUD VA support for physical mapping (x86_64)
Date: Tue, 3 May 2016 08:08:51 -0700 [thread overview]
Message-ID: <5728BF03.1050303@linux.intel.com> (raw)
In-Reply-To: <20160503100530.GC3287@x1.redhat.com>
On 05/03/2016 03:05 AM, Baoquan He wrote:
> I have a tiny concern about phys_pmd_init(), both phys_pud_init and
> phys_pte_init name 2nd parameter as 'addr', phys_pmd_init use 'address'.
> If this can be changed to make them look consistent completist would
> have a good sleep from now on.
Yes, consistency would be nice. Even better would be to call them all
'phys_addr'.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Baoquan He <bhe@redhat.com>
Cc: Thomas Garnier <thgarnie@google.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
Andy Lutomirski <luto@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Kees Cook <keescook@chromium.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
Matt Fleming <matt@codeblueprint.co.uk>,
Toshi Kani <toshi.kani@hpe.com>,
Alexander Kuleshov <kuleshovmail@gmail.com>,
Alexander Popov <alpopov@ptsecurity.com>,
Joerg Roedel <jroedel@suse.de>, Dave Young <dyoung@redhat.com>,
Mark Salter <msalter@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, gthelen@google.com,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2 2/4] x86, boot: PUD VA support for physical mapping (x86_64)
Date: Tue, 3 May 2016 08:08:51 -0700 [thread overview]
Message-ID: <5728BF03.1050303@linux.intel.com> (raw)
In-Reply-To: <20160503100530.GC3287@x1.redhat.com>
On 05/03/2016 03:05 AM, Baoquan He wrote:
> I have a tiny concern about phys_pmd_init(), both phys_pud_init and
> phys_pte_init name 2nd parameter as 'addr', phys_pmd_init use 'address'.
> If this can be changed to make them look consistent completist would
> have a good sleep from now on.
Yes, consistency would be nice. Even better would be to call them all
'phys_addr'.
next prev parent reply other threads:[~2016-05-03 15:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 21:41 [kernel-hardening] [PATCH v2 0/4] x86, boot: KASLR memory implementation Thomas Garnier
2016-05-02 21:41 ` Thomas Garnier
2016-05-02 21:41 ` [kernel-hardening] [PATCH v2 1/4] x86, boot: Refactor KASLR entropy functions Thomas Garnier
2016-05-02 21:41 ` Thomas Garnier
2016-05-02 21:41 ` [kernel-hardening] [PATCH v2 2/4] x86, boot: PUD VA support for physical mapping (x86_64) Thomas Garnier
2016-05-02 21:41 ` Thomas Garnier
2016-05-02 21:58 ` [kernel-hardening] " Dave Hansen
2016-05-02 21:58 ` Dave Hansen
2016-05-03 10:05 ` [kernel-hardening] " Baoquan He
2016-05-03 10:05 ` Baoquan He
2016-05-03 15:08 ` Dave Hansen [this message]
2016-05-03 15:08 ` Dave Hansen
2016-05-03 15:46 ` [kernel-hardening] " Thomas Garnier
2016-05-03 15:46 ` Thomas Garnier
2016-05-02 21:41 ` [kernel-hardening] [PATCH v2 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64) Thomas Garnier
2016-05-02 21:41 ` Thomas Garnier
2016-05-02 22:00 ` [kernel-hardening] " Dave Hansen
2016-05-02 22:00 ` Dave Hansen
2016-05-03 19:16 ` [kernel-hardening] " Thomas Garnier
2016-05-03 19:16 ` Thomas Garnier
2016-05-02 21:41 ` [kernel-hardening] [PATCH v2 4/4] x86, boot: Memory hotplug support for KASLR memory randomization Thomas Garnier
2016-05-02 21:41 ` Thomas Garnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728BF03.1050303@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=alpopov@ptsecurity.com \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dvyukov@google.com \
--cc=dyoung@redhat.com \
--cc=gthelen@google.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=msalter@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=toshi.kani@hpe.com \
--cc=wangkefeng.wang@huawei.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.