From: Sergey Fedorov <serge.fdrv@gmail.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
mttcg@listserver.greensocs.com, fred.konrad@greensocs.com,
a.rigo@virtualopensystems.com, cota@braap.org
Cc: qemu-devel@nongnu.org, mark.burton@greensocs.com,
pbonzini@redhat.com, jan.kiszka@siemens.com, rth@twiddle.net,
peter.maydell@linaro.org, claudio.fontana@huawei.com,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held
Date: Thu, 5 May 2016 17:19:48 +0300 [thread overview]
Message-ID: <572B5684.1030001@gmail.com> (raw)
In-Reply-To: <1459870344-16773-5-git-send-email-alex.bennee@linaro.org>
On 05/04/16 18:32, Alex Bennée wrote:
> diff --git a/exec.c b/exec.c
> index f46e596..17f390e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -826,6 +826,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags,
> {
> CPUBreakpoint *bp;
>
> + /* TODO: locking (RCU?) */
> bp = g_malloc(sizeof(*bp));
>
> bp->pc = pc;
This comment is a little inconsistent. We should make access to
breakpoint and watchpoint lists to be thread-safe in all the functions
using them. So if we note this, it should be noted in all such places.
Also, it's probably not a good idea to put such comment just above
g_malloc() invocation, it could be a bit confusing. A bit more details
would also be nice.
Kind regards,
Sergey
next prev parent reply other threads:[~2016-05-05 14:20 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 15:32 [Qemu-devel] [RFC v2 00/11] Base enabling patches for MTTCG Alex Bennée
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 01/11] tcg: move tb_invalidated_flag to CPUState Alex Bennée
2016-04-05 15:44 ` Paolo Bonzini
2016-04-06 10:11 ` Sergey Fedorov
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 02/11] cpus: make all_vcpus_paused() return bool Alex Bennée
2016-04-11 12:48 ` Sergey Fedorov
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 03/11] docs: new design document multi-thread-tcg.txt (DRAFTING) Alex Bennée
2016-04-11 20:00 ` Sergey Fedorov
2016-05-25 15:48 ` Sergey Fedorov
2016-05-25 16:01 ` Alex Bennée
2016-05-25 18:03 ` Paolo Bonzini
2016-05-25 18:13 ` Sergey Fedorov
2016-05-06 11:25 ` Sergey Fedorov
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held Alex Bennée
2016-05-05 14:19 ` Sergey Fedorov [this message]
2016-05-05 15:03 ` Alex Bennée
2016-05-05 15:25 ` Sergey Fedorov
2016-05-05 15:42 ` Sergey Fedorov
2016-05-06 18:22 ` Sergey Fedorov
2016-05-11 12:58 ` Paolo Bonzini
2016-05-11 13:36 ` Sergey Fedorov
2016-05-11 13:46 ` Paolo Bonzini
2016-05-12 19:32 ` Sergey Fedorov
2016-05-13 9:25 ` Paolo Bonzini
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 05/11] tcg: protect TBContext with tb_lock Alex Bennée
2016-05-11 12:45 ` Sergey Fedorov
2016-05-11 12:52 ` Paolo Bonzini
2016-05-11 13:42 ` Sergey Fedorov
2016-06-01 10:30 ` Alex Bennée
2016-06-02 14:37 ` Sergey Fedorov
2016-04-05 15:32 ` [RFC v2 06/11] target-arm/psci.c: wake up sleeping CPUs Alex Bennée
2016-04-05 15:32 ` [Qemu-devel] " Alex Bennée
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 07/11] tcg: cpus rm tcg_exec_all() Alex Bennée
2016-05-26 11:03 ` Sergey Fedorov
2016-05-26 13:10 ` Alex Bennée
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG Alex Bennée
2016-04-11 20:50 ` Sergey Fedorov
2016-04-12 11:48 ` Alex Bennée
2016-04-12 11:59 ` Peter Maydell
2016-04-12 12:42 ` Sergey Fedorov
2016-04-12 12:50 ` KONRAD Frederic
2016-04-12 13:00 ` Sergey Fedorov
2016-04-12 13:03 ` Pavel Dovgalyuk
2016-04-12 13:19 ` Sergey Fedorov
2016-04-12 14:23 ` Alex Bennée
2016-05-09 10:47 ` Paolo Bonzini
2016-04-12 12:48 ` Sergey Fedorov
2016-05-09 10:45 ` Paolo Bonzini
2016-05-09 11:50 ` Alex Bennée
2016-04-12 13:23 ` Sergey Fedorov
2016-04-12 14:28 ` Alex Bennée
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 09/11] tcg: add kick timer for single-threaded vCPU emulation Alex Bennée
2016-04-11 21:39 ` Sergey Fedorov
2016-06-02 16:00 ` Alex Bennée
2016-06-02 16:05 ` Sergey Fedorov
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 10/11] tcg: drop global lock during TCG code execution Alex Bennée
2016-05-24 21:28 ` Sergey Fedorov
2016-05-25 10:33 ` Paolo Bonzini
2016-05-25 11:07 ` Alex Bennée
2016-05-25 12:46 ` Paolo Bonzini
2016-04-05 15:32 ` [Qemu-devel] [RFC v2 11/11] tcg: enable thread-per-vCPU Alex Bennée
2016-05-27 13:57 ` Sergey Fedorov
2016-05-27 14:55 ` Paolo Bonzini
2016-05-27 15:07 ` Sergey Fedorov
2016-05-27 15:25 ` Paolo Bonzini
2016-05-27 18:54 ` Sergey Fedorov
2016-06-02 16:36 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572B5684.1030001@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=a.rigo@virtualopensystems.com \
--cc=afaerber@suse.de \
--cc=alex.bennee@linaro.org \
--cc=claudio.fontana@huawei.com \
--cc=cota@braap.org \
--cc=crosthwaite.peter@gmail.com \
--cc=fred.konrad@greensocs.com \
--cc=jan.kiszka@siemens.com \
--cc=mark.burton@greensocs.com \
--cc=mttcg@listserver.greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.