From: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: grant.likely@linaro.org, frowand.list@gmail.com,
robh+dt@kernel.org, paulus@samba.org
Subject: Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking
Date: Fri, 6 May 2016 11:01:26 +1000 [thread overview]
Message-ID: <572BECE6.1080303@gmail.com> (raw)
In-Reply-To: <1462431031.12473.3.camel@ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
On 05/05/16 16:50, Michael Ellerman wrote:
> On Tue, 2016-05-03 at 15:32 -0700, Tyrel Datwyler wrote: >> On 04/27/2016 10:34 PM, Suraj Jitindar Singh wrote: >>> diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c >>> index ceb18d3..a560a98 100644 >>> --- a/arch/powerpc/platforms/pseries/mobility.c >>> +++ b/arch/powerpc/platforms/pseries/mobility.c >>> @@ -191,8 +191,8 @@ static int update_dt_node(__be32 phandle, s32 scope) >>> break; >>> >>> case 0x80000000: >>> - prop = of_find_property(dn, prop_name, NULL); >>> - of_remove_property(dn, prop); >>> + of_remove_property(dn, of_find_property(dn, >>> + prop_name, NULL)); >>> prop = NULL; >>> break; >>> >> >> You haven't removed a NULL check here, as suggested by the changelog, >> but instead made a cosmetic change to the code that still leaves behind >> a now unnecessary "prop = NULL;" to bit rot. > > Yeah I think you're right. Though it's not
very clear how prop is used in that > function. > > Please one of you send me an incremental to remove the prop = NULL; > > cheers >
I didn't delete the prop = NULL; initially as I didn't fully understand
how it was used in the rest of the function and the effect of deleting
it.
[-- Attachment #2: Type: text/html, Size: 1950 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: grant.likely@linaro.org, paulus@samba.org, robh+dt@kernel.org,
frowand.list@gmail.com
Subject: Re: [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking
Date: Fri, 6 May 2016 11:01:26 +1000 [thread overview]
Message-ID: <572BECE6.1080303@gmail.com> (raw)
In-Reply-To: <1462431031.12473.3.camel@ellerman.id.au>
[-- Attachment #1.1: Type: text/plain, Size: 1383 bytes --]
On 05/05/16 16:50, Michael Ellerman wrote:
> On Tue, 2016-05-03 at 15:32 -0700, Tyrel Datwyler wrote: >> On 04/27/2016 10:34 PM, Suraj Jitindar Singh wrote: >>> diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c >>> index ceb18d3..a560a98 100644 >>> --- a/arch/powerpc/platforms/pseries/mobility.c >>> +++ b/arch/powerpc/platforms/pseries/mobility.c >>> @@ -191,8 +191,8 @@ static int update_dt_node(__be32 phandle, s32 scope) >>> break; >>> >>> case 0x80000000: >>> - prop = of_find_property(dn, prop_name, NULL); >>> - of_remove_property(dn, prop); >>> + of_remove_property(dn, of_find_property(dn, >>> + prop_name, NULL)); >>> prop = NULL; >>> break; >>> >> >> You haven't removed a NULL check here, as suggested by the changelog, >> but instead made a cosmetic change to the code that still leaves behind >> a now unnecessary "prop = NULL;" to bit rot. > > Yeah I think you're right. Though it's not
very clear how prop is used in that > function. > > Please one of you send me an incremental to remove the prop = NULL; > > cheers >
I didn't delete the prop = NULL; initially as I didn't fully understand
how it was used in the rest of the function and the effect of deleting
it.
[-- Attachment #1.2: Type: text/html, Size: 1996 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2016-05-06 1:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 5:34 [PATCH 1/2] drivers/of: Add check for null property in of_remove_property() Suraj Jitindar Singh
2016-04-28 5:34 ` Suraj Jitindar Singh
2016-04-28 5:34 ` [PATCH 2/2] powerpc: Update of_remove_property() call sites to remove null checking Suraj Jitindar Singh
2016-04-28 5:34 ` Suraj Jitindar Singh
2016-05-03 22:32 ` Tyrel Datwyler
2016-05-03 22:32 ` Tyrel Datwyler
2016-05-05 6:50 ` Michael Ellerman
2016-05-05 6:50 ` Michael Ellerman
2016-05-06 1:01 ` Suraj Jitindar Singh [this message]
2016-05-06 1:01 ` Suraj Jitindar Singh
2016-05-06 3:00 ` Suraj Jitindar Singh
2016-05-06 3:00 ` Suraj Jitindar Singh
2016-05-09 9:41 ` Michael Ellerman
2016-05-09 9:41 ` Michael Ellerman
2016-05-04 22:40 ` [2/2] " Michael Ellerman
2016-05-04 22:40 ` Michael Ellerman
2016-05-03 13:06 ` [PATCH 1/2] drivers/of: Add check for null property in of_remove_property() Rob Herring
2016-05-03 13:06 ` Rob Herring
2016-05-04 22:40 ` [1/2] " Michael Ellerman
2016-05-04 22:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572BECE6.1080303@gmail.com \
--to=sjitindarsingh@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.