From: Suzuki.Poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] coresight: Handle build path error
Date: Fri, 6 May 2016 15:32:48 +0100 [thread overview]
Message-ID: <572CAB10.7060103@arm.com> (raw)
In-Reply-To: <CANLsYkwEG-4U+hvdVNHQxoH_WuZvD_pYwDC6NSBOok9o5swNoA@mail.gmail.com>
On 06/05/16 15:26, Mathieu Poirier wrote:
> On 4 May 2016 at 04:41, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>> Enabling a component via sysfs (echo 1 > enable_source), would
>> trigger building a path from the enabled sources to the sink.
>> If there is an error in the process (e.g, sink not enabled or
>> the device (CPU corresponding to ETM) is not online), we never report
>> failure, except for leaving a message in the dmesg.
>>
>> Do proper error checking for the build path and return the error.
>>
>> Before:
>> $ echo 0 > /sys/devices/system/cpu/cpu2/online
>> $ echo 1 > /sys/devices/cs_etm/cpu2/enable_source
>> $ echo $?
>> 0
>>
>> After:
>> $ echo 0 > /sys/devices/system/cpu/cpu2/online
>> $ echo 1 > /sys/devices/cs_etm/cpu2/enable_source
>> -bash: echo: write error: No such device or address
>>
>> Cc: Mathie Porier <mathieu.poirier@linaro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> This patch looks good - thanks for the fix. Due to how late we are in
> the cycle I'd ask Greg to pick it up right away but there is a
> (couple) of typos in my name on the CC line. Either resend another
> patch with the correct spelling or remove the CC line altogether.
Sorry about that. will resend it fixed.
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] coresight: Handle build path error
Date: Fri, 6 May 2016 15:32:48 +0100 [thread overview]
Message-ID: <572CAB10.7060103@arm.com> (raw)
In-Reply-To: <CANLsYkwEG-4U+hvdVNHQxoH_WuZvD_pYwDC6NSBOok9o5swNoA@mail.gmail.com>
On 06/05/16 15:26, Mathieu Poirier wrote:
> On 4 May 2016 at 04:41, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>> Enabling a component via sysfs (echo 1 > enable_source), would
>> trigger building a path from the enabled sources to the sink.
>> If there is an error in the process (e.g, sink not enabled or
>> the device (CPU corresponding to ETM) is not online), we never report
>> failure, except for leaving a message in the dmesg.
>>
>> Do proper error checking for the build path and return the error.
>>
>> Before:
>> $ echo 0 > /sys/devices/system/cpu/cpu2/online
>> $ echo 1 > /sys/devices/cs_etm/cpu2/enable_source
>> $ echo $?
>> 0
>>
>> After:
>> $ echo 0 > /sys/devices/system/cpu/cpu2/online
>> $ echo 1 > /sys/devices/cs_etm/cpu2/enable_source
>> -bash: echo: write error: No such device or address
>>
>> Cc: Mathie Porier <mathieu.poirier@linaro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> This patch looks good - thanks for the fix. Due to how late we are in
> the cycle I'd ask Greg to pick it up right away but there is a
> (couple) of typos in my name on the CC line. Either resend another
> patch with the correct spelling or remove the CC line altogether.
Sorry about that. will resend it fixed.
next prev parent reply other threads:[~2016-05-06 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 10:41 [PATCH] coresight: Handle build path error Suzuki K Poulose
2016-05-04 10:41 ` Suzuki K Poulose
2016-05-06 14:26 ` Mathieu Poirier
2016-05-06 14:26 ` Mathieu Poirier
2016-05-06 14:32 ` Suzuki K Poulose [this message]
2016-05-06 14:32 ` Suzuki K Poulose
2016-05-06 14:35 ` Suzuki K Poulose
2016-05-06 14:35 ` Suzuki K Poulose
2016-05-06 14:43 ` Mathieu Poirier
2016-05-06 14:43 ` Mathieu Poirier
2016-06-01 18:04 ` Suzuki K Poulose
2016-06-01 18:04 ` Suzuki K Poulose
2016-06-02 14:19 ` Mathieu Poirier
2016-06-02 14:19 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572CAB10.7060103@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.