From: "René Nyffenegger" <mail-gLCNRsNSrVdVZEhyV+6z5nIPMjoJpjVV@public.gmane.org>
To: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
"Steven Rostedt (Red Hat)"
<rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
Zach Brown <zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Milosz Tanski <milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] Use pid_t instead of int
Date: Mon, 9 May 2016 06:15:46 +0200 [thread overview]
Message-ID: <57300EF2.7030303@renenyffenegger.ch> (raw)
In-Reply-To: <CALCETrVyT6R6mYnVuv9vqmeCC7_TB2KZPCqfcmMyLvjbZPs+Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Somewhere else, pid_t is a typedef for an int.
Rene
On 09.05.2016 03:25, Andy Lutomirski wrote:
> On Sun, May 8, 2016 at 12:38 PM, René Nyffenegger
> <mail-gLCNRsNSrVdVZEhyV+6z5nIPMjoJpjVV@public.gmane.org> wrote:
>> Use pid_t instead of int in the declarations of sys_kill, sys_tgkill,
>> sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h
>
> The description is no good. *Why* are you changing it?
>
> I checked tgkill and, indeed, tgkill takes pid_t parameters, so this
> fixes an incorrect declaration. I'm wondering why the code compiles
> without warning. Is SYSCALL_DEFINE too lenient for some reason? Or
> is pid_t just defined as int.
>
> --Andy
>
WARNING: multiple messages have this Message-ID (diff)
From: "René Nyffenegger" <mail@renenyffenegger.ch>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Josh Triplett <josh@joshtriplett.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Zach Brown <zab@redhat.com>, Milosz Tanski <milosz@adfin.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux API <linux-api@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use pid_t instead of int
Date: Mon, 9 May 2016 06:15:46 +0200 [thread overview]
Message-ID: <57300EF2.7030303@renenyffenegger.ch> (raw)
In-Reply-To: <CALCETrVyT6R6mYnVuv9vqmeCC7_TB2KZPCqfcmMyLvjbZPs+Ag@mail.gmail.com>
Somewhere else, pid_t is a typedef for an int.
Rene
On 09.05.2016 03:25, Andy Lutomirski wrote:
> On Sun, May 8, 2016 at 12:38 PM, René Nyffenegger
> <mail@renenyffenegger.ch> wrote:
>> Use pid_t instead of int in the declarations of sys_kill, sys_tgkill,
>> sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h
>
> The description is no good. *Why* are you changing it?
>
> I checked tgkill and, indeed, tgkill takes pid_t parameters, so this
> fixes an incorrect declaration. I'm wondering why the code compiles
> without warning. Is SYSCALL_DEFINE too lenient for some reason? Or
> is pid_t just defined as int.
>
> --Andy
>
next prev parent reply other threads:[~2016-05-09 4:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 19:38 [PATCH] Use pid_t instead of int René Nyffenegger
2016-05-09 1:25 ` Andy Lutomirski
[not found] ` <CALCETrVyT6R6mYnVuv9vqmeCC7_TB2KZPCqfcmMyLvjbZPs+Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-09 4:15 ` René Nyffenegger [this message]
2016-05-09 4:15 ` René Nyffenegger
2016-05-09 6:36 ` René Nyffenegger
2016-05-09 6:36 ` René Nyffenegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57300EF2.7030303@renenyffenegger.ch \
--to=mail-glcnrsnsrvdvzehyv+6z5nipmjojpjvv@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
--cc=zab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.