Re: [PATCH] Install to LVM PVs

[Andrei Borzenkov <arvidjaar@gmail.com>]

08.05.2016 16:01, Dryden Personalis пишет:
> 
>>> -    if (fs_probe)
>>> +    if (!is_lvm && fs_probe)
>>
>> No, we want to probe for FS here to eliminate corner case of both PV and
>> FS metadata.
> 
> You mean you want to change it to:
> 

No, I do not want to change it at all. It should remain as is and always
probe for FS so that test below actually works
...
>> And you need to add check for LVM here
>>
>>     if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || (is_ldm
>> && fs))
> 
> I take it you mean:
> 
> if (!is_lvm && (ctx.multiple_partmaps || (ctx.dest_partmap && fs) ||
> (is_ldm && fs)))
>

I mean

if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || ((is_ldm ||
is_lvm) && fs))