From: Dryden Personalis <list@xenhideout.nl>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Install to LVM PVs
Date: Mon, 09 May 2016 10:41:46 +0200 [thread overview]
Message-ID: <fe4753c68025fcb38fa99ae7ddf1e7ec@dds.nl> (raw)
In-Reply-To: <57302925.2000000@gmail.com>
Andrei Borzenkov schreef op 09-05-2016 8:07:
> No, I do not want to change it at all. It should remain as is and
> always
> probe for FS so that test below actually works
But its output makes no sense, there cannot be a filesystem in a PV. It
could check for existence of VG AND LV AND filesystem but does it do
that right now?
Installing Grub is generally a non-destructive operation, apart from
overwriting the boot sector.
Anyway my foot is hurting and I can't sit behind the computer, I will
just show the code at some point so to discuss that alright.
>> I take it you mean:
>>
>> if (!is_lvm && (ctx.multiple_partmaps || (ctx.dest_partmap && fs) ||
>> (is_ldm && fs)))
>>
>
> I mean
>
> if (ctx.multiple_partmaps || (ctx.dest_partmap && fs) || ((is_ldm ||
> is_lvm) && fs))
Yes, I realized. Sorry.
next prev parent reply other threads:[~2016-05-09 8:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 4:53 [PATCH] Install to LVM PVs Dryden Personalis
2016-05-08 6:05 ` Andrei Borzenkov
2016-05-08 8:47 ` Andrei Borzenkov
2016-05-08 13:10 ` Dryden Personalis
2016-05-08 17:16 ` Dryden Personalis
2016-05-08 17:40 ` Dryden Personalis
2016-05-08 13:01 ` Dryden Personalis
2016-05-09 6:07 ` Andrei Borzenkov
2016-05-09 8:41 ` Dryden Personalis [this message]
2016-05-09 16:10 ` Dryden Personalis
2016-05-09 16:18 ` Dryden Personalis
2016-05-09 17:56 ` Dryden Personalis
2016-05-17 18:01 ` Dryden Personalis
2016-05-08 9:23 ` Andrei Borzenkov
2016-05-08 13:09 ` Dryden Personalis
2016-05-09 0:10 ` Xen
2016-05-09 0:10 ` Dryden Personalis
-- strict thread matches above, loose matches on Subject: below --
2013-09-25 12:39 Gabriel de Perthuis
2013-09-26 8:53 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-27 10:39 ` Gabriel de Perthuis
2013-09-27 10:39 ` Gabriel de Perthuis
2013-09-27 12:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-27 13:56 ` Gabriel de Perthuis
2013-09-27 13:56 ` Gabriel de Perthuis
2013-09-27 14:27 ` Andrey Borzenkov
2015-02-15 10:47 ` Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe4753c68025fcb38fa99ae7ddf1e7ec@dds.nl \
--to=list@xenhideout.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.