All of lore.kernel.org
 help / color / mirror / Atom feed
* Crash related to c4cdf753 (move fw_features to struct ath10k_fw_file)
@ 2016-05-09 22:02 Ben Greear
  0 siblings, 0 replies; only message in thread
From: Ben Greear @ 2016-05-09 22:02 UTC (permalink / raw)
  To: ath10k, Kalle Valo

I think that second chunk should use fw_file->fw.features instead of ar->running ... ???

It crashes everytime for me (wireless testing from a few days ago).

@@ -1074,13 +1074,13 @@ static int ath10k_core_fetch_firmware_api_n(struct ath10k *ar, const char *name,
                                         ath10k_dbg(ar, ATH10K_DBG_BOOT,
                                                    "Enabling feature bit: %i\n",
                                                    i);
-                                       __set_bit(i, ar->fw_features);
+                                       __set_bit(i, fw_file->fw_features);
                                 }
                         }

                         ath10k_dbg_dump(ar, ATH10K_DBG_BOOT, "features", "",
-                                       ar->fw_features,
-                                       sizeof(ar->fw_features));
+                                       ar->running_fw->fw_file.fw_features,
+                                       sizeof(fw_file->fw_features));
                         break;
                 case ATH10K_FW_IE_FW_IMAGE:
                         ath10k_dbg(ar, ATH10K_DBG_BOOT,


Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-05-10  2:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-09 22:02 Crash related to c4cdf753 (move fw_features to struct ath10k_fw_file) Ben Greear

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.