All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed
Date: Tue, 10 May 2016 13:52:56 +0300	[thread overview]
Message-ID: <5731BD88.1070401@ti.com> (raw)
In-Reply-To: <1462830733-1710590-1-git-send-email-arnd@arndb.de>


[-- Attachment #1.1.1: Type: text/plain, Size: 1103 bytes --]

On 10/05/16 00:51, Arnd Bergmann wrote:
> In some configurations, we can build the OMAP dss driver without
> implictly including the pinctrl consumer definitions, causing
> a build error:
> 
> gpu/drm/omapdrm/dss/dss.c: In function 'dss_runtime_suspend':
> gpu/drm/omapdrm/dss/dss.c:1268:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
> 
> This adds an explicit #include.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/omapdrm/dss/dss.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index f95ff319e68e..3303cfad4838 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -30,6 +30,7 @@
>  #include <linux/delay.h>
>  #include <linux/seq_file.h>
>  #include <linux/clk.h>
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/gfp.h>

Thanks, queued for omapdrm fixes.

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Dave Gerlach <d-gerlach@ti.com>, Rob Clark <robdclark@gmail.com>,
	Dave Airlie <airlied@gmail.com>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed
Date: Tue, 10 May 2016 13:52:56 +0300	[thread overview]
Message-ID: <5731BD88.1070401@ti.com> (raw)
In-Reply-To: <1462830733-1710590-1-git-send-email-arnd@arndb.de>


[-- Attachment #1.1: Type: text/plain, Size: 1103 bytes --]

On 10/05/16 00:51, Arnd Bergmann wrote:
> In some configurations, we can build the OMAP dss driver without
> implictly including the pinctrl consumer definitions, causing
> a build error:
> 
> gpu/drm/omapdrm/dss/dss.c: In function 'dss_runtime_suspend':
> gpu/drm/omapdrm/dss/dss.c:1268:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
> 
> This adds an explicit #include.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/omapdrm/dss/dss.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index f95ff319e68e..3303cfad4838 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -30,6 +30,7 @@
>  #include <linux/delay.h>
>  #include <linux/seq_file.h>
>  #include <linux/clk.h>
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/gfp.h>

Thanks, queued for omapdrm fixes.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-05-10 10:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 21:51 [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h where needed Arnd Bergmann
2016-05-09 21:51 ` Arnd Bergmann
2016-05-09 21:51 ` [PATCH 2/2] drm/sti: include linux/seq_file.h " Arnd Bergmann
2016-05-09 21:51   ` Arnd Bergmann
2016-05-11  7:07   ` Benjamin Gaignard
2016-05-11  7:07     ` Benjamin Gaignard
2016-05-11  7:47     ` Daniel Vetter
2016-05-11  7:47       ` Daniel Vetter
2016-05-10 10:52 ` Tomi Valkeinen [this message]
2016-05-10 10:52   ` [PATCH 1/2] drm/omapdrm: include pinctrl/consumer.h " Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5731BD88.1070401@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=d-gerlach@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.