From: Vlastimil Babka <vbabka@suse.cz>
To: js1304@gmail.com, Andrew Morton <akpm@linux-foundation.org>
Cc: mgorman@techsingularity.net, Minchan Kim <minchan@kernel.org>,
Alexander Potapenko <glider@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 2/6] mm/page_owner: initialize page owner without holding the zone lock
Date: Tue, 10 May 2016 17:00:46 +0200 [thread overview]
Message-ID: <5731F79E.6040606@suse.cz> (raw)
In-Reply-To: <1462252984-8524-3-git-send-email-iamjoonsoo.kim@lge.com>
On 05/03/2016 07:23 AM, js1304@gmail.com wrote:
> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> It's not necessary to initialized page_owner with holding the zone lock.
> It would cause more contention on the zone lock although it's not
> a big problem since it is just debug feature. But, it is better
> than before so do it. This is also preparation step to use stackdepot
> in page owner feature. Stackdepot allocates new pages when there is no
> reserved space and holding the zone lock in this case will cause deadlock.
I have same concerns here as for Patch 1/6.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: js1304@gmail.com, Andrew Morton <akpm@linux-foundation.org>
Cc: mgorman@techsingularity.net, Minchan Kim <minchan@kernel.org>,
Alexander Potapenko <glider@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 2/6] mm/page_owner: initialize page owner without holding the zone lock
Date: Tue, 10 May 2016 17:00:46 +0200 [thread overview]
Message-ID: <5731F79E.6040606@suse.cz> (raw)
In-Reply-To: <1462252984-8524-3-git-send-email-iamjoonsoo.kim@lge.com>
On 05/03/2016 07:23 AM, js1304@gmail.com wrote:
> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> It's not necessary to initialized page_owner with holding the zone lock.
> It would cause more contention on the zone lock although it's not
> a big problem since it is just debug feature. But, it is better
> than before so do it. This is also preparation step to use stackdepot
> in page owner feature. Stackdepot allocates new pages when there is no
> reserved space and holding the zone lock in this case will cause deadlock.
I have same concerns here as for Patch 1/6.
Thanks.
next prev parent reply other threads:[~2016-05-10 15:00 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 5:22 [PATCH 0/6] mm/page_owner: use tackdepot to store stacktrace js1304
2016-05-03 5:22 ` js1304
2016-05-03 5:22 ` [PATCH 1/6] mm/compaction: split freepages without holding the zone lock js1304
2016-05-03 5:22 ` js1304
2016-05-10 14:56 ` Vlastimil Babka
2016-05-10 14:56 ` Vlastimil Babka
2016-05-12 2:51 ` Joonsoo Kim
2016-05-12 2:51 ` Joonsoo Kim
2016-05-03 5:23 ` [PATCH 2/6] mm/page_owner: initialize page owner " js1304
2016-05-03 5:23 ` js1304
2016-05-10 15:00 ` Vlastimil Babka [this message]
2016-05-10 15:00 ` Vlastimil Babka
2016-05-03 5:23 ` [PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner() js1304
2016-05-03 5:23 ` js1304
2016-05-10 15:13 ` Vlastimil Babka
2016-05-10 15:13 ` Vlastimil Babka
2016-05-12 2:58 ` Joonsoo Kim
2016-05-12 2:58 ` Joonsoo Kim
2016-05-12 6:48 ` Vlastimil Babka
2016-05-12 6:48 ` Vlastimil Babka
2016-05-03 5:23 ` [PATCH 4/6] mm/page_owner: introduce split_page_owner and replace manual handling js1304
2016-05-03 5:23 ` js1304
2016-05-10 15:14 ` Vlastimil Babka
2016-05-10 15:14 ` Vlastimil Babka
2016-05-03 5:23 ` [PATCH 5/6] tools/vm/page_owner: increase temporary buffer size js1304
2016-05-03 5:23 ` js1304
2016-05-03 5:23 ` [PATCH 6/6] mm/page_owner: use stackdepot to store stacktrace js1304
2016-05-03 5:23 ` js1304
2016-05-03 8:53 ` Michal Hocko
2016-05-03 8:53 ` Michal Hocko
2016-05-04 2:14 ` Joonsoo Kim
2016-05-04 2:14 ` Joonsoo Kim
2016-05-04 2:35 ` Joonsoo Kim
2016-05-04 2:35 ` Joonsoo Kim
2016-05-04 9:23 ` Michal Hocko
2016-05-04 9:23 ` Michal Hocko
2016-05-04 15:31 ` Joonsoo Kim
2016-05-04 15:31 ` Joonsoo Kim
2016-05-04 9:21 ` Michal Hocko
2016-05-04 9:21 ` Michal Hocko
2016-05-04 15:30 ` Joonsoo Kim
2016-05-04 15:30 ` Joonsoo Kim
2016-05-04 15:45 ` Joonsoo Kim
2016-05-04 15:45 ` Joonsoo Kim
2016-05-04 19:41 ` Michal Hocko
2016-05-04 19:41 ` Michal Hocko
2016-05-04 19:40 ` Michal Hocko
2016-05-04 19:40 ` Michal Hocko
2016-05-10 7:07 ` Joonsoo Kim
2016-05-10 7:07 ` Joonsoo Kim
2016-05-10 8:57 ` Michal Hocko
2016-05-10 8:57 ` Michal Hocko
2016-05-12 11:57 ` Vlastimil Babka
2016-05-12 11:57 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731F79E.6040606@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.