From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Richard Henderson <rth@twiddle.net>,
Sergey Fedorov <sergey.fedorov@linaro.org>,
qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec()
Date: Tue, 10 May 2016 22:13:12 +0300 [thread overview]
Message-ID: <573232C8.7040906@gmail.com> (raw)
In-Reply-To: <c79a866c-2684-6510-72d4-a278f9a91083@twiddle.net>
On 10/05/16 19:13, Richard Henderson wrote:
> On 05/10/2016 05:46 AM, Sergey Fedorov wrote:
>> +#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY)
>> + X86CPU *x86_cpu = X86_CPU(cpu);
>> +
>> + if ((cpu->interrupt_request & CPU_INTERRUPT_POLL)
>> + && replay_interrupt()) {
>> + apic_poll_irq(x86_cpu->apic_state);
>
> Since you're moving this around, you might as well place the x86_cpu
> variable in the inner-most if, next to its only use.
Agree, will fix in v2.
>
> Otherwise,
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
Kind regards,
Sergey
next prev parent reply other threads:[~2016-05-10 19:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 15:46 [Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec() Sergey Fedorov
2016-05-10 15:46 ` [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec() Sergey Fedorov
2016-05-10 16:13 ` Richard Henderson
2016-05-10 19:13 ` Sergey Fedorov [this message]
2016-05-10 15:46 ` [Qemu-devel] [PATCH 2/5] cpu-exec: Move exception " Sergey Fedorov
2016-05-10 16:21 ` Richard Henderson
2016-05-10 19:21 ` Sergey Fedorov
2016-05-10 15:46 ` [Qemu-devel] [PATCH 3/5] cpu-exec: Move interrupt " Sergey Fedorov
2016-05-10 16:34 ` Richard Henderson
2016-05-10 19:24 ` Sergey Fedorov
2016-05-10 15:46 ` [Qemu-devel] [PATCH 4/5] cpu-exec: Move TB execution stuff " Sergey Fedorov
2016-05-10 16:56 ` Richard Henderson
2016-05-10 15:46 ` [Qemu-devel] [PATCH 5/5] cpu-exec: Remove unused 'x86_cpu' and 'env' from cpu_exec() Sergey Fedorov
2016-05-10 16:57 ` Richard Henderson
2016-05-10 15:49 ` [Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec() Sergey Fedorov
-- strict thread matches above, loose matches on Subject: below --
2016-05-11 10:21 Sergey Fedorov
2016-05-11 10:21 ` [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec() Sergey Fedorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573232C8.7040906@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sergey.fedorov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.