All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Nicolas Chauvet <kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rtc: rename so the tps6586x-rtc module can be autoloaded at boot
Date: Tue, 10 May 2016 17:02:27 -0600	[thread overview]
Message-ID: <57326883.6020000@wwwdotorg.org> (raw)
In-Reply-To: <CABr+WTnFodrRSThovUCwY+8Th0TjeOPSAFkCKcupfjAXE4bUAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 05/10/2016 03:44 PM, Nicolas Chauvet wrote:
> 2016-05-10 17:43 GMT+02:00 Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>:
>> On 05/10/2016 04:26 AM, Nicolas Chauvet wrote:
>>>
>>> This module is loaded by the related mfd driver which has
>>> the needed MODULE_DEVICE_TABLE(i2c,...).
>>>
>>> This patch fix the modalias when the rtc driver is built
>>> as a module, so the right name is used.
>>> Everything operates correctly when this module is builtin.
>>
>>
>> I'm sure this used to work. Do you know when/why it broke? Perhaps a Fixes:
>> tag would be useful, and perhaps a Cc: stable?
>
> I don't remember autoloading of rtc-tps6586x.ko has ever worked. Then
> there is still the issue of rtc modules loaded too late for the kernel
> (or the kernel not capable to defer the read of hw clock), but that's
> another issue.
>
> I first tried to report the issue on this bug tracker and at that
> time, autoloading wasn't working (was in 2014).
> https://bugzilla.redhat.com/show_bug.cgi?id=1074002
>
> I'm sure current distros using an arm generic kernel (with all
> modules) will rebase on kernel 4.4, but technically the bug is present
> in kernel 3.10 from the oldest current maintained branch (since the
> driver introduction).

Ah, all the cases I used previous did indeed have the RTC driver 
built-in not a module, so that explains it.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Nicolas Chauvet <kwizart@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	rtc-linux@googlegroups.com, linux-omap@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH] rtc: rename so the tps6586x-rtc module can be autoloaded at boot
Date: Tue, 10 May 2016 17:02:27 -0600	[thread overview]
Message-ID: <57326883.6020000@wwwdotorg.org> (raw)
In-Reply-To: <CABr+WTnFodrRSThovUCwY+8Th0TjeOPSAFkCKcupfjAXE4bUAA@mail.gmail.com>

On 05/10/2016 03:44 PM, Nicolas Chauvet wrote:
> 2016-05-10 17:43 GMT+02:00 Stephen Warren <swarren@wwwdotorg.org>:
>> On 05/10/2016 04:26 AM, Nicolas Chauvet wrote:
>>>
>>> This module is loaded by the related mfd driver which has
>>> the needed MODULE_DEVICE_TABLE(i2c,...).
>>>
>>> This patch fix the modalias when the rtc driver is built
>>> as a module, so the right name is used.
>>> Everything operates correctly when this module is builtin.
>>
>>
>> I'm sure this used to work. Do you know when/why it broke? Perhaps a Fixes:
>> tag would be useful, and perhaps a Cc: stable?
>
> I don't remember autoloading of rtc-tps6586x.ko has ever worked. Then
> there is still the issue of rtc modules loaded too late for the kernel
> (or the kernel not capable to defer the read of hw clock), but that's
> another issue.
>
> I first tried to report the issue on this bug tracker and at that
> time, autoloading wasn't working (was in 2014).
> https://bugzilla.redhat.com/show_bug.cgi?id=1074002
>
> I'm sure current distros using an arm generic kernel (with all
> modules) will rebase on kernel 4.4, but technically the bug is present
> in kernel 3.10 from the oldest current maintained branch (since the
> driver introduction).

Ah, all the cases I used previous did indeed have the RTC driver 
built-in not a module, so that explains it.

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2016-05-10 23:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 10:26 [PATCH] rtc: rename so the tps6586x-rtc module can be autoloaded at boot Nicolas Chauvet
2016-05-10 10:26 ` [rtc-linux] " Nicolas Chauvet
     [not found] ` <1462876002-6462-1-git-send-email-kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-10 15:43   ` Stephen Warren
2016-05-10 15:43     ` [rtc-linux] " Stephen Warren
2016-05-10 21:36     ` Nicolas Chauvet
     [not found]     ` <573201AD.7080705-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-05-10 21:44       ` Nicolas Chauvet
2016-05-10 21:44         ` [rtc-linux] " Nicolas Chauvet
     [not found]         ` <CABr+WTnFodrRSThovUCwY+8Th0TjeOPSAFkCKcupfjAXE4bUAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-10 23:02           ` Stephen Warren [this message]
2016-05-10 23:02             ` Stephen Warren
2016-05-11 14:58   ` Alexandre Belloni
2016-05-11 14:58     ` [rtc-linux] " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57326883.6020000@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
    --cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.