From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Cc: lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH 2/2] devicetree: use node #address/size-cells
Date: Wed, 11 May 2016 09:12:50 +0200 [thread overview]
Message-ID: <5732DB72.2010202@redhat.com> (raw)
In-Reply-To: <1462901526-11013-3-git-send-email-drjones@redhat.com>
On 10.05.2016 19:32, Andrew Jones wrote:
> Don't assume all pbus (cpu physical bus) translations will use the same
> number of address and size cells as are defined in the root node.
That's a good idea, of course.
> Also,
> drop the caching of the address/size cells in the bus structure, as that
> was a bad idea, and unused anyway.
Maybe do it in a separate patch?
> (I was tempted to completely remove dt_pbus_translate_node, which still
> uses the root node's address/size cells, but I kept it, as it offers a
> nice shortcut for when we are sure we can use the root node's cells.)
Sounds like this function could cause quite a bit of confusion in the
future... maybe it would be better to remove it so that no one can use
it in the wrong way anymore?
Thomas
next prev parent reply other threads:[~2016-05-11 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 17:32 [kvm-unit-tests PATCH 0/2] devicetree: use correct #address/#size cells Andrew Jones
2016-05-10 17:32 ` [kvm-unit-tests PATCH 1/2] devicetree: search up tree in dt_get_nr_cells Andrew Jones
2016-05-11 7:02 ` Thomas Huth
2016-05-11 9:04 ` Andrew Jones
2016-05-11 9:28 ` Thomas Huth
2016-05-11 11:23 ` Andrew Jones
2016-05-10 17:32 ` [kvm-unit-tests PATCH 2/2] devicetree: use node #address/size-cells Andrew Jones
2016-05-11 7:12 ` Thomas Huth [this message]
2016-05-11 9:09 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5732DB72.2010202@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.