From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: at91: sam9x5: Fix the memory range assigned to the PMC
Date: Wed, 11 May 2016 12:11:56 +0200 [thread overview]
Message-ID: <5733056C.9000100@atmel.com> (raw)
In-Reply-To: <1462957202-22671-1-git-send-email-boris.brezillon@free-electrons.com>
Le 11/05/2016 11:00, Boris Brezillon a ?crit :
> The memory range assigned to the PMC (Power Management Controller) was
> not including the PMC_PCR register which are used to control peripheral
> clocks.
>
> This was working fine thanks to the page granularity of ioremap(), but
> started to fail when we switched to syscon/regmap, because regmap is
> making sure that all accesses are falling into the reserved range.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Richard Genoud <richard.genoud@gmail.com>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
> Fixes: 863a81c3be1d ("clk: at91: make use of syscon to share PMC registers in several drivers")
> Cc: <stable@vger.kernel.org>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Boris!
> ---
> Hi Arnd,
>
> This patch is fixing a regression reported by Richard. Since this
> regression was introduced in 4.6-rc1 it would be great if you could
> take it before 4.6 is released.
Arnd, arm-soc guys,
I can build a Pull-Request instantly today, if you wish: just tell me if
you prefer.
Bye,
> ---
> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index 0827d59..cd0cd5f 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -106,7 +106,7 @@
>
> pmc: pmc at fffffc00 {
> compatible = "atmel,at91sam9x5-pmc", "syscon";
> - reg = <0xfffffc00 0x100>;
> + reg = <0xfffffc00 0x200>;
> interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> interrupt-controller;
> #address-cells = <1>;
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
<arm@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-arm-kernel@lists.infradead.org>,
Richard Genoud <richard.genoud@gmail.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sam9x5: Fix the memory range assigned to the PMC
Date: Wed, 11 May 2016 12:11:56 +0200 [thread overview]
Message-ID: <5733056C.9000100@atmel.com> (raw)
In-Reply-To: <1462957202-22671-1-git-send-email-boris.brezillon@free-electrons.com>
Le 11/05/2016 11:00, Boris Brezillon a �crit :
> The memory range assigned to the PMC (Power Management Controller) was
> not including the PMC_PCR register which are used to control peripheral
> clocks.
>
> This was working fine thanks to the page granularity of ioremap(), but
> started to fail when we switched to syscon/regmap, because regmap is
> making sure that all accesses are falling into the reserved range.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Richard Genoud <richard.genoud@gmail.com>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
> Fixes: 863a81c3be1d ("clk: at91: make use of syscon to share PMC registers in several drivers")
> Cc: <stable@vger.kernel.org>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Boris!
> ---
> Hi Arnd,
>
> This patch is fixing a regression reported by Richard. Since this
> regression was introduced in 4.6-rc1 it would be great if you could
> take it before 4.6 is released.
Arnd, arm-soc guys,
I can build a Pull-Request instantly today, if you wish: just tell me if
you prefer.
Bye,
> ---
> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index 0827d59..cd0cd5f 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -106,7 +106,7 @@
>
> pmc: pmc@fffffc00 {
> compatible = "atmel,at91sam9x5-pmc", "syscon";
> - reg = <0xfffffc00 0x100>;
> + reg = <0xfffffc00 0x200>;
> interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> interrupt-controller;
> #address-cells = <1>;
>
--
Nicolas Ferre
next prev parent reply other threads:[~2016-05-11 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 9:00 [PATCH] ARM: dts: at91: sam9x5: Fix the memory range assigned to the PMC Boris Brezillon
2016-05-11 9:00 ` Boris Brezillon
2016-05-11 10:11 ` Nicolas Ferre [this message]
2016-05-11 10:11 ` Nicolas Ferre
2016-05-11 15:14 ` Nicolas Ferre
2016-05-11 15:14 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5733056C.9000100@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.