Re: [Qemu-trivial] [Qemu-devel] [PATCH] nbd: fix trim/discard commands with a length bigger than NBD_MAX_BUFFER_SIZE

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]

On 05/11/2016 02:34 AM, Quentin Casasnovas wrote:
>> Your patch duplicates what is already present in qemu:
>>
>> commit eb38c3b67018ff8069e4f674a28661931a8a3e4f

> Ha sorry I missed this! I wouldn't have tried to debug/fix myself otherwise :)

It's okay - you at least sparked a good conversation of what the NBD
protocol itself needs to think about in relation to these issues.

> 
>> It also helps to state what version of qemu you were testing, as it is
>> obviously not the (soon-to-be-released) version 2.6 which already has
>> the fix.
>>
> 
> I was using qemu-2.5.0-rc3 on Gentoo but this was also verified on some
> Debian systems which appears to be on 1.1.2+dfsg-6a+deb7u12 and on Ubuntu
> Xenial 2.0.0+dfsg-2ubuntu1.22.
> 
> I wrote the patch on top of https://github.com/bonzini/qemu.git:master
> (a7e00e2) which didn't contain the fix last Friday.

The master branch in Paolo's tree doesn't always actively track upstream
(mainly when he is about to post a pull request that needs to be
rebased).  Best is to base patches against true upstream:
git://git.qemu-project.org/qemu.git

> 
> Anyway, cool if the fix is going into mainline :)

Already in there for the 2.6 release candidates (and final 2.6 should be
later today).  And this thread argues that the stable 2.5.x branch
should indeed backport the identified patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]