From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/7] accel/qaic: Fix MHI channel struct field order
Date: Mon, 11 Dec 2023 12:23:42 +0100 [thread overview]
Message-ID: <57343233-91eb-4caf-b2e6-b42e97268552@linux.intel.com> (raw)
In-Reply-To: <20231208163457.1295993-4-quic_jhugo@quicinc.com>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
On 08.12.2023 17:34, Jeffrey Hugo wrote:
> The timesync channels have their struct fields out of order with the rest
> of the channels. Fix them so there is a consistent style in the file.
>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
> ---
> drivers/accel/qaic/mhi_controller.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/qaic/mhi_controller.c b/drivers/accel/qaic/mhi_controller.c
> index 832464f2833a..364eede0ac02 100644
> --- a/drivers/accel/qaic/mhi_controller.c
> +++ b/drivers/accel/qaic/mhi_controller.c
> @@ -358,8 +358,8 @@ static struct mhi_channel_config aic100_channels[] = {
> .wake_capable = false,
> },
> {
> - .num = 21,
> .name = "QAIC_TIMESYNC",
> + .num = 21,
> .num_elements = 32,
> .local_elements = 0,
> .event_ring = 0,
> @@ -390,8 +390,8 @@ static struct mhi_channel_config aic100_channels[] = {
> .wake_capable = false,
> },
> {
> - .num = 23,
> .name = "QAIC_TIMESYNC_PERIODIC",
> + .num = 23,
> .num_elements = 32,
> .local_elements = 0,
> .event_ring = 0,
next prev parent reply other threads:[~2023-12-11 11:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 16:34 [PATCH 0/7] qaic cleanups for 6.8 Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-08 16:34 ` [PATCH 1/7] accel/qaic: Deprecate ->size field from attach slice IOCTL structure Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-11 11:23 ` Jacek Lawrynowicz
2023-12-08 16:34 ` [PATCH 2/7] accel/qaic: Remove bo->queued field Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-11 11:24 ` Jacek Lawrynowicz
2023-12-08 16:34 ` [PATCH 3/7] accel/qaic: Fix MHI channel struct field order Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-11 11:23 ` Jacek Lawrynowicz [this message]
2023-12-08 16:34 ` [PATCH 4/7] accel/qaic: Drop the reference to BO in error path of create BO IOCTL Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-11 11:25 ` Jacek Lawrynowicz
2023-12-08 16:34 ` [PATCH 5/7] accel/qaic: Call drm_gem_create_mmap_offset() once for each BO Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-11 11:26 ` Jacek Lawrynowicz
2023-12-08 16:34 ` [PATCH 6/7] accel/qaic: Leverage DRM managed APIs to release resources Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-15 18:06 ` Jeffrey Hugo
2023-12-15 18:06 ` Jeffrey Hugo
2023-12-20 7:02 ` Jacek Lawrynowicz
2023-12-20 18:11 ` Jeffrey Hugo
2023-12-08 16:34 ` [PATCH 7/7] accel/qaic: Order pci_remove() operations in reverse of probe() Jeffrey Hugo
2023-12-08 16:34 ` Jeffrey Hugo
2023-12-11 11:27 ` Jacek Lawrynowicz
2023-12-15 18:05 ` [PATCH 0/7] qaic cleanups for 6.8 Jeffrey Hugo
2023-12-15 18:05 ` Jeffrey Hugo
2023-12-20 18:20 ` Jeffrey Hugo
2023-12-20 18:20 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57343233-91eb-4caf-b2e6-b42e97268552@linux.intel.com \
--to=jacek.lawrynowicz@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.