Re: [PATCH 7/7] accel/qaic: Order pci_remove() operations in reverse of probe()

[Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>]

Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>

On 08.12.2023 17:34, Jeffrey Hugo wrote:
> In probe() we create the drm_device, and then register the MHI controller.
> In remove(), we should unregister the controller first, then remove the
> drm_device.  Update the remove() operations to match.
> 
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
> Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
> ---
>  drivers/accel/qaic/qaic_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c
> index 10a43d02844f..d1a632dbaec6 100644
> --- a/drivers/accel/qaic/qaic_drv.c
> +++ b/drivers/accel/qaic/qaic_drv.c
> @@ -550,8 +550,8 @@ static void qaic_pci_remove(struct pci_dev *pdev)
>  		return;
>  
>  	qaic_dev_reset_clean_local_state(qdev);
> -	qaic_destroy_drm_device(qdev, QAIC_NO_PARTITION);
>  	qaic_mhi_free_controller(qdev->mhi_cntrl, link_up);
> +	qaic_destroy_drm_device(qdev, QAIC_NO_PARTITION);
>  }
>  
>  static void qaic_pci_shutdown(struct pci_dev *pdev)