* Re: [PATCH]kvm:remove reduplicative mark_page_dirty in hyperv.c
[not found] <CABvbLL1xE3EAZnk_0wpmW1f0kFZdKMPYD6LkVMK=kQHVC3oXXQ@mail.gmail.com>
@ 2016-04-07 15:06 ` Radim Krčmář
2016-05-12 11:49 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Radim Krčmář @ 2016-04-07 15:06 UTC (permalink / raw)
To: rhett rhett; +Cc: kvm, pbonzini, gleb
The subject would be slightly nicer as "KVM: Hyper-V:", so uninterested
people wouldn't even need to read it to the end. :) (`git log --oneline`
says that "kvm/x86:" is another popular tag for that file.)
2016-04-07 10:37+0800, rhett rhett:
> i think the mark_page_dirty is unnecessary, because the page had been
> marked as dirty inside the kvm_write_guest routinue.
For [PATCH v2],
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: rhett.kernel@gmail.com
>
> 8499907b52c9cebf3c1a4aaa63b84bd9c3c1ff3d
> arch/x86/kvm/hyperv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
> index 01bd7b7..e831032 100644
> --- a/arch/x86/kvm/hyperv.c
> +++ b/arch/x86/kvm/hyperv.c
> @@ -807,7 +807,6 @@ static int kvm_hv_set_msr_pw(struct kvm_vcpu *vcpu, u32
> msr, u64 data,
> gfn << HV_X64_MSR_TSC_REFERENCE_ADDRESS_SHIFT,
> &tsc_ref, sizeof(tsc_ref)))
> return 1;
> - mark_page_dirty(kvm, gfn);
> break;
> }
> case HV_X64_MSR_CRASH_P0 ... HV_X64_MSR_CRASH_P4:
Your mail client mangled the diff (not to mention that the email also
has an unwelcome HTML part).
Please send a v2 that can be applied with `git am`.
The easiest way to ensure a proper submission is to use git from
beginning to end: `git commit`, `git format-patch`, `git send-email`.
^ permalink raw reply [flat|nested] 2+ messages in thread