From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: tony@atomide.com, dri-devel@lists.freedesktop.org,
Michael Walle <mwalle@kernel.org>
Cc: Michael Walle <mwalle@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
dri-devel@lists.freedesktop.org,
Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com,
ivo.g.dimitrov.75@gmail.com, rfoss@kernel.org,
jernej.skrabec@gmail.com, simhavcs@gmail.com, merlijn@wizzup.org,
devicetree@vger.kernel.org, conor+dt@kernel.org, jonas@kwiboo.se,
pavel@ucw.cz, mripard@kernel.org, robh+dt@kernel.org,
philipp@uvos.xyz, neil.armstrong@linaro.org, sre@kernel.org,
tzimmermann@suse.de
Subject: Re: [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765
Date: Mon, 27 Nov 2023 14:21:08 +0100 [thread overview]
Message-ID: <5735396.DvuYhMxLoT@steina-w> (raw)
In-Reply-To: <20231127124430.2153227-1-mwalle@kernel.org>
Hi,
Am Montag, 27. November 2023, 13:44:30 CET schrieb Michael Walle:
> Hi,
>
> > The tc358765 is similar to tc358775 except for the stdby-gpios.
>
> Bad timing (for me). I'm about to send a bigger patch series for the
> tc358775 which fixes the (completely) broken initialialization. And also
> contains some of your fixes.
>
> That being said, I intend to make the standby gpio optional also for the
> tc358755, because it might just be hardwired on the board.
>
> But second, I'm really curious if this bridge is working for you correctly
> as it is at the moment. One particular thing I've noticed is that you must
> release the reset while both the clock and the data lanes are in LP11 mode.
> Otherwise, the bridge won't work properly (i.e. horizontally shifted
> picture, or no picture at all).
Apparently this seems to be true for all Toshiba DSI bridges. The power on
sequence for TC9595 (TC358767) also requires LP-11 before releasing the reset
signal RESX. Additionally LP-11 is requires for using the DP AUX channel.
This also relates to the patch set from Dmitry [1].
Best regards,
Alexander
[1] https://lore.kernel.org/dri-devel/20231016165355.1327217-1-dmitry.baryshkov@linaro.org/
> What DSI host controller are you using?
>
> -michael
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: tony@atomide.com, dri-devel@lists.freedesktop.org,
Michael Walle <mwalle@kernel.org>
Cc: mripard@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, ivo.g.dimitrov.75@gmail.com,
Michael Walle <mwalle@kernel.org>,
krzysztof.kozlowski+dt@linaro.org, jonas@kwiboo.se, pavel@ucw.cz,
tzimmermann@suse.de, merlijn@wizzup.org,
neil.armstrong@linaro.org, sre@kernel.org,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com,
simhavcs@gmail.com, rfoss@kernel.org, philipp@uvos.xyz,
jernej.skrabec@gmail.com
Subject: Re: [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765
Date: Mon, 27 Nov 2023 14:21:08 +0100 [thread overview]
Message-ID: <5735396.DvuYhMxLoT@steina-w> (raw)
In-Reply-To: <20231127124430.2153227-1-mwalle@kernel.org>
Hi,
Am Montag, 27. November 2023, 13:44:30 CET schrieb Michael Walle:
> Hi,
>
> > The tc358765 is similar to tc358775 except for the stdby-gpios.
>
> Bad timing (for me). I'm about to send a bigger patch series for the
> tc358775 which fixes the (completely) broken initialialization. And also
> contains some of your fixes.
>
> That being said, I intend to make the standby gpio optional also for the
> tc358755, because it might just be hardwired on the board.
>
> But second, I'm really curious if this bridge is working for you correctly
> as it is at the moment. One particular thing I've noticed is that you must
> release the reset while both the clock and the data lanes are in LP11 mode.
> Otherwise, the bridge won't work properly (i.e. horizontally shifted
> picture, or no picture at all).
Apparently this seems to be true for all Toshiba DSI bridges. The power on
sequence for TC9595 (TC358767) also requires LP-11 before releasing the reset
signal RESX. Additionally LP-11 is requires for using the DP AUX channel.
This also relates to the patch set from Dmitry [1].
Best regards,
Alexander
[1] https://lore.kernel.org/dri-devel/20231016165355.1327217-1-dmitry.baryshkov@linaro.org/
> What DSI host controller are you using?
>
> -michael
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2023-11-27 13:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 16:32 [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765 Tony Lindgren
2023-11-26 16:32 ` Tony Lindgren
2023-11-26 16:32 ` [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes Tony Lindgren
2023-11-26 16:32 ` Tony Lindgren
2023-11-26 17:18 ` [PATCH 3/6] drm/bridge: tc358775: Add jeida-24 support Tony Lindgren
2023-11-26 18:17 ` [PATCH 4/6] drm/bridge: tc358775: Add burst and low-power modes Tony Lindgren
2023-11-26 18:56 ` [PATCH 5/6] drm/bridge: tc358775: Add support for tc358765 Tony Lindgren
2023-11-26 19:15 ` [PATCH 6/6] drm/bridge: tc358775: Configure hs_rate and lp_rate Tony Lindgren
2023-11-27 13:25 ` [PATCH 3/6] drm/bridge: tc358775: Add jeida-24 support Michael Walle
2023-11-27 13:25 ` Michael Walle
2023-11-27 13:40 ` Tony Lindgren
2023-11-27 13:40 ` Tony Lindgren
2023-11-27 13:09 ` [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes Michael Walle
2023-11-27 13:09 ` Michael Walle
2023-11-27 13:19 ` Tony Lindgren
2023-11-27 13:19 ` Tony Lindgren
2023-11-27 14:31 ` Michael Walle
2023-11-27 14:31 ` Michael Walle
2023-11-27 15:06 ` Tony Lindgren
2023-11-27 15:06 ` Tony Lindgren
2023-11-27 7:18 ` [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765 Krzysztof Kozlowski
2023-11-27 7:18 ` Krzysztof Kozlowski
2023-11-27 12:44 ` Michael Walle
2023-11-27 12:44 ` Michael Walle
2023-11-27 13:07 ` Tony Lindgren
2023-11-27 13:07 ` Tony Lindgren
2023-11-27 13:21 ` Alexander Stein [this message]
2023-11-27 13:21 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5735396.DvuYhMxLoT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=merlijn@wizzup.org \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pavel@ucw.cz \
--cc=philipp@uvos.xyz \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=simhavcs@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.