From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Zhang, Chunyu" <zhangcy@cn.fujitsu.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: question about xl migrate
Date: Tue, 17 May 2016 10:36:32 +0100 [thread overview]
Message-ID: <573AE620.7050903@citrix.com> (raw)
In-Reply-To: <A43879EB4A7F5F449E2CA8148EA79E51FE880D07@G08CNEXMBPEKD01.g08.fujitsu.local>
On 17/05/16 10:01, Zhang, Chunyu wrote:
> hi all
>
> i have two question about xl migrate
>
> write_batch
> 120 for ( i = 0; i < nr_pfns; ++i )
> 121 {
> 122 types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx,
> 123 ctx->save.batch_pfns[i]);
> 124
> 125 /* Likely a ballooned page. */
> 126 if ( mfns[i] == INVALID_MFN )
> 127 {
> 128 set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages);
> 129 ++ctx->save.nr_deferred_pages;
> 130 }
> 131 }
>
> 1. line 122
> in hvm mode, is not mfns, but gfns.
> right?
Correct. The array should be named "gfns" rather than "mfns", which is
the appropriate term for both PV and HVM guests.
>
> 2. line 125
> in hvm mode,would not be a balloon page.
> gfn would not be INVALID_MFN.
> mfn would be INVALID_MFN.
> right?
I don't understand what you asking here.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-17 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 9:01 question about xl migrate Zhang, Chunyu
2016-05-17 9:36 ` Andrew Cooper [this message]
2016-05-17 9:46 ` Zhang, Chunyu
2016-05-17 9:50 ` Andrew Cooper
2016-05-17 9:55 ` Zhang, Chunyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573AE620.7050903@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhangcy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.