From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Zhang, Chunyu" <zhangcy@cn.fujitsu.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: question about xl migrate
Date: Tue, 17 May 2016 10:50:07 +0100 [thread overview]
Message-ID: <573AE94F.3040104@citrix.com> (raw)
In-Reply-To: <A43879EB4A7F5F449E2CA8148EA79E51FE881012@G08CNEXMBPEKD01.g08.fujitsu.local>
>>> 2. line 125
>>> in hvm mode,would not be a balloon page.
>>> gfn would not be INVALID_MFN.
>>> mfn would be INVALID_MFN.
>>> right?
>> I don't understand what you asking here.
> i think those code should delete:
>>> 125 /* Likely a ballooned page. */
> if page is ballooed, gfns is not INVALID_MFN, but mormal.
Perhaps for HVM guests. Definitely not for PV guests however.
>>> 126 if ( mfns[i] == INVALID_MFN )
>>> 127 {
>>> 128 set_bit(ctx->save.batch_pfns[i], ctx->save.deferred_pages);
>>> 129 ++ctx->save.nr_deferred_pages;
>>> 130 }
> those code is not for balloon.
>
> when xc_get_pfn_type_batch is called,
> ballooned page type is XEN_DOMCTL_PFINFO_XTAB
> XEN_DOMCTL_PFINFO_XTAB is for ballooned pages.
That is covered by the later check. This code needs to work for PV
guests as well as HVM guests. You absolutely can't go deleting this
clause, or you will break migration for PV guests.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-17 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 9:01 question about xl migrate Zhang, Chunyu
2016-05-17 9:36 ` Andrew Cooper
2016-05-17 9:46 ` Zhang, Chunyu
2016-05-17 9:50 ` Andrew Cooper [this message]
2016-05-17 9:55 ` Zhang, Chunyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573AE94F.3040104@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhangcy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.