* [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
@ 2016-05-16 16:17 Armin Kuster
2016-05-16 16:44 ` Khem Raj
0 siblings, 1 reply; 11+ messages in thread
From: Armin Kuster @ 2016-05-16 16:17 UTC (permalink / raw)
To: openembedded-core; +Cc: Armin Kuster
From: Armin Kuster <akuster@mvista.com>
numpy/core/include/numpy/npy_common.h:149:10: error:
| #error Unsupported size for type off_t
Signed-off-by: Armin Kuster <akuster@mvista.com>
---
meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
index 191e5a1..109deb0 100644
--- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
+++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
@@ -11,6 +11,7 @@
#define NPY_SIZEOF_PY_INTPTR_T 8
#define NPY_SIZEOF_PY_LONG_LONG 8
#define NPY_SIZEOF_LONGLONG 8
+#define NPY_SIZEOF_OFF_T 8
#define NPY_NO_SMP 0
#define NPY_HAVE_DECL_ISNAN
#define NPY_HAVE_DECL_ISINF
--
2.3.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-16 16:17 [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib Armin Kuster
@ 2016-05-16 16:44 ` Khem Raj
2016-05-17 2:26 ` akuster808
0 siblings, 1 reply; 11+ messages in thread
From: Khem Raj @ 2016-05-16 16:44 UTC (permalink / raw)
To: Armin Kuster; +Cc: Armin Kuster, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>
> From: Armin Kuster <akuster@mvista.com>
>
> numpy/core/include/numpy/npy_common.h:149:10: error:
> | #error Unsupported size for type off_t
>
> Signed-off-by: Armin Kuster <akuster@mvista.com>
> ---
> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
> index 191e5a1..109deb0 100644
> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
> @@ -11,6 +11,7 @@
> #define NPY_SIZEOF_PY_INTPTR_T 8
> #define NPY_SIZEOF_PY_LONG_LONG 8
> #define NPY_SIZEOF_LONGLONG 8
> +#define NPY_SIZEOF_OFF_T 8
Why does the test to select size of off_t fails ?
we might need similar fix for mips64 too.
> #define NPY_NO_SMP 0
> #define NPY_HAVE_DECL_ISNAN
> #define NPY_HAVE_DECL_ISINF
> --
> 2.3.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-16 16:44 ` Khem Raj
@ 2016-05-17 2:26 ` akuster808
2016-05-17 3:09 ` Khem Raj
0 siblings, 1 reply; 11+ messages in thread
From: akuster808 @ 2016-05-17 2:26 UTC (permalink / raw)
To: Khem Raj; +Cc: Armin Kuster, openembedded-core
On 05/16/2016 09:44 AM, Khem Raj wrote:
>
>> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>
>> From: Armin Kuster <akuster@mvista.com>
>>
>> numpy/core/include/numpy/npy_common.h:149:10: error:
>> | #error Unsupported size for type off_t
>>
>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>> ---
>> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>> index 191e5a1..109deb0 100644
>> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>> @@ -11,6 +11,7 @@
>> #define NPY_SIZEOF_PY_INTPTR_T 8
>> #define NPY_SIZEOF_PY_LONG_LONG 8
>> #define NPY_SIZEOF_LONGLONG 8
>> +#define NPY_SIZEOF_OFF_T 8
>
> Why does the test to select size of off_t fails ?
core/include/numpy/npy_common.h
#if NPY_SIZEOF_OFF_T == NPY_SIZEOF_SHORT
#define NPY_OFF_T_PYFMT "h"
#elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_INT
#define NPY_OFF_T_PYFMT "i"
#elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONG
#define NPY_OFF_T_PYFMT "l"
#elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONGLONG
#define NPY_OFF_T_PYFMT "L"
#else
#error Unsupported size for type off_t
#endif
its gotta match one of them. X86-64 has NPY_SIZEOF_OFF_T value set.
> we might need similar fix for mips64 too.
yep, I just built mips64 and ppc64 and they both fail like aach64.
will send v2 to fix those as well.
-armin
>
>> #define NPY_NO_SMP 0
>> #define NPY_HAVE_DECL_ISNAN
>> #define NPY_HAVE_DECL_ISINF
>> --
>> 2.3.5
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 2:26 ` akuster808
@ 2016-05-17 3:09 ` Khem Raj
2016-05-17 3:16 ` akuster808
2016-05-17 3:34 ` akuster808
0 siblings, 2 replies; 11+ messages in thread
From: Khem Raj @ 2016-05-17 3:09 UTC (permalink / raw)
To: akuster808; +Cc: Armin Kuster, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2301 bytes --]
> On May 16, 2016, at 7:26 PM, akuster808 <akuster808@gmail.com> wrote:
>
>
>
> On 05/16/2016 09:44 AM, Khem Raj wrote:
>>
>>> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>>
>>> From: Armin Kuster <akuster@mvista.com>
>>>
>>> numpy/core/include/numpy/npy_common.h:149:10: error:
>>> | #error Unsupported size for type off_t
>>>
>>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>>> ---
>>> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>> index 191e5a1..109deb0 100644
>>> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>> @@ -11,6 +11,7 @@
>>> #define NPY_SIZEOF_PY_INTPTR_T 8
>>> #define NPY_SIZEOF_PY_LONG_LONG 8
>>> #define NPY_SIZEOF_LONGLONG 8
>>> +#define NPY_SIZEOF_OFF_T 8
>>
>> Why does the test to select size of off_t fails ?
> core/include/numpy/npy_common.h
>
> #if NPY_SIZEOF_OFF_T == NPY_SIZEOF_SHORT
> #define NPY_OFF_T_PYFMT "h"
> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_INT
> #define NPY_OFF_T_PYFMT "i"
> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONG
> #define NPY_OFF_T_PYFMT "l"
> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONGLONG
> #define NPY_OFF_T_PYFMT "L"
> #else
> #error Unsupported size for type off_t
> #endif
>
> its gotta match one of them. X86-64 has NPY_SIZEOF_OFF_T value set.
yes thats the use of it. i was asking for place where it is set, most probably during configure
>
>
>> we might need similar fix for mips64 too.
> yep, I just built mips64 and ppc64 and they both fail like aach64.
>
> will send v2 to fix those as well.
OK
>
> -armin
>
>>
>>> #define NPY_NO_SMP 0
>>> #define NPY_HAVE_DECL_ISNAN
>>> #define NPY_HAVE_DECL_ISINF
>>> --
>>> 2.3.5
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 3:09 ` Khem Raj
@ 2016-05-17 3:16 ` akuster808
2016-05-17 3:34 ` akuster808
1 sibling, 0 replies; 11+ messages in thread
From: akuster808 @ 2016-05-17 3:16 UTC (permalink / raw)
To: Khem Raj, akuster808; +Cc: openembedded-core
On 5/16/16 8:09 PM, Khem Raj wrote:
>
>> On May 16, 2016, at 7:26 PM, akuster808 <akuster808@gmail.com> wrote:
>>
>>
>>
>> On 05/16/2016 09:44 AM, Khem Raj wrote:
>>>
>>>> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>>>
>>>> From: Armin Kuster <akuster@mvista.com>
>>>>
>>>> numpy/core/include/numpy/npy_common.h:149:10: error:
>>>> | #error Unsupported size for type off_t
>>>>
>>>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>>>> ---
>>>> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>> index 191e5a1..109deb0 100644
>>>> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>> @@ -11,6 +11,7 @@
>>>> #define NPY_SIZEOF_PY_INTPTR_T 8
>>>> #define NPY_SIZEOF_PY_LONG_LONG 8
>>>> #define NPY_SIZEOF_LONGLONG 8
>>>> +#define NPY_SIZEOF_OFF_T 8
>>>
>>> Why does the test to select size of off_t fails ?
>> core/include/numpy/npy_common.h
>>
>> #if NPY_SIZEOF_OFF_T == NPY_SIZEOF_SHORT
>> #define NPY_OFF_T_PYFMT "h"
>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_INT
>> #define NPY_OFF_T_PYFMT "i"
>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONG
>> #define NPY_OFF_T_PYFMT "l"
>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONGLONG
>> #define NPY_OFF_T_PYFMT "L"
>> #else
>> #error Unsupported size for type off_t
>> #endif
>>
>> its gotta match one of them. X86-64 has NPY_SIZEOF_OFF_T value set.
>
> yes thats the use of it. i was asking for place where it is set, most probably during configure
oh. hmm, let me check.
- armin
>
>>
>>
>>> we might need similar fix for mips64 too.
>> yep, I just built mips64 and ppc64 and they both fail like aach64.
>>
>> will send v2 to fix those as well.
>
> OK
>
>>
>> -armin
>>
>>>
>>>> #define NPY_NO_SMP 0
>>>> #define NPY_HAVE_DECL_ISNAN
>>>> #define NPY_HAVE_DECL_ISINF
>>>> --
>>>> 2.3.5
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 3:09 ` Khem Raj
2016-05-17 3:16 ` akuster808
@ 2016-05-17 3:34 ` akuster808
2016-05-17 3:35 ` Khem Raj
2016-05-17 13:49 ` Burton, Ross
1 sibling, 2 replies; 11+ messages in thread
From: akuster808 @ 2016-05-17 3:34 UTC (permalink / raw)
To: Khem Raj, akuster808; +Cc: openembedded-core
On 5/16/16 8:09 PM, Khem Raj wrote:
>
>> On May 16, 2016, at 7:26 PM, akuster808 <akuster808@gmail.com> wrote:
>>
>>
>>
>> On 05/16/2016 09:44 AM, Khem Raj wrote:
>>>
>>>> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>>>
>>>> From: Armin Kuster <akuster@mvista.com>
>>>>
>>>> numpy/core/include/numpy/npy_common.h:149:10: error:
>>>> | #error Unsupported size for type off_t
>>>>
>>>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>>>> ---
>>>> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>> index 191e5a1..109deb0 100644
>>>> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>> @@ -11,6 +11,7 @@
>>>> #define NPY_SIZEOF_PY_INTPTR_T 8
>>>> #define NPY_SIZEOF_PY_LONG_LONG 8
>>>> #define NPY_SIZEOF_LONGLONG 8
>>>> +#define NPY_SIZEOF_OFF_T 8
>>>
>>> Why does the test to select size of off_t fails ?
>> core/include/numpy/npy_common.h
>>
>> #if NPY_SIZEOF_OFF_T == NPY_SIZEOF_SHORT
>> #define NPY_OFF_T_PYFMT "h"
>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_INT
>> #define NPY_OFF_T_PYFMT "i"
>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONG
>> #define NPY_OFF_T_PYFMT "l"
>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONGLONG
>> #define NPY_OFF_T_PYFMT "L"
>> #else
>> #error Unsupported size for type off_t
>> #endif
>>
>> its gotta match one of them. X86-64 has NPY_SIZEOF_OFF_T value set.
>
> yes thats the use of it. i was asking for place where it is set, most probably during configure
>
There is no configure for this python package. It uses hardcoded values
in config.h or _numpyconfig.h per arch. X86-64 has the NPY_SIZEOF_OFF_T
defined in _numpyconfig.h. To keep it consistent, I put the Aarch64
changes in the same place.
- armin
>>
>>
>>> we might need similar fix for mips64 too.
>> yep, I just built mips64 and ppc64 and they both fail like aach64.
>>
>> will send v2 to fix those as well.
>
> OK
>
>>
>> -armin
>>
>>>
>>>> #define NPY_NO_SMP 0
>>>> #define NPY_HAVE_DECL_ISNAN
>>>> #define NPY_HAVE_DECL_ISINF
>>>> --
>>>> 2.3.5
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 3:34 ` akuster808
@ 2016-05-17 3:35 ` Khem Raj
2016-05-17 13:19 ` akuster808
2016-05-17 13:49 ` Burton, Ross
1 sibling, 1 reply; 11+ messages in thread
From: Khem Raj @ 2016-05-17 3:35 UTC (permalink / raw)
To: akuster808; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2907 bytes --]
> On May 16, 2016, at 8:34 PM, akuster808 <akuster808@gmail.com> wrote:
>
> On 5/16/16 8:09 PM, Khem Raj wrote:
>>
>>> On May 16, 2016, at 7:26 PM, akuster808 <akuster808@gmail.com> wrote:
>>>
>>>
>>>
>>> On 05/16/2016 09:44 AM, Khem Raj wrote:
>>>>
>>>>> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>>>>
>>>>> From: Armin Kuster <akuster@mvista.com>
>>>>>
>>>>> numpy/core/include/numpy/npy_common.h:149:10: error:
>>>>> | #error Unsupported size for type off_t
>>>>>
>>>>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>>>>> ---
>>>>> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>>> index 191e5a1..109deb0 100644
>>>>> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>>> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>>> @@ -11,6 +11,7 @@
>>>>> #define NPY_SIZEOF_PY_INTPTR_T 8
>>>>> #define NPY_SIZEOF_PY_LONG_LONG 8
>>>>> #define NPY_SIZEOF_LONGLONG 8
>>>>> +#define NPY_SIZEOF_OFF_T 8
>>>>
>>>> Why does the test to select size of off_t fails ?
>>> core/include/numpy/npy_common.h
>>>
>>> #if NPY_SIZEOF_OFF_T == NPY_SIZEOF_SHORT
>>> #define NPY_OFF_T_PYFMT "h"
>>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_INT
>>> #define NPY_OFF_T_PYFMT "i"
>>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONG
>>> #define NPY_OFF_T_PYFMT "l"
>>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONGLONG
>>> #define NPY_OFF_T_PYFMT "L"
>>> #else
>>> #error Unsupported size for type off_t
>>> #endif
>>>
>>> its gotta match one of them. X86-64 has NPY_SIZEOF_OFF_T value set.
>>
>> yes thats the use of it. i was asking for place where it is set, most probably during configure
>>
>
> There is no configure for this python package. It uses hardcoded values
> in config.h or _numpyconfig.h per arch. X86-64 has the NPY_SIZEOF_OFF_T
> defined in _numpyconfig.h. To keep it consistent, I put the Aarch64
> changes in the same place.
is this config.h or _numpyconfig.h generated too ?
see if thats the case
>
> - armin
>
>>>
>>>
>>>> we might need similar fix for mips64 too.
>>> yep, I just built mips64 and ppc64 and they both fail like aach64.
>>>
>>> will send v2 to fix those as well.
>>
>> OK
>>
>>>
>>> -armin
>>>
>>>>
>>>>> #define NPY_NO_SMP 0
>>>>> #define NPY_HAVE_DECL_ISNAN
>>>>> #define NPY_HAVE_DECL_ISINF
>>>>> --
>>>>> 2.3.5
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core@lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 3:35 ` Khem Raj
@ 2016-05-17 13:19 ` akuster808
2016-05-17 14:22 ` Burton, Ross
0 siblings, 1 reply; 11+ messages in thread
From: akuster808 @ 2016-05-17 13:19 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On 05/16/2016 08:35 PM, Khem Raj wrote:
>
>> On May 16, 2016, at 8:34 PM, akuster808 <akuster808@gmail.com> wrote:
>>
>> On 5/16/16 8:09 PM, Khem Raj wrote:
>>>
>>>> On May 16, 2016, at 7:26 PM, akuster808 <akuster808@gmail.com> wrote:
>>>>
>>>>
>>>>
>>>> On 05/16/2016 09:44 AM, Khem Raj wrote:
>>>>>
>>>>>> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>>>>>
>>>>>> From: Armin Kuster <akuster@mvista.com>
>>>>>>
>>>>>> numpy/core/include/numpy/npy_common.h:149:10: error:
>>>>>> | #error Unsupported size for type off_t
>>>>>>
>>>>>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>>>>>> ---
>>>>>> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
>>>>>> 1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>>>> index 191e5a1..109deb0 100644
>>>>>> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>>>> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>>>>>> @@ -11,6 +11,7 @@
>>>>>> #define NPY_SIZEOF_PY_INTPTR_T 8
>>>>>> #define NPY_SIZEOF_PY_LONG_LONG 8
>>>>>> #define NPY_SIZEOF_LONGLONG 8
>>>>>> +#define NPY_SIZEOF_OFF_T 8
>>>>>
>>>>> Why does the test to select size of off_t fails ?
>>>> core/include/numpy/npy_common.h
>>>>
>>>> #if NPY_SIZEOF_OFF_T == NPY_SIZEOF_SHORT
>>>> #define NPY_OFF_T_PYFMT "h"
>>>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_INT
>>>> #define NPY_OFF_T_PYFMT "i"
>>>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONG
>>>> #define NPY_OFF_T_PYFMT "l"
>>>> #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONGLONG
>>>> #define NPY_OFF_T_PYFMT "L"
>>>> #else
>>>> #error Unsupported size for type off_t
>>>> #endif
>>>>
>>>> its gotta match one of them. X86-64 has NPY_SIZEOF_OFF_T value set.
>>>
>>> yes thats the use of it. i was asking for place where it is set, most probably during configure
>>>
>>
>> There is no configure for this python package. It uses hardcoded values
>> in config.h or _numpyconfig.h per arch. X86-64 has the NPY_SIZEOF_OFF_T
>> defined in _numpyconfig.h. To keep it consistent, I put the Aarch64
>> changes in the same place.
>
> is this config.h or _numpyconfig.h generated too ?
> see if thats the case
Sorry, missed this email last night.
Not sure what you mean by generated. Both config and _numpyconfig.h are
files that reside under an "arch" dir and brought in when building. I
don't know why this needed to be done this way. Don't you recall, you
did a patch for this package too ; ) Maybe Ross remembers, his
fingerprints are all over this package.
- armin
>
>>
>> - armin
>>
>>>>
>>>>
>>>>> we might need similar fix for mips64 too.
>>>> yep, I just built mips64 and ppc64 and they both fail like aach64.
>>>>
>>>> will send v2 to fix those as well.
>>>
>>> OK
>>>
>>>>
>>>> -armin
>>>>
>>>>>
>>>>>> #define NPY_NO_SMP 0
>>>>>> #define NPY_HAVE_DECL_ISNAN
>>>>>> #define NPY_HAVE_DECL_ISINF
>>>>>> --
>>>>>> 2.3.5
>>>>>>
>>>>>> --
>>>>>> _______________________________________________
>>>>>> Openembedded-core mailing list
>>>>>> Openembedded-core@lists.openembedded.org
>>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 3:34 ` akuster808
2016-05-17 3:35 ` Khem Raj
@ 2016-05-17 13:49 ` Burton, Ross
1 sibling, 0 replies; 11+ messages in thread
From: Burton, Ross @ 2016-05-17 13:49 UTC (permalink / raw)
To: akuster808; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On 17 May 2016 at 04:34, akuster808 <akuster808@gmail.com> wrote:
> There is no configure for this python package. It uses hardcoded values
> in config.h or _numpyconfig.h per arch. X86-64 has the NPY_SIZEOF_OFF_T
> defined in _numpyconfig.h. To keep it consistent, I put the Aarch64
> changes in the same place.
>
I hate numpy.
There's also a largefile DISTRO_FEATURE that the recipe should be
respecting...
Ross
[-- Attachment #2: Type: text/html, Size: 888 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 13:19 ` akuster808
@ 2016-05-17 14:22 ` Burton, Ross
2016-05-17 14:57 ` Khem Raj
0 siblings, 1 reply; 11+ messages in thread
From: Burton, Ross @ 2016-05-17 14:22 UTC (permalink / raw)
To: akuster808; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On 17 May 2016 at 14:19, akuster808 <akuster808@gmail.com> wrote:
> Sorry, missed this email last night.
>
> Not sure what you mean by generated. Both config and _numpyconfig.h are
> files that reside under an "arch" dir and brought in when building. I
> don't know why this needed to be done this way. Don't you recall, you
> did a patch for this package too ; ) Maybe Ross remembers, his
> fingerprints are all over this package.
>
I just beat it into submission when it moved from meta-oe to oe-core. The
config and numpyconfig crazy already existed and yes it's hideous but I was
worried about changing something so fundamental.
Ross
[-- Attachment #2: Type: text/html, Size: 1065 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
2016-05-17 14:22 ` Burton, Ross
@ 2016-05-17 14:57 ` Khem Raj
0 siblings, 0 replies; 11+ messages in thread
From: Khem Raj @ 2016-05-17 14:57 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On Tue, May 17, 2016 at 7:22 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 17 May 2016 at 14:19, akuster808 <akuster808@gmail.com> wrote:
>>
>> Sorry, missed this email last night.
>>
>> Not sure what you mean by generated. Both config and _numpyconfig.h are
>> files that reside under an "arch" dir and brought in when building. I
>> don't know why this needed to be done this way. Don't you recall, you
>> did a patch for this package too ; ) Maybe Ross remembers, his
>> fingerprints are all over this package.
>
>
> I just beat it into submission when it moved from meta-oe to oe-core. The
> config and numpyconfig crazy already existed and yes it's hideous but I was
> worried about changing something so fundamental.
Thats fine. I was just wondering if we are caching things which could
some how be generated.
>
> Ross
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-05-17 14:57 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-16 16:17 [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib Armin Kuster
2016-05-16 16:44 ` Khem Raj
2016-05-17 2:26 ` akuster808
2016-05-17 3:09 ` Khem Raj
2016-05-17 3:16 ` akuster808
2016-05-17 3:34 ` akuster808
2016-05-17 3:35 ` Khem Raj
2016-05-17 13:19 ` akuster808
2016-05-17 14:22 ` Burton, Ross
2016-05-17 14:57 ` Khem Raj
2016-05-17 13:49 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.