From: Guenter Roeck <linux@roeck-us.net>
To: "Yong, Jonathan" <jonathan.yong@intel.com>,
linux-watchdog@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Cc: qipeng.zha@intel.com
Subject: Re: [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver
Date: Wed, 18 May 2016 07:37:00 -0700 [thread overview]
Message-ID: <573C7E0C.7050304@roeck-us.net> (raw)
In-Reply-To: <573BF421.2020503@intel.com>
On 05/17/2016 09:48 PM, Yong, Jonathan wrote:
> On 05/18/2016 12:03, Guenter Roeck wrote:
>> On 05/17/2016 08:26 PM, Yong, Jonathan wrote:
>>> The TCO I/O base is 40h rather than the usual 30h, and the
>>> re_reboot bit is at ACPIBASE+8.
>>>
>>
>> Does this mean that the code never worked, or in other words that it
>> was never tested, or are there now other chips which used the old
>> definitions which no longer work after this patch has been applied ?
>
> To my knowledge, it has never worked since 30h is claimed by ACPI GPE0_BLK.
>
Hmm.. Darren will have to take that one. I am not in a position to
determine if the new patch is correct or not, and/or if it causes some
other platform/architecture to fail. I'll Ack the other patch, and
would suggest for Darren to take it as well to keep the two patches together.
Guenter
> With this patch, watchdog ioctl is working properly with WDIOC_SETTIMEOUT, WDIOC_GETTIMEOUT and WDIOC_GETTIMELEFT as expected.
>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: "Yong,
Jonathan" <jonathan.yong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: qipeng.zha-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver
Date: Wed, 18 May 2016 07:37:00 -0700 [thread overview]
Message-ID: <573C7E0C.7050304@roeck-us.net> (raw)
In-Reply-To: <573BF421.2020503-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On 05/17/2016 09:48 PM, Yong, Jonathan wrote:
> On 05/18/2016 12:03, Guenter Roeck wrote:
>> On 05/17/2016 08:26 PM, Yong, Jonathan wrote:
>>> The TCO I/O base is 40h rather than the usual 30h, and the
>>> re_reboot bit is at ACPIBASE+8.
>>>
>>
>> Does this mean that the code never worked, or in other words that it
>> was never tested, or are there now other chips which used the old
>> definitions which no longer work after this patch has been applied ?
>
> To my knowledge, it has never worked since 30h is claimed by ACPI GPE0_BLK.
>
Hmm.. Darren will have to take that one. I am not in a position to
determine if the new patch is correct or not, and/or if it causes some
other platform/architecture to fail. I'll Ack the other patch, and
would suggest for Darren to take it as well to keep the two patches together.
Guenter
> With this patch, watchdog ioctl is working properly with WDIOC_SETTIMEOUT, WDIOC_GETTIMEOUT and WDIOC_GETTIMELEFT as expected.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-18 14:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 3:26 [PATCH 0/2] Correct iTCO Watchdog for Apollo Lake Yong, Jonathan
2016-05-18 3:26 ` Yong, Jonathan
2016-05-18 3:26 ` [PATCH 1/2] watchdog: iTCO-wdt handle 5th variation " Yong, Jonathan
2016-05-18 14:37 ` Guenter Roeck
2016-05-18 3:26 ` [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver Yong, Jonathan
2016-05-18 3:26 ` Yong, Jonathan
2016-05-18 4:03 ` Guenter Roeck
2016-05-18 4:03 ` Guenter Roeck
2016-05-18 4:48 ` Yong, Jonathan
2016-05-18 14:37 ` Guenter Roeck [this message]
2016-05-18 14:37 ` Guenter Roeck
2016-05-24 20:13 ` Darren Hart
2016-05-24 20:13 ` Darren Hart
2016-05-25 7:55 ` Yong, Jonathan
2016-05-25 7:55 ` Yong, Jonathan
2016-06-02 8:28 ` Yong, Jonathan
2016-06-02 8:28 ` Yong, Jonathan
2016-06-07 22:03 ` Darren Hart
2016-06-13 4:42 ` Yong, Jonathan
2016-06-13 4:42 ` Yong, Jonathan
2016-06-17 0:33 ` [PATCH v2 0/2] Correct iTCO Watchdog for Apollo Lake Yong, Jonathan
2016-06-17 0:33 ` [PATCH v2 1/2] watchdog: iTCO-wdt handle 5th variation " Yong, Jonathan
2016-06-23 13:39 ` Guenter Roeck
2016-06-17 0:33 ` [PATCH v2 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver Yong, Jonathan
2016-06-17 0:33 ` Yong, Jonathan
2016-06-23 13:39 ` Guenter Roeck
2016-07-17 20:16 ` [PATCH v2 0/2] Correct iTCO Watchdog for Apollo Lake Wim Van Sebroeck
2016-07-17 20:16 ` Wim Van Sebroeck
2016-07-18 0:00 ` Yong, Jonathan
2016-06-17 0:36 ` Yong, Jonathan
2016-06-17 0:36 ` [PATCH v2 1/2] watchdog: iTCO-wdt handle 5th variation " Yong, Jonathan
2016-06-17 0:36 ` [PATCH v2 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver Yong, Jonathan
2016-06-22 4:53 ` [PATCH v2 0/2] Correct iTCO Watchdog for Apollo Lake Yong, Jonathan
2016-06-22 4:53 ` Yong, Jonathan
2016-06-22 6:01 ` Guenter Roeck
2016-06-23 5:02 ` Darren Hart
2016-06-23 5:02 ` Darren Hart
2016-06-23 13:37 ` Guenter Roeck
2016-06-23 13:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573C7E0C.7050304@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jonathan.yong@intel.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.