From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: echi-hcd: Add register access check in shutdown
Date: Wed, 18 May 2016 18:57:46 +0100 [thread overview]
Message-ID: <573CAD1A.4090805@linaro.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1605181044460.1981-100000@iolanthe.rowland.org>
On 18/05/16 15:56, Alan Stern wrote:
> This doesn't seem like the right place. What you really should do is
> skip calling ehci_silence_controller() if the hardware isn't
> accessible. That's where the hardware gets touched, not in
> ehci_shutdown().
Just tried this suggestion, this would not work as well, Its not just
the hardware registers, which are of concern here, but also the rest of
the things like ehci->hrtimer pointer which are allocated or initialized
as part of ehci_setup().
Either the msm controller driver is not correct or we should have a way
to stop calling ehci_shutdown() if there was no ehci_setup() done yet.
Any suggestions?
--srini
WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
andy.gross@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: echi-hcd: Add register access check in shutdown
Date: Wed, 18 May 2016 18:57:46 +0100 [thread overview]
Message-ID: <573CAD1A.4090805@linaro.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1605181044460.1981-100000@iolanthe.rowland.org>
On 18/05/16 15:56, Alan Stern wrote:
> This doesn't seem like the right place. What you really should do is
> skip calling ehci_silence_controller() if the hardware isn't
> accessible. That's where the hardware gets touched, not in
> ehci_shutdown().
Just tried this suggestion, this would not work as well, Its not just
the hardware registers, which are of concern here, but also the rest of
the things like ehci->hrtimer pointer which are allocated or initialized
as part of ehci_setup().
Either the msm controller driver is not correct or we should have a way
to stop calling ehci_shutdown() if there was no ehci_setup() done yet.
Any suggestions?
--srini
next prev parent reply other threads:[~2016-05-18 17:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 14:12 [PATCH] usb: echi-hcd: Add register access check in shutdown Srinivas Kandagatla
2016-05-18 14:12 ` Srinivas Kandagatla
2016-05-18 14:56 ` Alan Stern
2016-05-18 14:56 ` Alan Stern
2016-05-18 15:33 ` Srinivas Kandagatla
2016-05-18 15:33 ` Srinivas Kandagatla
2016-05-18 16:15 ` Alan Stern
2016-05-18 16:15 ` Alan Stern
2016-05-18 17:06 ` Srinivas Kandagatla
2016-05-18 17:06 ` Srinivas Kandagatla
2016-05-18 17:57 ` Srinivas Kandagatla [this message]
2016-05-18 17:57 ` Srinivas Kandagatla
2016-05-18 18:54 ` Alan Stern
2016-05-18 18:54 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573CAD1A.4090805@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.