From: Hongxu Jia <hongxu.jia@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Cc: koen.kooi@linaro.org
Subject: Re: [PATCH V6] efivar: fix unknown option while gold linker used
Date: Thu, 19 May 2016 09:36:44 +0800 [thread overview]
Message-ID: <573D18AC.6020203@windriver.com> (raw)
In-Reply-To: <20160517153542.GC2559@jama>
On 05/17/2016 11:35 PM, Martin Jansa wrote:
> On Tue, May 17, 2016 at 11:28:32PM +0800, Hongxu Jia wrote:
>> Ping Martin,
>>
>> Could you apply the V6? It should be ok with gold linker
> I think it's already in master-next and will be merged after next round
> of world builds.
>
Many thanks
//Hongxu
>> //Hongxu
>>
>> On 05/11/2016 09:39 AM, Hongxu Jia wrote:
>>> - Use '-fPIC' to replace 'PIC';
>>>
>>> - Use 'pie' to replace 'PIE'
>>>
>>> - Remove unknown '--add-needed'
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>> ---
>>> .../0004-fix-unknow-option-for-gold-linker.patch | 38 ++++++++++++++++++++++
>>> meta-oe/recipes-extended/efivar/efivar_0.23.bb | 1 +
>>> 2 files changed, 39 insertions(+)
>>> create mode 100644 meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch
>>>
>>> diff --git a/meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch b/meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch
>>> new file mode 100644
>>> index 0000000..5d50c19
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-extended/efivar/efivar/0004-fix-unknow-option-for-gold-linker.patch
>>> @@ -0,0 +1,38 @@
>>> +From b3d35e7dd27a755df5acbe050837885914dbb28b Mon Sep 17 00:00:00 2001
>>> +From: Hongxu Jia <hongxu.jia@windriver.com>
>>> +Date: Tue, 10 May 2016 11:34:50 -0400
>>> +Subject: [PATCH] fix unknow option for gold linker
>>> +
>>> +- Revert the following patch, since oe-core work with gcc 5
>>> +...
>>> +commit 3055a3797f16693dfdd855fa68bc57fd900dc408
>>> +Author: Peter Jones <pjones@redhat.com>
>>> +Date: Mon Feb 15 14:15:40 2016 -0500
>>> +
>>> + Make gcc.specs work with gcc 6 / binutils 2.26
>>> +
>>> + Apparently binutils 2.26 gets real picky about "ld -PIC" vs "ld -fPIC".
>>> +
>>> + Signed-off-by: Peter Jones <pjones@redhat.com>
>>> +...
>>> +
>>> +- Remove unknown option '--add-needed'
>>> +
>>> +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>> +---
>>> + gcc.specs | 2 +-
>>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>>> +
>>> +diff --git a/gcc.specs b/gcc.specs
>>> +index 24fabc2..5b0fdef 100644
>>> +--- a/gcc.specs
>>> ++++ b/gcc.specs
>>> +@@ -14,4 +14,4 @@
>>> + + %{!shared:%{!static:%{!r:-pie}}} %{static:-Wl,-no-fatal-warnings -Wl,-static -static -Wl,-z,relro,-z,now}
>>> +
>>> + *link:
>>> +-+ %{!static:--fatal-warnings} --no-undefined-version --no-allow-shlib-undefined --add-needed -z now --build-id %{!static:%{!shared:-PIE}} %{shared:-z relro -PIC} %{static:%<pie}
>>> +++ %{!static:--fatal-warnings} --no-undefined-version --no-allow-shlib-undefined -z now --build-id %{!static:%{!shared:-pie}} %{shared:-z relro -fPIC} %{static:%<pie}
>>> +--
>>> +2.8.1
>>> +
>>> diff --git a/meta-oe/recipes-extended/efivar/efivar_0.23.bb b/meta-oe/recipes-extended/efivar/efivar_0.23.bb
>>> index 9c47461..6e9a51f 100644
>>> --- a/meta-oe/recipes-extended/efivar/efivar_0.23.bb
>>> +++ b/meta-oe/recipes-extended/efivar/efivar_0.23.bb
>>> @@ -12,6 +12,7 @@ SRC_URI = "git://github.com/rhinstaller/efivar.git"
>>> SRC_URI_append_class-target = " file://0001-efivar-fix-for-cross-compile.patch \
>>> file://0002-disable-static-build.patch \
>>> file://0003-efivar-fix-for-cross-compile.patch \
>>> + file://0004-fix-unknow-option-for-gold-linker.patch \
>>> "
>>>
>>> S = "${WORKDIR}/git"
>
>
prev parent reply other threads:[~2016-05-19 1:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 16:19 [PATCH V5 0/5] efivar: upgrade to 0.23 Hongxu Jia
2016-05-10 16:19 ` [PATCH 1/5] efivar: update " Hongxu Jia
2016-05-10 16:19 ` [PATCH 2/5] efibootmgr: update and unblacklist Hongxu Jia
2016-05-10 16:19 ` [PATCH 3/5] efivar: fix do_install failed Hongxu Jia
2016-05-10 16:19 ` [PATCH 4/5] efibootmgr: sync with upstream while efivar upgraded to 0.23 Hongxu Jia
2016-05-10 16:19 ` [PATCH 5/5] efivar: fix unknown option while gold linker used Hongxu Jia
2016-05-10 21:10 ` [PATCH V5 0/5] efivar: upgrade to 0.23 Martin Jansa
2016-05-11 1:33 ` Hongxu Jia
2016-05-11 1:39 ` [PATCH V6] efivar: fix unknown option while gold linker used Hongxu Jia
2016-05-17 15:28 ` Hongxu Jia
2016-05-17 15:35 ` Martin Jansa
2016-05-19 1:36 ` Hongxu Jia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573D18AC.6020203@windriver.com \
--to=hongxu.jia@windriver.com \
--cc=koen.kooi@linaro.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.