Re: [patch added to 3.12-stable] netem: Segment GSO packets on enqueue

[Jiri Slaby <jslaby@suse.cz>]

On 05/18/2016, 06:04 PM, Eric Dumazet wrote:
> On Wed, 2016-05-18 at 16:59 +0200, Jiri Slaby wrote:
>> On 05/18/2016, 04:54 PM, Eric Dumazet wrote:
> 
>>> ... But qdisc_tree_reduce_backlog() was not there in 3.12
>>
>> Yeah, but I pulled the series from net_41 including the
>> qdisc_tree_reduce_backlog backport.
> 
> 
> Only for this backport ? Seems risky.
> 
> I would have use qdisc_tree_decrease_qlen(sch, 1 - nb); here.

Hmm, this looks sensible, indeed. Now I am thinking if there was other
reason to backport the machinery to 4.1-stable?

>>>> +		if (nb > 1)
>>>> +			qdisc_tree_reduce_backlog(sch, 1 - nb, prev_len - len);
>>>> +	}
>>>>  	return NET_XMIT_SUCCESS;
>>>>  }
>>
>> thanks,
-- 
js
suse labs