From: Julien Grall <julien.grall@arm.com>
To: Peng Fan <van.freenix@gmail.com>, sstabellini@kernel.org
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary
Date: Thu, 19 May 2016 11:36:31 +0100 [thread overview]
Message-ID: <573D972F.5010101@arm.com> (raw)
In-Reply-To: <1463649727-18510-1-git-send-email-van.freenix@gmail.com>
Hi Peng,
On 19/05/16 10:22, Peng Fan wrote:
> CPU0 boots up secondary CPUs one by one. Before booting
> one secondary CPU, CPU0 will assign hwid to smp_up_cpu
> and flush cache. After the secondary CPU boots up,
NIT: s/the/a/
> CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush
> cache.
>
> There is no need for secondary CPUs to assign MPIDR_INVALID
> to smp_up_cpu. So, drop it.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Julien Grall <julien.grall@arm.com>
Regards,
> ---
> xen/arch/arm/smpboot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index c5109bf..6b3c157 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset,
> smp_wmb();
>
> /* Now report this CPU is up */
> - smp_up_cpu = MPIDR_INVALID;
> cpumask_set_cpu(cpuid, &cpu_online_map);
> smp_wmb();
>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-19 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 9:22 [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary Peng Fan
2016-05-19 10:36 ` Julien Grall [this message]
2016-05-19 10:41 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573D972F.5010101@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.