* [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary
@ 2016-05-19 9:22 Peng Fan
2016-05-19 10:36 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan @ 2016-05-19 9:22 UTC (permalink / raw)
To: julien.grall, sstabellini; +Cc: van.freenix, xen-devel
CPU0 boots up secondary CPUs one by one. Before booting
one secondary CPU, CPU0 will assign hwid to smp_up_cpu
and flush cache. After the secondary CPU boots up,
CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush
cache.
There is no need for secondary CPUs to assign MPIDR_INVALID
to smp_up_cpu. So, drop it.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
xen/arch/arm/smpboot.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index c5109bf..6b3c157 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset,
smp_wmb();
/* Now report this CPU is up */
- smp_up_cpu = MPIDR_INVALID;
cpumask_set_cpu(cpuid, &cpu_online_map);
smp_wmb();
--
2.6.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary
2016-05-19 9:22 [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary Peng Fan
@ 2016-05-19 10:36 ` Julien Grall
2016-05-19 10:41 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2016-05-19 10:36 UTC (permalink / raw)
To: Peng Fan, sstabellini; +Cc: xen-devel
Hi Peng,
On 19/05/16 10:22, Peng Fan wrote:
> CPU0 boots up secondary CPUs one by one. Before booting
> one secondary CPU, CPU0 will assign hwid to smp_up_cpu
> and flush cache. After the secondary CPU boots up,
NIT: s/the/a/
> CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush
> cache.
>
> There is no need for secondary CPUs to assign MPIDR_INVALID
> to smp_up_cpu. So, drop it.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Julien Grall <julien.grall@arm.com>
Regards,
> ---
> xen/arch/arm/smpboot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index c5109bf..6b3c157 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset,
> smp_wmb();
>
> /* Now report this CPU is up */
> - smp_up_cpu = MPIDR_INVALID;
> cpumask_set_cpu(cpuid, &cpu_online_map);
> smp_wmb();
>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary
2016-05-19 10:36 ` Julien Grall
@ 2016-05-19 10:41 ` Stefano Stabellini
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2016-05-19 10:41 UTC (permalink / raw)
To: Julien Grall; +Cc: Peng Fan, sstabellini, xen-devel
On Thu, 19 May 2016, Julien Grall wrote:
> Hi Peng,
>
> On 19/05/16 10:22, Peng Fan wrote:
> > CPU0 boots up secondary CPUs one by one. Before booting
> > one secondary CPU, CPU0 will assign hwid to smp_up_cpu
> > and flush cache. After the secondary CPU boots up,
>
> NIT: s/the/a/
>
> > CPU0 will assign MPIDR_INVALID to smp_up_cpu and flush
> > cache.
> >
> > There is no need for secondary CPUs to assign MPIDR_INVALID
> > to smp_up_cpu. So, drop it.
> >
> > Signed-off-by: Peng Fan <van.freenix@gmail.com>
> > Cc: Julien Grall <julien.grall@arm.com>
> > Cc: Stefano Stabellini <sstabellini@kernel.org>
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
This is a cleanup, no need to commit it now. I'll add it to the 4.8
branch.
>
> > ---
> > xen/arch/arm/smpboot.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> > index c5109bf..6b3c157 100644
> > --- a/xen/arch/arm/smpboot.c
> > +++ b/xen/arch/arm/smpboot.c
> > @@ -309,7 +309,6 @@ void start_secondary(unsigned long boot_phys_offset,
> > smp_wmb();
> >
> > /* Now report this CPU is up */
> > - smp_up_cpu = MPIDR_INVALID;
> > cpumask_set_cpu(cpuid, &cpu_online_map);
> > smp_wmb();
> >
> >
>
> --
> Julien Grall
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-19 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-19 9:22 [PATCH] xen/arm: smpboot: drop unneeded code in start_secondary Peng Fan
2016-05-19 10:36 ` Julien Grall
2016-05-19 10:41 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.