diff for duplicates of <573DB180.9030200@atmel.com> diff --git a/a/1.txt b/N1/1.txt index f5bf15f..8d4d8c3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,14 @@ -Le 19/05/2016 01:29, Rob Herring a ?crit : +Le 19/05/2016 01:29, Rob Herring a écrit : > On Wed, May 18, 2016 at 06:02:46PM +0530, Raashid Muhammed wrote: ->> From: Raashid Muhammed <raashidmuhammed@zilogic.com> +>> From: Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org> >> >> sam9-l9260 is a low cost board designed by Olimex. >> >> More infomation is available at: >> https://www.olimex.com/Products/ARM/Atmel/SAM9-L9260/ >> ->> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com> ->> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org> +>> Signed-off-by: Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org> +>> Reviewed-by: Vijay Kumar B. <vijaykumar-NDm7FNP0skFg9hUCZPvPmw@public.gmane.org> >> --- >> .../devicetree/bindings/arm/olimex-at91.txt | 6 ++ >> arch/arm/boot/dts/Makefile | 1 + @@ -71,7 +71,7 @@ Ditto about the file name. >> +/* >> + * sam9-l9260.dts - Device Tree file for Olimex SAM9-L9260 board >> + * ->> + * Copyright (C) 2016 Raashid Muhammed <raashidmuhammed@zilogic.com> +>> + * Copyright (C) 2016 Raashid Muhammed <raashidmuhammed-1MQmoylvZ5WIwRZHo2/mJg@public.gmane.orgm> >> + * >> + * Licensed under GPLv2 or later. >> + */ @@ -109,20 +109,20 @@ http://lxr.free-electrons.com/source/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> + >> + ahb { >> + apb { ->> + dbgu: serial at fffff200 { +>> + dbgu: serial@fffff200 { We like to sort node by their address: can you rearrange them like this? >> + status = "okay"; >> + }; >> + ->> + macb0: ethernet at fffc4000 { +>> + macb0: ethernet@fffc4000 { >> + phy-mode = "mii"; >> + status = "okay"; I advice you to add the phy address for any Ethernet interface like: - phy0: ethernet-phy at 1 { + phy0: ethernet-phy@1 { reg = <1>; }; @@ -131,28 +131,28 @@ for a phy address configured as 0x1. >> + }; >> + ->> + spi0: spi at fffc8000 { +>> + spi0: spi@fffc8000 { >> + status = "okay"; Nitpicking: "status" property is usually the last one of the node (before the child nodes if they exist) >> + cs-gpios = <&pioC 11 0>, <0>, <0>, <0>; ->> + mtd_dataflash at 0 { +>> + mtd_dataflash@0 { >> + compatible = "atmel,at45", "atmel,dataflash"; >> + spi-max-frequency = <15000000>; >> + reg = <0>; >> + }; >> + }; >> + ->> + mmc0: mmc at fffa8000 { +>> + mmc0: mmc@fffa8000 { >> + pinctrl-0 = < >> + &pinctrl_board_mmc0 >> + &pinctrl_mmc0_clk >> + &pinctrl_mmc0_slot1_cmd_dat0 >> + &pinctrl_mmc0_slot1_dat1_3>; >> + status = "okay"; ->> + slot at 1 { +>> + slot@1 { >> + reg = <1>; >> + bus-width = <4>; >> + cd-gpios = <&pioC 8 GPIO_ACTIVE_HIGH>; @@ -160,7 +160,7 @@ Nitpicking: "status" property is usually the last one of the node >> + }; >> + }; >> + ->> + pinctrl at fffff400 { +>> + pinctrl@fffff400 { >> + mmc0 { >> + pinctrl_board_mmc0: mmc0-board { >> + atmel,pins = @@ -177,14 +177,14 @@ keep useful "CD" or "WP" information. >> + >> + }; >> + ->> + usb0: ohci at 00500000 { +>> + usb0: ohci@00500000 { > > Drop the leading 0. You'll need to fixup the base dts. > >> + status = "okay"; >> + }; >> + ->> + nand0: nand at 40000000 { +>> + nand0: nand@40000000 { >> + nand-bus-width = <8>; >> + nand-ecc-mode = "soft"; >> + nand-on-flash-bbt = <1>; @@ -192,7 +192,7 @@ keep useful "CD" or "WP" information. >> + }; >> + }; >> + ->> + i2c at 0 { +>> + i2c@0 { >> + status = "okay"; >> + }; >> + @@ -216,3 +216,7 @@ for this Olimex board! Bye, -- Nicolas Ferre +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 0f9f449..e8eae8d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,32 @@ "ref\01463574766-15568-1-git-send-email-raashidmuhammed@zilogic.com\0" "ref\020160518232925.GA6545@rob-hp-laptop\0" - "From\0nicolas.ferre@atmel.com (Nicolas Ferre)\0" - "Subject\0[PATCH] ARM: at91: Add DT support for Olimex SAM9-L9260 board.\0" + "From\0Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>\0" + "Subject\0Re: [PATCH] ARM: at91: Add DT support for Olimex SAM9-L9260 board.\0" "Date\0Thu, 19 May 2016 14:28:48 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>" + " Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org>\0" + "Cc\0pawel.moll-5wv7dgnIgG8@public.gmane.org" + mark.rutland-5wv7dgnIgG8@public.gmane.org + ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org + galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org + linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org + vijaykumar-NDm7FNP0skFg9hUCZPvPmw@public.gmane.org + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" "\00:1\0" "b\0" - "Le 19/05/2016 01:29, Rob Herring a ?crit :\n" + "Le 19/05/2016 01:29, Rob Herring a \303\251crit :\n" "> On Wed, May 18, 2016 at 06:02:46PM +0530, Raashid Muhammed wrote:\n" - ">> From: Raashid Muhammed <raashidmuhammed@zilogic.com>\n" + ">> From: Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org>\n" ">>\n" ">> sam9-l9260 is a low cost board designed by Olimex.\n" ">>\n" ">> More infomation is available at:\n" ">> https://www.olimex.com/Products/ARM/Atmel/SAM9-L9260/\n" ">>\n" - ">> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>\n" - ">> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>\n" + ">> Signed-off-by: Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org>\n" + ">> Reviewed-by: Vijay Kumar B. <vijaykumar-NDm7FNP0skFg9hUCZPvPmw@public.gmane.org>\n" ">> ---\n" ">> .../devicetree/bindings/arm/olimex-at91.txt | 6 ++\n" ">> arch/arm/boot/dts/Makefile | 1 +\n" @@ -79,7 +89,7 @@ ">> +/*\n" ">> + * sam9-l9260.dts - Device Tree file for Olimex SAM9-L9260 board\n" ">> + *\n" - ">> + * Copyright (C) 2016 Raashid Muhammed <raashidmuhammed@zilogic.com>\n" + ">> + * Copyright (C) 2016 Raashid Muhammed <raashidmuhammed-1MQmoylvZ5WIwRZHo2/mJg@public.gmane.orgm>\n" ">> + *\n" ">> + * Licensed under GPLv2 or later.\n" ">> + */\n" @@ -117,20 +127,20 @@ ">> +\n" ">> +\t ahb {\n" ">> +\t\tapb {\n" - ">> +\t\t\tdbgu: serial at fffff200 {\n" + ">> +\t\t\tdbgu: serial@fffff200 {\n" "\n" "We like to sort node by their address: can you rearrange them like this?\n" "\n" ">> +\t\t\t\tstatus = \"okay\";\n" ">> +\t\t\t };\n" ">> +\n" - ">> +\t\t\tmacb0: ethernet at fffc4000 {\n" + ">> +\t\t\tmacb0: ethernet@fffc4000 {\n" ">> +\t\t\t\tphy-mode = \"mii\";\n" ">> +\t\t\t\tstatus = \"okay\";\n" "\n" "I advice you to add the phy address for any Ethernet interface like:\n" "\n" - " phy0: ethernet-phy at 1 {\n" + " phy0: ethernet-phy@1 {\n" " reg = <1>;\n" " };\n" "\n" @@ -139,28 +149,28 @@ "\n" ">> +\t\t\t };\n" ">> +\n" - ">> +\t\t\tspi0: spi at fffc8000 {\n" + ">> +\t\t\tspi0: spi@fffc8000 {\n" ">> +\t\t\t\tstatus = \"okay\";\n" "\n" "Nitpicking: \"status\" property is usually the last one of the node\n" "(before the child nodes if they exist)\n" "\n" ">> +\t\t\t\tcs-gpios = <&pioC 11 0>, <0>, <0>, <0>;\n" - ">> +\t\t\t\tmtd_dataflash at 0 {\n" + ">> +\t\t\t\tmtd_dataflash@0 {\n" ">> +\t\t\t\t\tcompatible = \"atmel,at45\", \"atmel,dataflash\";\n" ">> +\t\t\t\t\tspi-max-frequency = <15000000>;\n" ">> +\t\t\t\t\treg = <0>;\n" ">> +\t\t\t\t};\n" ">> +\t\t\t};\n" ">> +\n" - ">> +\t\t\tmmc0: mmc at fffa8000 {\n" + ">> +\t\t\tmmc0: mmc@fffa8000 {\n" ">> +\t\t\t\tpinctrl-0 = <\n" ">> +\t\t\t\t\t&pinctrl_board_mmc0\n" ">> +\t\t\t\t\t&pinctrl_mmc0_clk\n" ">> +\t\t\t\t\t&pinctrl_mmc0_slot1_cmd_dat0\n" ">> +\t\t\t\t\t&pinctrl_mmc0_slot1_dat1_3>;\n" ">> +\t\t\t\tstatus = \"okay\";\n" - ">> +\t\t\t\tslot at 1 {\n" + ">> +\t\t\t\tslot@1 {\n" ">> +\t\t\t\t\treg = <1>;\n" ">> +\t\t\t\t\tbus-width = <4>;\n" ">> +\t\t\t\t\tcd-gpios = <&pioC 8 GPIO_ACTIVE_HIGH>;\n" @@ -168,7 +178,7 @@ ">> +\t\t\t\t};\n" ">> +\t\t\t};\n" ">> +\n" - ">> +\t\t\tpinctrl at fffff400 {\n" + ">> +\t\t\tpinctrl@fffff400 {\n" ">> +\t\t\t\tmmc0 {\n" ">> +\t\t\t\t\tpinctrl_board_mmc0: mmc0-board {\n" ">> +\t\t\t\t\t\tatmel,pins =\n" @@ -185,14 +195,14 @@ ">> +\n" ">> +\t\t };\n" ">> +\n" - ">> +\t\t usb0: ohci at 00500000 {\n" + ">> +\t\t usb0: ohci@00500000 {\n" "> \n" "> Drop the leading 0. You'll need to fixup the base dts.\n" "> \n" ">> +\t\t status = \"okay\";\n" ">> +\t\t };\n" ">> +\n" - ">> +\t\t nand0: nand at 40000000 {\n" + ">> +\t\t nand0: nand@40000000 {\n" ">> +\t\t nand-bus-width = <8>;\n" ">> +\t\t nand-ecc-mode = \"soft\";\n" ">> +\t\t nand-on-flash-bbt = <1>;\n" @@ -200,7 +210,7 @@ ">> +\t\t };\n" ">> +\t };\n" ">> +\n" - ">> +\t i2c at 0 {\n" + ">> +\t i2c@0 {\n" ">> +\t\tstatus = \"okay\";\n" ">> +\t };\n" ">> +\n" @@ -223,6 +233,10 @@ "\n" "Bye,\n" "-- \n" - Nicolas Ferre + "Nicolas Ferre\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -aba71b5eb9ffce800fa5a6ecaba6be9291952cc51efd0ed4fbdd8a835ed2889f +ca6190743597b5a30fe308896efd680d318c24721f7e49f005b37c61ab18d198
diff --git a/a/1.txt b/N2/1.txt index f5bf15f..32b5fe9 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,4 +1,4 @@ -Le 19/05/2016 01:29, Rob Herring a ?crit : +Le 19/05/2016 01:29, Rob Herring a écrit : > On Wed, May 18, 2016 at 06:02:46PM +0530, Raashid Muhammed wrote: >> From: Raashid Muhammed <raashidmuhammed@zilogic.com> >> @@ -109,20 +109,20 @@ http://lxr.free-electrons.com/source/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> + >> + ahb { >> + apb { ->> + dbgu: serial at fffff200 { +>> + dbgu: serial@fffff200 { We like to sort node by their address: can you rearrange them like this? >> + status = "okay"; >> + }; >> + ->> + macb0: ethernet at fffc4000 { +>> + macb0: ethernet@fffc4000 { >> + phy-mode = "mii"; >> + status = "okay"; I advice you to add the phy address for any Ethernet interface like: - phy0: ethernet-phy at 1 { + phy0: ethernet-phy@1 { reg = <1>; }; @@ -131,28 +131,28 @@ for a phy address configured as 0x1. >> + }; >> + ->> + spi0: spi at fffc8000 { +>> + spi0: spi@fffc8000 { >> + status = "okay"; Nitpicking: "status" property is usually the last one of the node (before the child nodes if they exist) >> + cs-gpios = <&pioC 11 0>, <0>, <0>, <0>; ->> + mtd_dataflash at 0 { +>> + mtd_dataflash@0 { >> + compatible = "atmel,at45", "atmel,dataflash"; >> + spi-max-frequency = <15000000>; >> + reg = <0>; >> + }; >> + }; >> + ->> + mmc0: mmc at fffa8000 { +>> + mmc0: mmc@fffa8000 { >> + pinctrl-0 = < >> + &pinctrl_board_mmc0 >> + &pinctrl_mmc0_clk >> + &pinctrl_mmc0_slot1_cmd_dat0 >> + &pinctrl_mmc0_slot1_dat1_3>; >> + status = "okay"; ->> + slot at 1 { +>> + slot@1 { >> + reg = <1>; >> + bus-width = <4>; >> + cd-gpios = <&pioC 8 GPIO_ACTIVE_HIGH>; @@ -160,7 +160,7 @@ Nitpicking: "status" property is usually the last one of the node >> + }; >> + }; >> + ->> + pinctrl at fffff400 { +>> + pinctrl@fffff400 { >> + mmc0 { >> + pinctrl_board_mmc0: mmc0-board { >> + atmel,pins = @@ -177,14 +177,14 @@ keep useful "CD" or "WP" information. >> + >> + }; >> + ->> + usb0: ohci at 00500000 { +>> + usb0: ohci@00500000 { > > Drop the leading 0. You'll need to fixup the base dts. > >> + status = "okay"; >> + }; >> + ->> + nand0: nand at 40000000 { +>> + nand0: nand@40000000 { >> + nand-bus-width = <8>; >> + nand-ecc-mode = "soft"; >> + nand-on-flash-bbt = <1>; @@ -192,7 +192,7 @@ keep useful "CD" or "WP" information. >> + }; >> + }; >> + ->> + i2c at 0 { +>> + i2c@0 { >> + status = "okay"; >> + }; >> + diff --git a/a/content_digest b/N2/content_digest index 0f9f449..1508531 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,12 +1,22 @@ "ref\01463574766-15568-1-git-send-email-raashidmuhammed@zilogic.com\0" "ref\020160518232925.GA6545@rob-hp-laptop\0" - "From\0nicolas.ferre@atmel.com (Nicolas Ferre)\0" - "Subject\0[PATCH] ARM: at91: Add DT support for Olimex SAM9-L9260 board.\0" + "From\0Nicolas Ferre <nicolas.ferre@atmel.com>\0" + "Subject\0Re: [PATCH] ARM: at91: Add DT support for Olimex SAM9-L9260 board.\0" "Date\0Thu, 19 May 2016 14:28:48 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Rob Herring <robh@kernel.org>" + " Raashid Muhammed <raashidmuhammed@zilogic.com>\0" + "Cc\0<pawel.moll@arm.com>" + <mark.rutland@arm.com> + <ijc+devicetree@hellion.org.uk> + <galak@codeaurora.org> + <linux@armlinux.org.uk> + <vijaykumar@bravegnu.org> + <devicetree@vger.kernel.org> + <linux-kernel@vger.kernel.org> + " <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" - "Le 19/05/2016 01:29, Rob Herring a ?crit :\n" + "Le 19/05/2016 01:29, Rob Herring a \303\251crit :\n" "> On Wed, May 18, 2016 at 06:02:46PM +0530, Raashid Muhammed wrote:\n" ">> From: Raashid Muhammed <raashidmuhammed@zilogic.com>\n" ">>\n" @@ -117,20 +127,20 @@ ">> +\n" ">> +\t ahb {\n" ">> +\t\tapb {\n" - ">> +\t\t\tdbgu: serial at fffff200 {\n" + ">> +\t\t\tdbgu: serial@fffff200 {\n" "\n" "We like to sort node by their address: can you rearrange them like this?\n" "\n" ">> +\t\t\t\tstatus = \"okay\";\n" ">> +\t\t\t };\n" ">> +\n" - ">> +\t\t\tmacb0: ethernet at fffc4000 {\n" + ">> +\t\t\tmacb0: ethernet@fffc4000 {\n" ">> +\t\t\t\tphy-mode = \"mii\";\n" ">> +\t\t\t\tstatus = \"okay\";\n" "\n" "I advice you to add the phy address for any Ethernet interface like:\n" "\n" - " phy0: ethernet-phy at 1 {\n" + " phy0: ethernet-phy@1 {\n" " reg = <1>;\n" " };\n" "\n" @@ -139,28 +149,28 @@ "\n" ">> +\t\t\t };\n" ">> +\n" - ">> +\t\t\tspi0: spi at fffc8000 {\n" + ">> +\t\t\tspi0: spi@fffc8000 {\n" ">> +\t\t\t\tstatus = \"okay\";\n" "\n" "Nitpicking: \"status\" property is usually the last one of the node\n" "(before the child nodes if they exist)\n" "\n" ">> +\t\t\t\tcs-gpios = <&pioC 11 0>, <0>, <0>, <0>;\n" - ">> +\t\t\t\tmtd_dataflash at 0 {\n" + ">> +\t\t\t\tmtd_dataflash@0 {\n" ">> +\t\t\t\t\tcompatible = \"atmel,at45\", \"atmel,dataflash\";\n" ">> +\t\t\t\t\tspi-max-frequency = <15000000>;\n" ">> +\t\t\t\t\treg = <0>;\n" ">> +\t\t\t\t};\n" ">> +\t\t\t};\n" ">> +\n" - ">> +\t\t\tmmc0: mmc at fffa8000 {\n" + ">> +\t\t\tmmc0: mmc@fffa8000 {\n" ">> +\t\t\t\tpinctrl-0 = <\n" ">> +\t\t\t\t\t&pinctrl_board_mmc0\n" ">> +\t\t\t\t\t&pinctrl_mmc0_clk\n" ">> +\t\t\t\t\t&pinctrl_mmc0_slot1_cmd_dat0\n" ">> +\t\t\t\t\t&pinctrl_mmc0_slot1_dat1_3>;\n" ">> +\t\t\t\tstatus = \"okay\";\n" - ">> +\t\t\t\tslot at 1 {\n" + ">> +\t\t\t\tslot@1 {\n" ">> +\t\t\t\t\treg = <1>;\n" ">> +\t\t\t\t\tbus-width = <4>;\n" ">> +\t\t\t\t\tcd-gpios = <&pioC 8 GPIO_ACTIVE_HIGH>;\n" @@ -168,7 +178,7 @@ ">> +\t\t\t\t};\n" ">> +\t\t\t};\n" ">> +\n" - ">> +\t\t\tpinctrl at fffff400 {\n" + ">> +\t\t\tpinctrl@fffff400 {\n" ">> +\t\t\t\tmmc0 {\n" ">> +\t\t\t\t\tpinctrl_board_mmc0: mmc0-board {\n" ">> +\t\t\t\t\t\tatmel,pins =\n" @@ -185,14 +195,14 @@ ">> +\n" ">> +\t\t };\n" ">> +\n" - ">> +\t\t usb0: ohci at 00500000 {\n" + ">> +\t\t usb0: ohci@00500000 {\n" "> \n" "> Drop the leading 0. You'll need to fixup the base dts.\n" "> \n" ">> +\t\t status = \"okay\";\n" ">> +\t\t };\n" ">> +\n" - ">> +\t\t nand0: nand at 40000000 {\n" + ">> +\t\t nand0: nand@40000000 {\n" ">> +\t\t nand-bus-width = <8>;\n" ">> +\t\t nand-ecc-mode = \"soft\";\n" ">> +\t\t nand-on-flash-bbt = <1>;\n" @@ -200,7 +210,7 @@ ">> +\t\t };\n" ">> +\t };\n" ">> +\n" - ">> +\t i2c at 0 {\n" + ">> +\t i2c@0 {\n" ">> +\t\tstatus = \"okay\";\n" ">> +\t };\n" ">> +\n" @@ -225,4 +235,4 @@ "-- \n" Nicolas Ferre -aba71b5eb9ffce800fa5a6ecaba6be9291952cc51efd0ed4fbdd8a835ed2889f +316047f7fb49a15ffcf89423d0a36c1369ad599220970f4cc5cf23162b6d2056
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.