From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] xtf: remove setting ROOT path in common.mk
Date: Thu, 19 May 2016 14:52:57 +0100 [thread overview]
Message-ID: <573DC539.4090709@citrix.com> (raw)
In-Reply-To: <1463665617-21781-2-git-send-email-roger.pau@citrix.com>
On 19/05/16 14:46, Roger Pau Monne wrote:
> Since it might be included from different paths that have different levels
> of nestedness. Also all makefiles that include common.mk already define ROOT
> on their own.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
I really need to work on improving the build system. This one is
already creaking at the seams.
LGTM - Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> and committed.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-19 13:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 13:46 [PATCH 0/2] xtf: add launcher (+1 bugfix) Roger Pau Monne
2016-05-19 13:46 ` [PATCH 1/2] xtf: remove setting ROOT path in common.mk Roger Pau Monne
2016-05-19 13:52 ` Andrew Cooper [this message]
2016-05-19 13:46 ` [PATCH 2/2] xtf: add a launcher script Roger Pau Monne
2016-06-09 15:04 ` xenbits "official" repo for XTF (was Re: [PATCH 0/2] xtf: add launcher (+1 bugfix) Ian Jackson
2016-06-13 8:59 ` George Dunlap
2016-06-13 10:10 ` Andrew Cooper
2016-06-13 14:03 ` George Dunlap
2016-06-13 14:11 ` Ian Jackson
2016-06-14 17:27 ` Andrew Cooper
2016-06-15 8:31 ` George Dunlap
2016-06-20 17:03 ` Ian Jackson
2016-06-20 17:10 ` Konrad Rzeszutek Wilk
2016-06-21 10:17 ` Wei Liu
2016-06-21 10:36 ` David Vrabel
2016-06-21 10:42 ` Ian Jackson
2016-07-01 19:04 ` Ian Jackson
2016-07-06 11:19 ` Lars Kurth
2016-07-06 14:22 ` Konrad Rzeszutek Wilk
2016-07-07 11:10 ` Lars Kurth
2016-07-07 11:26 ` Andrew Cooper
2016-07-07 13:59 ` Ian Jackson
2016-07-07 14:02 ` David Vrabel
2016-07-07 14:58 ` Ian Jackson
2016-07-07 15:00 ` Ian Jackson
2016-07-07 14:11 ` Andrew Cooper
2016-07-07 17:17 ` Lars Kurth
2016-07-08 13:06 ` Andrew Cooper
2016-07-08 13:42 ` Lars Kurth
2016-07-08 13:48 ` Andrew Cooper
2016-07-12 15:13 ` George Dunlap
2016-07-15 10:21 ` Ian Jackson
2016-07-15 10:49 ` Lars Kurth
2016-07-18 14:36 ` Ian Jackson
2016-07-18 15:19 ` Lars Kurth
2016-07-18 15:30 ` Ian Jackson
2016-07-18 15:36 ` Lars Kurth
2016-07-18 15:58 ` Ian Jackson
2016-07-18 16:06 ` Lars Kurth
2016-07-18 15:31 ` Ian Jackson
2016-08-08 17:04 ` Ian Jackson
2016-07-07 15:22 ` Konrad Rzeszutek Wilk
2016-06-14 17:01 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573DC539.4090709@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.