All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: dri-devel@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/amd/powerplay: fix bugs of checking if dpm is running on Tonga
Date: Fri, 20 May 2016 15:54:57 +0200	[thread overview]
Message-ID: <573F1731.7020800@vodafone.de> (raw)
In-Reply-To: <1463752436-28045-1-git-send-email-deathsimple@vodafone.de>

Please ignore this one, I was on the wrong branch while sending mails.

Christian.

Am 20.05.2016 um 15:53 schrieb Christian König:
> From: Eric Huang <JinHuiEric.Huang@amd.com>
>
> Fixes OD failures on Tonga.
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Eric Huang <JinHuiEric.Huang@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>   drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> index cb28335..7c3f82b 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> @@ -5331,7 +5331,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table &
>   		(DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {
>   		PP_ASSERT_WITH_CODE(
> -			true == tonga_is_dpm_running(hwmgr),
> +			0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to freeze SCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5344,7 +5344,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   	if ((0 == data->mclk_dpm_key_disabled) &&
>   		(data->need_update_smu7_dpm_table &
>   		 DPMTABLE_OD_UPDATE_MCLK)) {
> -		PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),
> +		PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to freeze MCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5647,7 +5647,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table &
>   		(DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {
>   
> -		PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),
> +		PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to Unfreeze SCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5661,7 +5661,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_MCLK)) {
>   
>   		PP_ASSERT_WITH_CODE(
> -				true == tonga_is_dpm_running(hwmgr),
> +				0 == tonga_is_dpm_running(hwmgr),
>   				"Trying to Unfreeze MCLK DPM when DPM is disabled",
>   				);
>   		PP_ASSERT_WITH_CODE(

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <deathsimple@vodafone.de>
To: dri-devel@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/amd/powerplay: fix bugs of checking if dpm is running on Tonga
Date: Fri, 20 May 2016 15:54:57 +0200	[thread overview]
Message-ID: <573F1731.7020800@vodafone.de> (raw)
In-Reply-To: <1463752436-28045-1-git-send-email-deathsimple@vodafone.de>

Please ignore this one, I was on the wrong branch while sending mails.

Christian.

Am 20.05.2016 um 15:53 schrieb Christian König:
> From: Eric Huang <JinHuiEric.Huang@amd.com>
>
> Fixes OD failures on Tonga.
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Eric Huang <JinHuiEric.Huang@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>   drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> index cb28335..7c3f82b 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c
> @@ -5331,7 +5331,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table &
>   		(DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {
>   		PP_ASSERT_WITH_CODE(
> -			true == tonga_is_dpm_running(hwmgr),
> +			0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to freeze SCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5344,7 +5344,7 @@ static int tonga_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   	if ((0 == data->mclk_dpm_key_disabled) &&
>   		(data->need_update_smu7_dpm_table &
>   		 DPMTABLE_OD_UPDATE_MCLK)) {
> -		PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),
> +		PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to freeze MCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5647,7 +5647,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table &
>   		(DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK))) {
>   
> -		PP_ASSERT_WITH_CODE(true == tonga_is_dpm_running(hwmgr),
> +		PP_ASSERT_WITH_CODE(0 == tonga_is_dpm_running(hwmgr),
>   			"Trying to Unfreeze SCLK DPM when DPM is disabled",
>   			);
>   		PP_ASSERT_WITH_CODE(
> @@ -5661,7 +5661,7 @@ static int tonga_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)
>   		(data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_MCLK)) {
>   
>   		PP_ASSERT_WITH_CODE(
> -				true == tonga_is_dpm_running(hwmgr),
> +				0 == tonga_is_dpm_running(hwmgr),
>   				"Trying to Unfreeze MCLK DPM when DPM is disabled",
>   				);
>   		PP_ASSERT_WITH_CODE(

  parent reply	other threads:[~2016-05-20 13:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 13:53 [PATCH 1/2] drm/amd/powerplay: fix bugs of checking if dpm is running on Tonga Christian König
2016-05-20 13:53 ` Christian König
2016-05-20 13:53 ` [PATCH 2/2] dma-buf/fence: add fence_array fences v4 Christian König
2016-05-20 13:53   ` Christian König
2016-05-20 13:54 ` Christian König [this message]
2016-05-20 13:54   ` [PATCH 1/2] drm/amd/powerplay: fix bugs of checking if dpm is running on Tonga Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573F1731.7020800@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.