* [PATCH] iommu/exynos: Suppress unbinding to prevent system failure
@ 2016-05-20 13:48 ` Marek Szyprowski
0 siblings, 0 replies; 4+ messages in thread
From: Marek Szyprowski @ 2016-05-20 13:48 UTC (permalink / raw)
To: iommu, linux-samsung-soc, linux-arm-kernel
Cc: Marek Szyprowski, Joerg Roedel, Inki Dae, Kukjin Kim,
Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, stable
Removal of IOMMU driver cannot be done reliably, so Exynos IOMMU driver
doesn't support this operation. It is essential for system operation, so
it makes sense to prevent unbinding by disabling bind/unbind sysfs
feature for SYSMMU controller driver to avoid kernel ops or trashing
memory caused by such operation.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
CC: stable@vger.kernel.org # v4.2+
---
drivers/iommu/exynos-iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 558a40d3a6a0..d365c40a7b84 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -681,6 +681,7 @@ static struct platform_driver exynos_sysmmu_driver __refdata = {
.name = "exynos-sysmmu",
.of_match_table = sysmmu_of_match,
.pm = &sysmmu_pm_ops,
+ .suppress_bind_attrs = true,
}
};
--
1.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] iommu/exynos: Suppress unbinding to prevent system failure
@ 2016-05-20 13:48 ` Marek Szyprowski
0 siblings, 0 replies; 4+ messages in thread
From: Marek Szyprowski @ 2016-05-20 13:48 UTC (permalink / raw)
To: linux-arm-kernel
Removal of IOMMU driver cannot be done reliably, so Exynos IOMMU driver
doesn't support this operation. It is essential for system operation, so
it makes sense to prevent unbinding by disabling bind/unbind sysfs
feature for SYSMMU controller driver to avoid kernel ops or trashing
memory caused by such operation.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
CC: stable at vger.kernel.org # v4.2+
---
drivers/iommu/exynos-iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 558a40d3a6a0..d365c40a7b84 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -681,6 +681,7 @@ static struct platform_driver exynos_sysmmu_driver __refdata = {
.name = "exynos-sysmmu",
.of_match_table = sysmmu_of_match,
.pm = &sysmmu_pm_ops,
+ .suppress_bind_attrs = true,
}
};
--
1.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iommu/exynos: Suppress unbinding to prevent system failure
2016-05-20 13:48 ` Marek Szyprowski
@ 2016-05-20 14:02 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-05-20 14:02 UTC (permalink / raw)
To: Marek Szyprowski, iommu, linux-samsung-soc, linux-arm-kernel
Cc: Joerg Roedel, Inki Dae, Kukjin Kim, Bartlomiej Zolnierkiewicz,
stable
On 05/20/2016 03:48 PM, Marek Szyprowski wrote:
> Removal of IOMMU driver cannot be done reliably, so Exynos IOMMU driver
> doesn't support this operation. It is essential for system operation, so
> it makes sense to prevent unbinding by disabling bind/unbind sysfs
> feature for SYSMMU controller driver to avoid kernel ops or trashing
> memory caused by such operation.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> CC: stable@vger.kernel.org # v4.2+
> ---
> drivers/iommu/exynos-iommu.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] iommu/exynos: Suppress unbinding to prevent system failure
@ 2016-05-20 14:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-05-20 14:02 UTC (permalink / raw)
To: linux-arm-kernel
On 05/20/2016 03:48 PM, Marek Szyprowski wrote:
> Removal of IOMMU driver cannot be done reliably, so Exynos IOMMU driver
> doesn't support this operation. It is essential for system operation, so
> it makes sense to prevent unbinding by disabling bind/unbind sysfs
> feature for SYSMMU controller driver to avoid kernel ops or trashing
> memory caused by such operation.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> CC: stable at vger.kernel.org # v4.2+
> ---
> drivers/iommu/exynos-iommu.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-20 14:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 13:48 [PATCH] iommu/exynos: Suppress unbinding to prevent system failure Marek Szyprowski
2016-05-20 13:48 ` Marek Szyprowski
2016-05-20 14:02 ` Krzysztof Kozlowski
2016-05-20 14:02 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.